You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/06/09 10:41:41 UTC
[GitHub] [incubator-kyuubi] yaooqinn commented on a diff in pull request #2839: Refactor changelog
yaooqinn commented on code in PR #2839:
URL: https://github.com/apache/incubator-kyuubi/pull/2839#discussion_r893349203
##########
build/release/generate_changelog.sh:
##########
@@ -49,6 +49,6 @@ if [ "${LAST_RELEASE_TAG}" = "-h" ]; then
fi
## Add title for changelog doc.
-echo "## Changelog for Apache Incubating Kyuubi $RELEASE_VERSION " > $CHANGELOG_PATH
+echo "## Changelog for Apache Kyuubi(Incubating) $RELEASE_VERSION" > $CHANGELOG_PATH
## Append well-formatted git log to changelog file.
-git log --pretty="- [%s]($KYUUBI_GITHUB_COMMIT_URL%h) " $LAST_RELEASE_TAG..$CURRENT_RELEASE_TAG | grep -v "\[RELEASE\]" >> $CHANGELOG_PATH
\ No newline at end of file
+git log --pretty="[%s]($KYUUBI_GITHUB_COMMIT_URL%h)%n" $LAST_RELEASE_TAG..$CURRENT_RELEASE_TAG | grep -v "\[RELEASE\]" >> $CHANGELOG_PATH
Review Comment:
%n is also unnecessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org