[jira] [Commented] (MSHADE-262) Add jpms goal

["Markus Karg (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MSHADE-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16810237#comment-16810237 ] 

Markus Karg commented on MSHADE-262:
------------------------------------

Maybe it would be a good idea to actually *not* provide a new goal, but instead have a different *Shader* strategy. This sounds most intuitive: What you actually want to reach is *not* that another goal is reached – you still want to *shade* stuff. But you want to use a different *strategy* when shading: A JPMS strategy. So my advice would be: Keep the goal, but change the shader.

> Add jpms goal
> -------------
>
>                 Key: MSHADE-262
>                 URL: https://issues.apache.org/jira/browse/MSHADE-262
>             Project: Maven Shade Plugin
>          Issue Type: New Feature
>            Reporter: Robert Scholte
>            Assignee: Robert Scholte
>            Priority: Major
>
> With Java 9 we get module descriptors for strong encapsulation and reliable configuration.
> When shading we should not merge or ignore these descriptors.
> In case of an application we should think of the way spring boot works, i.e. bundle the jars in a jar and provide a new classloader. This is the only way to preserve the strong encapsulation right now.
> After a talk with [~pwebb] and [~dblevins] we came to the conclusion that it should NOT be combined with the current shade goal. First idea was to make a new plugin, but after some rethinking I'd prefer to just make a separate goal for it in this shade-plugin.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)