[GitHub] [flink] huwh commented on pull request #21233: [FLINK-29870] [ResourceManager]Split ResourceActions to ResourceAllocator and ResourceEventListener.

[GitBox <gi...@apache.org>]

huwh commented on PR #21233:
URL: https://github.com/apache/flink/pull/21233#issuecomment-1330443060

   > Well, I meant removing `notifyAllocationFailure` in a separate hotfix commit in this PR, to keep the commit history clean. Never mind. I Have merged the PRfor [FLINK-30084](https://issues.apache.org/jira/browse/FLINK-30084).
   > 
   > Could you please rebase this PR and re-organize the commits. When addressing comments, it would be nice to keep the commits organized as to be merged. You can either address comments in fixup commits that clearly shows which previous commits they should be squashed into, or modify the previous commits and make a force-push if the comments cannot easily be addressed with fixup commits.
   
   Hi, @xintongsong, I've rebased this PR, but it's not easy to automatically squash with fixup commits because there are lots of classes rename. So, I modified the previous commit to addressing comments.
   Could you please review this again in your free time. Thanks a lot.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org