You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "John Casey (JIRA)" <ji...@codehaus.org> on 2008/08/07 22:16:27 UTC

[jira] Created: (MNG-3700) ModelUtils.clone doesn't clone plugin entries where inherited == false

ModelUtils.clone doesn't clone plugin entries where inherited == false
----------------------------------------------------------------------

                 Key: MNG-3700
                 URL: http://jira.codehaus.org/browse/MNG-3700
             Project: Maven 2
          Issue Type: Bug
          Components: POM
    Affects Versions: 2.0.10
            Reporter: John Casey


ModelUtils.clone(..) uses the ModelInheritanceAssembler under the covers, with assembleAsInheritance == true. This is not strictly true, since inheritance semantics are different in some ways from clone semantics.

This becomes an issue where plugins are concerned, especially when the plugin entry in the POM contains inherited == "false", which will lead to the cloning process *excluding* that plugin from the clone result.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (MNG-3700) ModelUtils.clone doesn't clone plugin entries where inherited == false

Posted by "Benjamin Bentmann (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-3700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Benjamin Bentmann closed MNG-3700.
----------------------------------

    Resolution: Fixed
      Assignee: Benjamin Bentmann

ModelUtils is no longer used in 3.x, instead it uses Modello generated clone() methods.

> ModelUtils.clone doesn't clone plugin entries where inherited == false
> ----------------------------------------------------------------------
>
>                 Key: MNG-3700
>                 URL: http://jira.codehaus.org/browse/MNG-3700
>             Project: Maven 2 & 3
>          Issue Type: Bug
>          Components: POM
>    Affects Versions: 2.0.10
>            Reporter: John Casey
>            Assignee: Benjamin Bentmann
>             Fix For: 3.0-alpha-8
>
>         Attachments: ModelUtilsTest.patch
>
>
> ModelUtils.clone(..) uses the ModelInheritanceAssembler under the covers, with assembleAsInheritance == true. This is not strictly true, since inheritance semantics are different in some ways from clone semantics.
> This becomes an issue where plugins are concerned, especially when the plugin entry in the POM contains inherited == "false", which will lead to the cloning process *excluding* that plugin from the clone result.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MNG-3700) ModelUtils.clone doesn't clone plugin entries where inherited == false

Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-3700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

John Casey updated MNG-3700:
----------------------------

    Testcase included: yes
        Fix Version/s: 2.0.11

> ModelUtils.clone doesn't clone plugin entries where inherited == false
> ----------------------------------------------------------------------
>
>                 Key: MNG-3700
>                 URL: http://jira.codehaus.org/browse/MNG-3700
>             Project: Maven 2
>          Issue Type: Bug
>          Components: POM
>    Affects Versions: 2.0.10
>            Reporter: John Casey
>             Fix For: 2.0.11
>
>         Attachments: ModelUtilsTest.patch
>
>
> ModelUtils.clone(..) uses the ModelInheritanceAssembler under the covers, with assembleAsInheritance == true. This is not strictly true, since inheritance semantics are different in some ways from clone semantics.
> This becomes an issue where plugins are concerned, especially when the plugin entry in the POM contains inherited == "false", which will lead to the cloning process *excluding* that plugin from the clone result.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MNG-3700) ModelUtils.clone doesn't clone plugin entries where inherited == false

Posted by "Jason van Zyl (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-3700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jason van Zyl updated MNG-3700:
-------------------------------

    Fix Version/s:     (was: 2.2.2)
                   3.0-alpha-7

> ModelUtils.clone doesn't clone plugin entries where inherited == false
> ----------------------------------------------------------------------
>
>                 Key: MNG-3700
>                 URL: http://jira.codehaus.org/browse/MNG-3700
>             Project: Maven 2 & 3
>          Issue Type: Bug
>          Components: POM
>    Affects Versions: 2.0.10
>            Reporter: John Casey
>             Fix For: 3.0-alpha-7
>
>         Attachments: ModelUtilsTest.patch
>
>
> ModelUtils.clone(..) uses the ModelInheritanceAssembler under the covers, with assembleAsInheritance == true. This is not strictly true, since inheritance semantics are different in some ways from clone semantics.
> This becomes an issue where plugins are concerned, especially when the plugin entry in the POM contains inherited == "false", which will lead to the cloning process *excluding* that plugin from the clone result.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MNG-3700) ModelUtils.clone doesn't clone plugin entries where inherited == false

Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-3700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

John Casey updated MNG-3700:
----------------------------

    Attachment: ModelUtilsTest.patch

test case (unit test patch for ModelUtilsTest in maven-project)

> ModelUtils.clone doesn't clone plugin entries where inherited == false
> ----------------------------------------------------------------------
>
>                 Key: MNG-3700
>                 URL: http://jira.codehaus.org/browse/MNG-3700
>             Project: Maven 2
>          Issue Type: Bug
>          Components: POM
>    Affects Versions: 2.0.10
>            Reporter: John Casey
>             Fix For: 2.0.11
>
>         Attachments: ModelUtilsTest.patch
>
>
> ModelUtils.clone(..) uses the ModelInheritanceAssembler under the covers, with assembleAsInheritance == true. This is not strictly true, since inheritance semantics are different in some ways from clone semantics.
> This becomes an issue where plugins are concerned, especially when the plugin entry in the POM contains inherited == "false", which will lead to the cloning process *excluding* that plugin from the clone result.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira