You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/06 08:24:40 UTC
[GitHub] [superset] graceguo-supercat opened a new issue #12303: [explore] datapanel search: remove search input do not trigger new search
graceguo-supercat opened a new issue #12303:
URL: https://github.com/apache/superset/issues/12303
#### How to reproduce the bug
1. Go to explore view,
2. type in some long text in the search input box, you will see matched metrics and columns,
3. remove a few words in the search input box, you should see more matched metrics and columns
4. but there is no new search action triggered.
5. Note: in my example, there are some very long metrics names, and its name got truncated. **Please add tooltip to display full text.**
### Environment
latest master
cc @junlincc @zuzana-vej
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on issue #12303: [explore] datapanel search: remove search input do not trigger new search
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #12303:
URL: https://github.com/apache/superset/issues/12303#issuecomment-757135007
Confirming this issue is resolved in latest master 01/09/2021 @ 11:20am (UTC)
all designed and new functions are working properly in Explore DataPanel
follow up discussion for [[Explore]allow user to search metrics and columns by properties in data panel](https://github.com/apache/superset/issues/12376) in Q1
cc @graceguo-supercat @ktmud @zuzana-vej @mistercrunch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on issue #12303: [explore] datapanel search: remove search input do not trigger new search
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #12303:
URL: https://github.com/apache/superset/issues/12303#issuecomment-755524219
We don't have a solution for showing tooltip only on the ones w titles that can not be fully displayed. This project's on the Q1 roadmap. I am afraid that adding tooltip on all columns and metrics despite their length isn't an optimized solution visually.
Column titles were truncated. Only a limited number of columns and metrics were displayed in the previous versions, which means this feature is already a huge step forward in terms of the information's visibility.
I understand your request, and we are committed to improving. Pls allow some time for research/design/technical discussion to happen on this one.
@mihir174
Old:
<img width="570" alt="Screen Shot 2021-01-06 at 10 59 29 AM" src="https://user-images.githubusercontent.com/67837651/103809371-4443f280-500e-11eb-86c6-ede8b65124f8.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on issue #12303: [explore] datapanel search: remove search input do not trigger new search
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #12303:
URL: https://github.com/apache/superset/issues/12303#issuecomment-755330417
thanks for testing our new feature extensively and keeping the quality bar high for Superset @graceguo-supercat 🙏
Two issues here
1. Deleting text to trigger new search action - P1
2. Display super long column name - Our current solution is to implement resizable data panel. tooltip will not be ideal for UI/UX, as it will be added to all columns names and metrics. We should get to resizable in a couple weeks. hope that's not a deal breaker for you. @graceguo-supercat
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on issue #12303: [explore] datapanel search: remove search input do not trigger new search
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #12303:
URL: https://github.com/apache/superset/issues/12303#issuecomment-757135007
Confirming this issue is resolved in latest master 01/09/2021 @ 11:20am (UTC)
all designed and new functions are working properly in Explore DataPanel
follow up discussion for [[Explore]allow user to search metrics and columns by properties in data panel](https://github.com/apache/superset/issues/12376) in Q1
cc @graceguo-supercat @ktmud @zuzana-vej @mistercrunch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] graceguo-supercat commented on issue #12303: [explore] datapanel search: remove search input do not trigger new search
Posted by GitBox <gi...@apache.org>.
graceguo-supercat commented on issue #12303:
URL: https://github.com/apache/superset/issues/12303#issuecomment-756498123
Can I have another request? Could you make the search input box stay, not scroll with the very long Columns and Metrics section?
Even we set only show max 50 entries, it is still over a page height. Scroll back and forth to find search input box is a little inconvenient. thanks @junlincc and @pkdotson
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on issue #12303: [explore] datapanel search: remove search input do not trigger new search
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #12303:
URL: https://github.com/apache/superset/issues/12303#issuecomment-756499440
> Could you make the search input box stay, not scroll with the very long Columns and Metrics section?
yup! that makes perfect sense. im opening a new issue, as the original request has been addressed by https://github.com/apache/superset/pull/12319, i'm closing this one for now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] graceguo-supercat commented on issue #12303: [explore] datapanel search: remove search input do not trigger new search
Posted by GitBox <gi...@apache.org>.
graceguo-supercat commented on issue #12303:
URL: https://github.com/apache/superset/issues/12303#issuecomment-755445545
1. resizable is good improvement. when there is a lot of long text, user want to resize wider. when the current dataset is small, user may want to keep it narrower.
2. but even when user set datapanel narrow, user should still be able to read full name by tooltip.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on issue #12303: [explore] datapanel search: remove search input do not trigger new search
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #12303:
URL: https://github.com/apache/superset/issues/12303#issuecomment-755332596
@pkdotson Please take this one(Deleting text to trigger new search action), along with https://github.com/apache/superset/issues/12299 and https://github.com/apache/superset/issues/12233
you have the most knowledge in this area. 🙏
pls let me know
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc closed issue #12303: [explore] datapanel search: remove search input do not trigger new search
Posted by GitBox <gi...@apache.org>.
junlincc closed issue #12303:
URL: https://github.com/apache/superset/issues/12303
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc edited a comment on issue #12303: [explore] datapanel search: remove search input do not trigger new search
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on issue #12303:
URL: https://github.com/apache/superset/issues/12303#issuecomment-755332596
@pkdotson Please take this one(Deleting text to trigger new search action), along with https://github.com/apache/superset/issues/12299 and https://github.com/apache/superset/issues/12233
you have the most knowledge in this area. 🙏
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org