You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Raphael Wegmueller (JIRA)" <ji...@apache.org> on 2009/12/30 14:29:29 UTC

[jira] Created: (SLING-1256) Util.fixEncoding(ParameterMap) should ignore case when comparing encodings

Util.fixEncoding(ParameterMap) should ignore case when comparing encodings
--------------------------------------------------------------------------

                 Key: SLING-1256
                 URL: https://issues.apache.org/jira/browse/SLING-1256
             Project: Sling
          Issue Type: Improvement
          Components: Engine
    Affects Versions: Engine 2.0.6
            Reporter: Raphael Wegmueller
            Priority: Minor


when posting content with parameter _charset_ set to "utf-8", but the Content-Type header is set to "application/x-www-form-urlencoded; charset=UTF-8", Util.fixEncoding(ParameterMap) will reencode the content, which breaks most special characters.

since there seems to be no accord on whether encodings should be submitted upper or lower case, sling should simply ignore the case when comparing them.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Resolved: (SLING-1256) Util.fixEncoding(ParameterMap) should ignore case when comparing encodings

Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SLING-1256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Felix Meschberger resolved SLING-1256.
--------------------------------------

       Resolution: Fixed
    Fix Version/s: Engine 2.1.0
         Assignee: Felix Meschberger

Thanks for reporting the issue and providing a patch. I have applied an extended version in Rev.894611 which fixes another occurrence of character set comparision.

It is in fact correct to ignore case when comparing character set names, since they are defined to not be case-sensitive.

> Util.fixEncoding(ParameterMap) should ignore case when comparing encodings
> --------------------------------------------------------------------------
>
>                 Key: SLING-1256
>                 URL: https://issues.apache.org/jira/browse/SLING-1256
>             Project: Sling
>          Issue Type: Improvement
>          Components: Engine
>    Affects Versions: Engine 2.0.6
>            Reporter: Raphael Wegmueller
>            Assignee: Felix Meschberger
>            Priority: Minor
>             Fix For: Engine 2.1.0
>
>         Attachments: Util.patch
>
>
> when posting content with parameter _charset_ set to "utf-8", but the Content-Type header is set to "application/x-www-form-urlencoded; charset=UTF-8", Util.fixEncoding(ParameterMap) will reencode the content, which breaks most special characters.
> since there seems to be no accord on whether encodings should be submitted upper or lower case, sling should simply ignore the case when comparing them.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (SLING-1256) Util.fixEncoding(ParameterMap) should ignore case when comparing encodings

Posted by "Raphael Wegmueller (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SLING-1256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Raphael Wegmueller updated SLING-1256:
--------------------------------------

    Attachment: Util.patch

patch for Util.java

> Util.fixEncoding(ParameterMap) should ignore case when comparing encodings
> --------------------------------------------------------------------------
>
>                 Key: SLING-1256
>                 URL: https://issues.apache.org/jira/browse/SLING-1256
>             Project: Sling
>          Issue Type: Improvement
>          Components: Engine
>    Affects Versions: Engine 2.0.6
>            Reporter: Raphael Wegmueller
>            Priority: Minor
>         Attachments: Util.patch
>
>
> when posting content with parameter _charset_ set to "utf-8", but the Content-Type header is set to "application/x-www-form-urlencoded; charset=UTF-8", Util.fixEncoding(ParameterMap) will reencode the content, which breaks most special characters.
> since there seems to be no accord on whether encodings should be submitted upper or lower case, sling should simply ignore the case when comparing them.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Closed: (SLING-1256) Util.fixEncoding(ParameterMap) should ignore case when comparing encodings

Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SLING-1256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Felix Meschberger closed SLING-1256.
------------------------------------


Close after release

> Util.fixEncoding(ParameterMap) should ignore case when comparing encodings
> --------------------------------------------------------------------------
>
>                 Key: SLING-1256
>                 URL: https://issues.apache.org/jira/browse/SLING-1256
>             Project: Sling
>          Issue Type: Improvement
>          Components: Engine
>    Affects Versions: Engine 2.0.6
>            Reporter: Raphael Wegmueller
>            Assignee: Felix Meschberger
>            Priority: Minor
>             Fix For: Engine 2.1.0
>
>         Attachments: Util.patch
>
>
> when posting content with parameter _charset_ set to "utf-8", but the Content-Type header is set to "application/x-www-form-urlencoded; charset=UTF-8", Util.fixEncoding(ParameterMap) will reencode the content, which breaks most special characters.
> since there seems to be no accord on whether encodings should be submitted upper or lower case, sling should simply ignore the case when comparing them.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.