Re: [PR] KAFKA-19453: Ignore group not found in share group record replay. [kafka]

["dongnuo123 (via GitHub)" <gi...@apache.org>]

dongnuo123 commented on code in PR #20076:
URL: https://github.com/apache/kafka/pull/20076#discussion_r2178031715


##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -5356,16 +5356,23 @@ public void replay(
         String groupId = key.groupId();
         String memberId = key.memberId();
 
-        ShareGroup shareGroup = getOrMaybeCreatePersistedShareGroup(groupId, value != null);
+        ShareGroup shareGroup;
+        ShareGroupMember oldMember;
+        try {
+            shareGroup = getOrMaybeCreatePersistedShareGroup(groupId, value != null);
+            oldMember = shareGroup.getOrMaybeCreateMember(memberId, value != null);
+        } catch (GroupIdNotFoundException | UnknownMemberIdException ex) {
+            log.debug("ShareGroupMemberMetadata tombstone without group - {}", groupId, ex);

Review Comment:
   Should we adjust the logs cause it doesn't apply to the case of `UnknownMemberIdException`. Ditto for `ShareGroupCurrentMemberAssignment`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org