You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/07/31 14:04:45 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request, #6746: sched: Remove KEEP_ALIVE_HACK hack
xiaoxiang781216 opened a new pull request, #6746:
URL: https://github.com/apache/incubator-nuttx/pull/6746
## Summary
## Impact
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #6746: sched: Remove KEEP_ALIVE_HACK hack
Posted by GitBox <gi...@apache.org>.
acassis commented on PR #6746:
URL: https://github.com/apache/incubator-nuttx/pull/6746#issuecomment-1205321445
@xiaoxiang781216 is the some testing to guarantee that sporadic scheduling is working? I found a good explanation here: https://www.embedded.com/scheduling-sporadic-events/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6746: sched: Remove KEEP_ALIVE_HACK hack
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #6746:
URL: https://github.com/apache/incubator-nuttx/pull/6746#discussion_r934670822
##########
sched/sched/sched_timerexpiration.c:
##########
@@ -233,15 +212,6 @@ static uint32_t nxsched_cpu_scheduler(int cpu, uint32_t ticks,
/* Returning zero means that there is no interesting event to be timed */
-#ifdef KEEP_ALIVE_HACK
- if (ret == 0)
- {
- /* Apply the keep alive hack */
-
- return KEEP_ALIVE_TICKS;
Review Comment:
Why not? the sporadic share the same code path as round-robin.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6746: sched: Remove KEEP_ALIVE_HACK hack
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #6746:
URL: https://github.com/apache/incubator-nuttx/pull/6746#issuecomment-1205420043
> @xiaoxiang781216 is the some testing to guarantee that sporadic scheduling is working? I found a good explanation here: https://www.embedded.com/scheduling-sporadic-events/
No, we never use the sporadic scheduler.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6746: sched: Remove KEEP_ALIVE_HACK hack
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #6746:
URL: https://github.com/apache/incubator-nuttx/pull/6746#discussion_r934037676
##########
sched/sched/sched_timerexpiration.c:
##########
@@ -233,15 +212,6 @@ static uint32_t nxsched_cpu_scheduler(int cpu, uint32_t ticks,
/* Returning zero means that there is no interesting event to be timed */
-#ifdef KEEP_ALIVE_HACK
Review Comment:
Just for reference: https://github.com/apache/incubator-nuttx/commit/6546fa39c7a#diff-ec549151b9b686bd3d14a18d3a6a0ca940987bff9b59ab299166ea506f604219
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 closed pull request #6746: sched: Remove KEEP_ALIVE_HACK hack
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 closed pull request #6746: sched: Remove KEEP_ALIVE_HACK hack
URL: https://github.com/apache/nuttx/pull/6746
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6746: sched: Remove KEEP_ALIVE_HACK hack
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #6746:
URL: https://github.com/apache/incubator-nuttx/pull/6746#discussion_r934037676
##########
sched/sched/sched_timerexpiration.c:
##########
@@ -233,15 +212,6 @@ static uint32_t nxsched_cpu_scheduler(int cpu, uint32_t ticks,
/* Returning zero means that there is no interesting event to be timed */
-#ifdef KEEP_ALIVE_HACK
Review Comment:
Just for reference: https://github.com/apache/incubator-nuttx/commit/6546fa39c7a#diff-831fbabe8026cccb9ceb5e75a70baec2a22c60741930d350d91a96f13fd7ec74
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] mkeydevelop commented on a diff in pull request #6746: sched: Remove KEEP_ALIVE_HACK hack
Posted by GitBox <gi...@apache.org>.
mkeydevelop commented on code in PR #6746:
URL: https://github.com/apache/incubator-nuttx/pull/6746#discussion_r934140001
##########
sched/sched/sched_timerexpiration.c:
##########
@@ -233,15 +212,6 @@ static uint32_t nxsched_cpu_scheduler(int cpu, uint32_t ticks,
/* Returning zero means that there is no interesting event to be timed */
-#ifdef KEEP_ALIVE_HACK
- if (ret == 0)
- {
- /* Apply the keep alive hack */
-
- return KEEP_ALIVE_TICKS;
Review Comment:
Time slice not work on sporadic?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org