You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Enis Soztutar (JIRA)" <ji...@apache.org> on 2012/11/21 03:12:58 UTC

[jira] [Created] (HBASE-7201) Convert HLog / HFile metadata content to PB

Enis Soztutar created HBASE-7201:
------------------------------------

             Summary: Convert HLog / HFile metadata content to PB
                 Key: HBASE-7201
                 URL: https://issues.apache.org/jira/browse/HBASE-7201
             Project: HBase
          Issue Type: Sub-task
          Components: HFile, Protobufs, wal
            Reporter: Enis Soztutar


Some of the remaining discussions for PB conversions: 
 - Convert the HFile/HLog metadata to PB.
 - WALEdit, HLogKey should be converted? We don't want to repeat the PBMagic, and the PB overhead can be high, but this is needed for replication?
 - We said no to converting KV.

These should not block 0.96. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-7201) Convert HLog / HFile metadata content to PB

Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-7201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505104#comment-13505104 ] 

Devaraj Das commented on HBASE-7201:
------------------------------------

+1 for converting them to PB. 
                
> Convert HLog / HFile metadata content to PB
> -------------------------------------------
>
>                 Key: HBASE-7201
>                 URL: https://issues.apache.org/jira/browse/HBASE-7201
>             Project: HBase
>          Issue Type: Sub-task
>          Components: HFile, Protobufs, wal
>            Reporter: Enis Soztutar
>             Fix For: 0.96.0
>
>
> Some of the remaining discussions for PB conversions: 
>  - Convert the HFile/HLog metadata to PB.
>  - WALEdit, HLogKey should be converted? We don't want to repeat the PBMagic, and the PB overhead can be high, but this is needed for replication?
>  - We said no to converting KV.
> These should not block 0.96. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-7201) Convert HLog / HFile metadata content to PB

Posted by "stack (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-7201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack updated HBASE-7201:
-------------------------

    Attachment: 7201.txt

Patch that converts hfile hfileinfo to pb.  Ups the hfile minor version.  hfile can read old and new files whether hfileinfo is Writable or not (doesn't use Writable).  More to do in hfile arena.  This is a start.

Made this issue a blocker.
                
> Convert HLog / HFile metadata content to PB
> -------------------------------------------
>
>                 Key: HBASE-7201
>                 URL: https://issues.apache.org/jira/browse/HBASE-7201
>             Project: HBase
>          Issue Type: Sub-task
>          Components: HFile, Protobufs, wal
>            Reporter: Enis Soztutar
>            Priority: Blocker
>             Fix For: 0.96.0
>
>         Attachments: 7201.txt
>
>
> Some of the remaining discussions for PB conversions: 
>  - Convert the HFile/HLog metadata to PB.
>  - WALEdit, HLogKey should be converted? We don't want to repeat the PBMagic, and the PB overhead can be high, but this is needed for replication?
>  - We said no to converting KV.
> These should not block 0.96. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-7201) Convert HLog / HFile metadata content to PB

Posted by "stack (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-7201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505874#comment-13505874 ] 

stack commented on HBASE-7201:
------------------------------

Redid the attached patch as a removal of HbaseMapWritable over in HBASE-7232.  Would like to get that in as subtask on this issue.

I looked at what else is involved converting HFile.  There is an awkward meta block functionality that takes 'Writable' which is a little exotic but is used by the bloom filter stuff.  Its awkward.  I could convert to Message but not sure how to make it backward compatible just yet.
                
> Convert HLog / HFile metadata content to PB
> -------------------------------------------
>
>                 Key: HBASE-7201
>                 URL: https://issues.apache.org/jira/browse/HBASE-7201
>             Project: HBase
>          Issue Type: Sub-task
>          Components: HFile, Protobufs, wal
>            Reporter: Enis Soztutar
>            Priority: Blocker
>             Fix For: 0.96.0
>
>         Attachments: 7201.txt
>
>
> Some of the remaining discussions for PB conversions: 
>  - Convert the HFile/HLog metadata to PB.
>  - WALEdit, HLogKey should be converted? We don't want to repeat the PBMagic, and the PB overhead can be high, but this is needed for replication?
>  - We said no to converting KV.
> These should not block 0.96. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-7201) Convert HLog / HFile metadata content to PB

Posted by "Sergey Shelukhin (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-7201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13510037#comment-13510037 ] 

Sergey Shelukhin commented on HBASE-7201:
-----------------------------------------

Is this still a blocker? Comments in HFile seem to indicate it isn't
                
> Convert HLog / HFile metadata content to PB
> -------------------------------------------
>
>                 Key: HBASE-7201
>                 URL: https://issues.apache.org/jira/browse/HBASE-7201
>             Project: HBase
>          Issue Type: Sub-task
>          Components: HFile, Protobufs, wal
>            Reporter: Enis Soztutar
>            Priority: Blocker
>             Fix For: 0.96.0
>
>         Attachments: 7201.txt
>
>
> Some of the remaining discussions for PB conversions: 
>  - Convert the HFile/HLog metadata to PB.
>  - WALEdit, HLogKey should be converted? We don't want to repeat the PBMagic, and the PB overhead can be high, but this is needed for replication?
>  - We said no to converting KV.
> These should not block 0.96. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-7201) Convert HLog / HFile metadata content to PB

Posted by "stack (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-7201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack updated HBASE-7201:
-------------------------

    Priority: Blocker  (was: Major)
    
> Convert HLog / HFile metadata content to PB
> -------------------------------------------
>
>                 Key: HBASE-7201
>                 URL: https://issues.apache.org/jira/browse/HBASE-7201
>             Project: HBase
>          Issue Type: Sub-task
>          Components: HFile, Protobufs, wal
>            Reporter: Enis Soztutar
>            Priority: Blocker
>             Fix For: 0.96.0
>
>         Attachments: 7201.txt
>
>
> Some of the remaining discussions for PB conversions: 
>  - Convert the HFile/HLog metadata to PB.
>  - WALEdit, HLogKey should be converted? We don't want to repeat the PBMagic, and the PB overhead can be high, but this is needed for replication?
>  - We said no to converting KV.
> These should not block 0.96. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira