You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2023/08/27 18:50:59 UTC

[commons-dbcp] 05/10: Use try-with-resources

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-dbcp.git

commit a715208e457980268d4c0d15818ad8a9f9b03b64
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Sun Aug 27 12:43:58 2023 -0400

    Use try-with-resources
---
 .../commons/dbcp2/TestAbandonedBasicDataSource.java   | 19 ++++++++++---------
 1 file changed, 10 insertions(+), 9 deletions(-)

diff --git a/src/test/java/org/apache/commons/dbcp2/TestAbandonedBasicDataSource.java b/src/test/java/org/apache/commons/dbcp2/TestAbandonedBasicDataSource.java
index 80447927..dd1aa2c9 100644
--- a/src/test/java/org/apache/commons/dbcp2/TestAbandonedBasicDataSource.java
+++ b/src/test/java/org/apache/commons/dbcp2/TestAbandonedBasicDataSource.java
@@ -351,14 +351,15 @@ public class TestAbandonedBasicDataSource extends TestBasicDataSource {
      */
     @Test
     public void testLastUsedUpdate() throws Exception {
-        final DelegatingConnection<?> conn = (DelegatingConnection<?>) ds.getConnection();
-        final PreparedStatement ps = conn.prepareStatement("");
-        final CallableStatement cs = conn.prepareCall("");
-        final Statement st = conn.prepareStatement("");
-        checkLastUsedStatement(ps, conn);
-        checkLastUsedPreparedStatement(ps, conn);
-        checkLastUsedStatement(cs, conn);
-        checkLastUsedPreparedStatement(cs, conn);
-        checkLastUsedStatement(st, conn);
+        try (DelegatingConnection<?> conn = (DelegatingConnection<?>) ds.getConnection();
+                final PreparedStatement ps = conn.prepareStatement("");
+                final CallableStatement cs = conn.prepareCall("");
+                final Statement st = conn.prepareStatement("")) {
+            checkLastUsedStatement(ps, conn);
+            checkLastUsedPreparedStatement(ps, conn);
+            checkLastUsedStatement(cs, conn);
+            checkLastUsedPreparedStatement(cs, conn);
+            checkLastUsedStatement(st, conn);
+        }
     }
 }