You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by GitBox <gi...@apache.org> on 2020/06/25 18:11:42 UTC

[GitHub] [storm] Ethanlm commented on a change in pull request #3294: STORM-3648 add meter to track worker heartbeat rate

Ethanlm commented on a change in pull request #3294:
URL: https://github.com/apache/storm/pull/3294#discussion_r445741554



##########
File path: storm-client/src/jvm/org/apache/storm/daemon/worker/Worker.java
##########
@@ -196,6 +198,8 @@ private Object loadWorker(IStateStorage stateStorage, IStormClusterState stormCl
         throws Exception {
         workerState = new WorkerState(conf, context, topologyId, assignmentId, supervisorIfaceSupplier, port, workerId,
                                       topologyConf, stateStorage, stormClusterState, autoCreds, metricRegistry);
+        this.heatbeatMeter = metricRegistry.meter("doHeartbeat-calls", workerState.getWorkerTopologyContext(),
+                "__system", -1, "default");

Review comment:
       It is better to not hardcode it. We can use `SYSTEM_COMPONENT_ID`, `SYSTEM_TASK_ID`. And it looks like it doesn't make much sense to have `streamId` here.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org