[GitHub] [skywalking-python] Superskyyy commented on a diff in pull request #288: Add prefork support for uwsgi and gunicorn

["Superskyyy (via GitHub)" <gi...@apache.org>]

Superskyyy commented on code in PR #288:
URL: https://github.com/apache/skywalking-python/pull/288#discussion_r1110457401


##########
CHANGELOG.md:
##########
@@ -8,7 +8,8 @@
   please check with the latest official documentation before upgrading. (#273, #282)
   https://skywalking.apache.org/docs/skywalking-python/v1.0.0/en/setup/configuration/
   - **BREAKING**: All agent core capabilities are now covered by test cases and enabled by default (Trace, Log, PVM runtime metrics, Profiler)
-
+  - **BREAKING**: DockerHub Python agent images since v1.0.0 will no longer include the `run` part in `ENTRYPOINT ["sw-python", "run"]`, 
+  user should prefix their command with `[-d/--debug] run [-p/--prefork] <Command>` for extra flexibility.

Review Comment:
   hmm, I thought this is a true reflection of what the code does, did I understand something wrong? 
   
   -d is a global flag to sw-python and -p is a local flag to the `run` option. <command> is user's own application command.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org