You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Venkat Ranganathan <n....@live.com> on 2014/09/23 09:18:14 UTC
Re: Review Request 25090: SQOOP-1471: Use Hadoop CredentialProvider
API to encyrpt passwords at rest
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25090/
-----------------------------------------------------------
(Updated Sept. 23, 2014, 7:18 a.m.)
Review request for Sqoop.
Changes
-------
Updated patch after testing on Windows
Bugs: SQOOP-1471
https://issues.apache.org/jira/browse/SQOOP-1471
Repository: sqoop-trunk
Description
-------
Use the Hadoop Credential Provider facility to use password aliases instead of password so that password need not be embedded in clear text in scipts and password files.
Enhanced both the password on the command line with a password-alias opton and also the ability to store an alias instead of clear text in the password file option.
Used reflection to call the APIs instead of directly accessing them so that we don't have hard dependency on Hadoop 2.6.x
Added documentation updates
Made sure no new checkstyle violations are there
Diffs (updated)
-----
src/docs/user/connecting.txt 6a28254
src/java/org/apache/sqoop/SqoopOptions.java d16ccb3
src/java/org/apache/sqoop/mapreduce/ImportJobBase.java 0ac35de
src/java/org/apache/sqoop/tool/BaseSqoopTool.java 26950cc
src/java/org/apache/sqoop/util/password/CredentialProviderHelper.java PRE-CREATION
src/java/org/apache/sqoop/util/password/CredentialProviderPasswordLoader.java PRE-CREATION
src/test/org/apache/sqoop/credentials/TestPassingSecurePassword.java bbf82f4
Diff: https://reviews.apache.org/r/25090/diff/
Testing
-------
Tested with Hadoop versions 2.4 and 1.x to make sure we fail gracefully if the facility is not available. Tested with 2.6.0 snapshot build that was built by myself and also against the SNAPSHOT builds posted to validate the functionality.
Added two new tests to test the functionality
Thanks,
Venkat Ranganathan
Re: Review Request 25090: SQOOP-1471: Use Hadoop CredentialProvider
API to encyrpt passwords at rest
Posted by Venkat Ranganathan <n....@live.com>.
> On Sept. 23, 2014, 11:24 p.m., Abraham Elmahrek wrote:
> > src/java/org/apache/sqoop/tool/BaseSqoopTool.java, lines 1039-1041
> > <https://reviews.apache.org/r/25090/diff/2/?file=702639#file702639line1039>
> >
> > Maybe add some spacing before "new"?
Fixed.
> On Sept. 23, 2014, 11:24 p.m., Abraham Elmahrek wrote:
> > src/java/org/apache/sqoop/util/password/CredentialProviderHelper.java, lines 91-98
> > <https://reviews.apache.org/r/25090/diff/2/?file=702640#file702640line91>
> >
> > No need for a condition here. You can just have:
> >
> > return !(clCredProvider == null || clsCredProviderFactory == null || methCreateCredEntry == null || methGetPassword == null || methFlush == null);
I understand from aesthetics point of view (particularly how we would rather do in dynamic languages). But we follow this in rest of the codebase, for consistency I intend to leave it as this. let me know if you feel strongly.
> On Sept. 23, 2014, 11:24 p.m., Abraham Elmahrek wrote:
> > src/java/org/apache/sqoop/util/password/CredentialProviderPasswordLoader.java, line 33
> > <https://reviews.apache.org/r/25090/diff/2/?file=702641#file702641line33>
> >
> > Instead of creating inheritance hierarchies, why not pull out verifyPath and readBytes into a utility class. Then CredentialProviderPasswordLoader can extend PasswordLoader.
CredentialProviderPasswordLoader is a File loader, where the file contains the encrypted password. So, we would depend on the file password loader functionality also. Sorry if I missed something
> On Sept. 23, 2014, 11:24 p.m., Abraham Elmahrek wrote:
> > src/java/org/apache/sqoop/util/password/CredentialProviderPasswordLoader.java, line 54
> > <https://reviews.apache.org/r/25090/diff/2/?file=702641#file702641line54>
> >
> > The exception message here will not make sense if the file doesn't exist: "The password file does not exist".
I see your point. I don't think I modified the verifypath code (that comes from FilePasswordLoader. Similar issue with the cannot be a directory. Let me update those also to meaningful. Something like. Sounds good?
The provided password file <file> does not exist
The provided password file <file> is a directory
- Venkat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25090/#review54357
-----------------------------------------------------------
On Oct. 7, 2014, 11:27 p.m., Venkat Ranganathan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25090/
> -----------------------------------------------------------
>
> (Updated Oct. 7, 2014, 11:27 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1471
> https://issues.apache.org/jira/browse/SQOOP-1471
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> Use the Hadoop Credential Provider facility to use password aliases instead of password so that password need not be embedded in clear text in scipts and password files.
>
> Enhanced both the password on the command line with a password-alias opton and also the ability to store an alias instead of clear text in the password file option.
>
> Used reflection to call the APIs instead of directly accessing them so that we don't have hard dependency on Hadoop 2.6.x
>
> Added documentation updates
>
> Made sure no new checkstyle violations are there
>
>
> Diffs
> -----
>
> src/docs/user/connecting.txt 6a28254
> src/java/org/apache/sqoop/SqoopOptions.java d16ccb3
> src/java/org/apache/sqoop/tool/BaseSqoopTool.java 498ad79
> src/java/org/apache/sqoop/util/password/CredentialProviderHelper.java PRE-CREATION
> src/java/org/apache/sqoop/util/password/CredentialProviderPasswordLoader.java PRE-CREATION
> src/java/org/apache/sqoop/util/password/FilePasswordLoader.java 4a288bf
> src/test/org/apache/sqoop/credentials/TestPassingSecurePassword.java bbf82f4
>
> Diff: https://reviews.apache.org/r/25090/diff/
>
>
> Testing
> -------
>
> Tested with Hadoop versions 2.4 and 1.x to make sure we fail gracefully if the facility is not available. Tested with 2.6.0 snapshot build that was built by myself and also against the SNAPSHOT builds posted to validate the functionality.
>
> Added two new tests to test the functionality
>
>
> Thanks,
>
> Venkat Ranganathan
>
>
Re: Review Request 25090: SQOOP-1471: Use Hadoop CredentialProvider
API to encyrpt passwords at rest
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25090/#review54357
-----------------------------------------------------------
Hey Venkat. Just a few comments and concerns!
src/java/org/apache/sqoop/tool/BaseSqoopTool.java
<https://reviews.apache.org/r/25090/#comment94486>
Maybe add some spacing before "new"?
src/java/org/apache/sqoop/util/password/CredentialProviderHelper.java
<https://reviews.apache.org/r/25090/#comment94492>
No need for a condition here. You can just have:
return !(clCredProvider == null || clsCredProviderFactory == null || methCreateCredEntry == null || methGetPassword == null || methFlush == null);
src/java/org/apache/sqoop/util/password/CredentialProviderHelper.java
<https://reviews.apache.org/r/25090/#comment94495>
RuntimeException?
src/java/org/apache/sqoop/util/password/CredentialProviderHelper.java
<https://reviews.apache.org/r/25090/#comment94494>
RuntimeException?
src/java/org/apache/sqoop/util/password/CredentialProviderHelper.java
<https://reviews.apache.org/r/25090/#comment94493>
This doesn't seem like an IOException. Why not just a RuntimeException or a custom exception that extends RuntimException?
src/java/org/apache/sqoop/util/password/CredentialProviderHelper.java
<https://reviews.apache.org/r/25090/#comment94496>
Same thoughts as above
src/java/org/apache/sqoop/util/password/CredentialProviderPasswordLoader.java
<https://reviews.apache.org/r/25090/#comment94497>
Instead of creating inheritance hierarchies, why not pull out verifyPath and readBytes into a utility class. Then CredentialProviderPasswordLoader can extend PasswordLoader.
src/java/org/apache/sqoop/util/password/CredentialProviderPasswordLoader.java
<https://reviews.apache.org/r/25090/#comment94498>
The exception message here will not make sense if the file doesn't exist: "The password file does not exist".
- Abraham Elmahrek
On Sept. 23, 2014, 7:18 a.m., Venkat Ranganathan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25090/
> -----------------------------------------------------------
>
> (Updated Sept. 23, 2014, 7:18 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1471
> https://issues.apache.org/jira/browse/SQOOP-1471
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> Use the Hadoop Credential Provider facility to use password aliases instead of password so that password need not be embedded in clear text in scipts and password files.
>
> Enhanced both the password on the command line with a password-alias opton and also the ability to store an alias instead of clear text in the password file option.
>
> Used reflection to call the APIs instead of directly accessing them so that we don't have hard dependency on Hadoop 2.6.x
>
> Added documentation updates
>
> Made sure no new checkstyle violations are there
>
>
> Diffs
> -----
>
> src/docs/user/connecting.txt 6a28254
> src/java/org/apache/sqoop/SqoopOptions.java d16ccb3
> src/java/org/apache/sqoop/mapreduce/ImportJobBase.java 0ac35de
> src/java/org/apache/sqoop/tool/BaseSqoopTool.java 26950cc
> src/java/org/apache/sqoop/util/password/CredentialProviderHelper.java PRE-CREATION
> src/java/org/apache/sqoop/util/password/CredentialProviderPasswordLoader.java PRE-CREATION
> src/test/org/apache/sqoop/credentials/TestPassingSecurePassword.java bbf82f4
>
> Diff: https://reviews.apache.org/r/25090/diff/
>
>
> Testing
> -------
>
> Tested with Hadoop versions 2.4 and 1.x to make sure we fail gracefully if the facility is not available. Tested with 2.6.0 snapshot build that was built by myself and also against the SNAPSHOT builds posted to validate the functionality.
>
> Added two new tests to test the functionality
>
>
> Thanks,
>
> Venkat Ranganathan
>
>
Re: Review Request 25090: SQOOP-1471: Use Hadoop CredentialProvider
API to encyrpt passwords at rest
Posted by Abraham Elmahrek <ab...@cloudera.com>.
> On Oct. 7, 2014, 7:10 p.m., Abraham Elmahrek wrote:
> > Ship It!
>
> Abraham Elmahrek wrote:
> Venkat, it seems there are test failures: org.apache.sqoop.credentials.TestPassingSecurePassword. Could you fix them?
>
> Venkat Ranganathan wrote:
> Thanks Abe. Sorry about the unit test failure. I ran and tested the password files only after the change and missed these two. BTW, there is a failure in org.apache.sqoop.tool.TestMainframeImportTool because of the Tools change. But that is independent of this. Thanks again for your review. Very much appreciated
Thank you Venkat! Please attach the patch to the Jira and we're good!
- Abraham
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25090/#review55684
-----------------------------------------------------------
On Oct. 7, 2014, 11:28 p.m., Venkat Ranganathan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25090/
> -----------------------------------------------------------
>
> (Updated Oct. 7, 2014, 11:28 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1471
> https://issues.apache.org/jira/browse/SQOOP-1471
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> Use the Hadoop Credential Provider facility to use password aliases instead of password so that password need not be embedded in clear text in scipts and password files.
>
> Enhanced both the password on the command line with a password-alias opton and also the ability to store an alias instead of clear text in the password file option.
>
> Used reflection to call the APIs instead of directly accessing them so that we don't have hard dependency on Hadoop 2.6.x
>
> Added documentation updates
>
> Made sure no new checkstyle violations are there
>
>
> Diffs
> -----
>
> src/docs/user/connecting.txt 6a28254
> src/java/org/apache/sqoop/SqoopOptions.java d16ccb3
> src/java/org/apache/sqoop/tool/BaseSqoopTool.java 498ad79
> src/java/org/apache/sqoop/util/password/CredentialProviderHelper.java PRE-CREATION
> src/java/org/apache/sqoop/util/password/CredentialProviderPasswordLoader.java PRE-CREATION
> src/java/org/apache/sqoop/util/password/FilePasswordLoader.java 4a288bf
> src/test/org/apache/sqoop/credentials/TestPassingSecurePassword.java bbf82f4
>
> Diff: https://reviews.apache.org/r/25090/diff/
>
>
> Testing
> -------
>
> Tested with Hadoop versions 2.4 and 1.x to make sure we fail gracefully if the facility is not available. Tested with 2.6.0 snapshot build that was built by myself and also against the SNAPSHOT builds posted to validate the functionality.
>
> Added two new tests to test the functionality
>
>
> Thanks,
>
> Venkat Ranganathan
>
>
Re: Review Request 25090: SQOOP-1471: Use Hadoop CredentialProvider
API to encyrpt passwords at rest
Posted by Venkat Ranganathan <n....@live.com>.
> On Oct. 7, 2014, 7:10 p.m., Abraham Elmahrek wrote:
> > Ship It!
>
> Abraham Elmahrek wrote:
> Venkat, it seems there are test failures: org.apache.sqoop.credentials.TestPassingSecurePassword. Could you fix them?
Thanks Abe. Sorry about the unit test failure. I ran and tested the password files only after the change and missed these two. BTW, there is a failure in org.apache.sqoop.tool.TestMainframeImportTool because of the Tools change. But that is independent of this. Thanks again for your review. Very much appreciated
- Venkat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25090/#review55684
-----------------------------------------------------------
On Oct. 7, 2014, 11:27 p.m., Venkat Ranganathan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25090/
> -----------------------------------------------------------
>
> (Updated Oct. 7, 2014, 11:27 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1471
> https://issues.apache.org/jira/browse/SQOOP-1471
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> Use the Hadoop Credential Provider facility to use password aliases instead of password so that password need not be embedded in clear text in scipts and password files.
>
> Enhanced both the password on the command line with a password-alias opton and also the ability to store an alias instead of clear text in the password file option.
>
> Used reflection to call the APIs instead of directly accessing them so that we don't have hard dependency on Hadoop 2.6.x
>
> Added documentation updates
>
> Made sure no new checkstyle violations are there
>
>
> Diffs
> -----
>
> src/docs/user/connecting.txt 6a28254
> src/java/org/apache/sqoop/SqoopOptions.java d16ccb3
> src/java/org/apache/sqoop/tool/BaseSqoopTool.java 498ad79
> src/java/org/apache/sqoop/util/password/CredentialProviderHelper.java PRE-CREATION
> src/java/org/apache/sqoop/util/password/CredentialProviderPasswordLoader.java PRE-CREATION
> src/java/org/apache/sqoop/util/password/FilePasswordLoader.java 4a288bf
> src/test/org/apache/sqoop/credentials/TestPassingSecurePassword.java bbf82f4
>
> Diff: https://reviews.apache.org/r/25090/diff/
>
>
> Testing
> -------
>
> Tested with Hadoop versions 2.4 and 1.x to make sure we fail gracefully if the facility is not available. Tested with 2.6.0 snapshot build that was built by myself and also against the SNAPSHOT builds posted to validate the functionality.
>
> Added two new tests to test the functionality
>
>
> Thanks,
>
> Venkat Ranganathan
>
>
Re: Review Request 25090: SQOOP-1471: Use Hadoop CredentialProvider
API to encyrpt passwords at rest
Posted by Abraham Elmahrek <ab...@cloudera.com>.
> On Oct. 7, 2014, 7:10 p.m., Abraham Elmahrek wrote:
> > Ship It!
Venkat, it seems there are test failures: org.apache.sqoop.credentials.TestPassingSecurePassword. Could you fix them?
- Abraham
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25090/#review55684
-----------------------------------------------------------
On Sept. 25, 2014, 11:43 p.m., Venkat Ranganathan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25090/
> -----------------------------------------------------------
>
> (Updated Sept. 25, 2014, 11:43 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1471
> https://issues.apache.org/jira/browse/SQOOP-1471
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> Use the Hadoop Credential Provider facility to use password aliases instead of password so that password need not be embedded in clear text in scipts and password files.
>
> Enhanced both the password on the command line with a password-alias opton and also the ability to store an alias instead of clear text in the password file option.
>
> Used reflection to call the APIs instead of directly accessing them so that we don't have hard dependency on Hadoop 2.6.x
>
> Added documentation updates
>
> Made sure no new checkstyle violations are there
>
>
> Diffs
> -----
>
> src/docs/user/connecting.txt 6a28254
> src/java/org/apache/sqoop/SqoopOptions.java d16ccb3
> src/java/org/apache/sqoop/tool/BaseSqoopTool.java 498ad79
> src/java/org/apache/sqoop/util/password/CredentialProviderHelper.java PRE-CREATION
> src/java/org/apache/sqoop/util/password/CredentialProviderPasswordLoader.java PRE-CREATION
> src/java/org/apache/sqoop/util/password/FilePasswordLoader.java 4a288bf
> src/test/org/apache/sqoop/credentials/TestPassingSecurePassword.java bbf82f4
>
> Diff: https://reviews.apache.org/r/25090/diff/
>
>
> Testing
> -------
>
> Tested with Hadoop versions 2.4 and 1.x to make sure we fail gracefully if the facility is not available. Tested with 2.6.0 snapshot build that was built by myself and also against the SNAPSHOT builds posted to validate the functionality.
>
> Added two new tests to test the functionality
>
>
> Thanks,
>
> Venkat Ranganathan
>
>
Re: Review Request 25090: SQOOP-1471: Use Hadoop CredentialProvider
API to encyrpt passwords at rest
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25090/#review55684
-----------------------------------------------------------
Ship it!
Ship It!
- Abraham Elmahrek
On Sept. 25, 2014, 11:43 p.m., Venkat Ranganathan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25090/
> -----------------------------------------------------------
>
> (Updated Sept. 25, 2014, 11:43 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1471
> https://issues.apache.org/jira/browse/SQOOP-1471
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> Use the Hadoop Credential Provider facility to use password aliases instead of password so that password need not be embedded in clear text in scipts and password files.
>
> Enhanced both the password on the command line with a password-alias opton and also the ability to store an alias instead of clear text in the password file option.
>
> Used reflection to call the APIs instead of directly accessing them so that we don't have hard dependency on Hadoop 2.6.x
>
> Added documentation updates
>
> Made sure no new checkstyle violations are there
>
>
> Diffs
> -----
>
> src/docs/user/connecting.txt 6a28254
> src/java/org/apache/sqoop/SqoopOptions.java d16ccb3
> src/java/org/apache/sqoop/tool/BaseSqoopTool.java 498ad79
> src/java/org/apache/sqoop/util/password/CredentialProviderHelper.java PRE-CREATION
> src/java/org/apache/sqoop/util/password/CredentialProviderPasswordLoader.java PRE-CREATION
> src/java/org/apache/sqoop/util/password/FilePasswordLoader.java 4a288bf
> src/test/org/apache/sqoop/credentials/TestPassingSecurePassword.java bbf82f4
>
> Diff: https://reviews.apache.org/r/25090/diff/
>
>
> Testing
> -------
>
> Tested with Hadoop versions 2.4 and 1.x to make sure we fail gracefully if the facility is not available. Tested with 2.6.0 snapshot build that was built by myself and also against the SNAPSHOT builds posted to validate the functionality.
>
> Added two new tests to test the functionality
>
>
> Thanks,
>
> Venkat Ranganathan
>
>
Re: Review Request 25090: SQOOP-1471: Use Hadoop CredentialProvider
API to encyrpt passwords at rest
Posted by Venkat Ranganathan <n....@live.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25090/
-----------------------------------------------------------
(Updated Oct. 7, 2014, 11:28 p.m.)
Review request for Sqoop.
Changes
-------
Ran all tests. Except for one failure in org.apache.sqoop.tool.TestMainframeImportTool all tests pass (the TestMainFrameImportTool is because of a help text change)
Bugs: SQOOP-1471
https://issues.apache.org/jira/browse/SQOOP-1471
Repository: sqoop-trunk
Description
-------
Use the Hadoop Credential Provider facility to use password aliases instead of password so that password need not be embedded in clear text in scipts and password files.
Enhanced both the password on the command line with a password-alias opton and also the ability to store an alias instead of clear text in the password file option.
Used reflection to call the APIs instead of directly accessing them so that we don't have hard dependency on Hadoop 2.6.x
Added documentation updates
Made sure no new checkstyle violations are there
Diffs
-----
src/docs/user/connecting.txt 6a28254
src/java/org/apache/sqoop/SqoopOptions.java d16ccb3
src/java/org/apache/sqoop/tool/BaseSqoopTool.java 498ad79
src/java/org/apache/sqoop/util/password/CredentialProviderHelper.java PRE-CREATION
src/java/org/apache/sqoop/util/password/CredentialProviderPasswordLoader.java PRE-CREATION
src/java/org/apache/sqoop/util/password/FilePasswordLoader.java 4a288bf
src/test/org/apache/sqoop/credentials/TestPassingSecurePassword.java bbf82f4
Diff: https://reviews.apache.org/r/25090/diff/
Testing
-------
Tested with Hadoop versions 2.4 and 1.x to make sure we fail gracefully if the facility is not available. Tested with 2.6.0 snapshot build that was built by myself and also against the SNAPSHOT builds posted to validate the functionality.
Added two new tests to test the functionality
Thanks,
Venkat Ranganathan
Re: Review Request 25090: SQOOP-1471: Use Hadoop CredentialProvider
API to encyrpt passwords at rest
Posted by Venkat Ranganathan <n....@live.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25090/
-----------------------------------------------------------
(Updated Oct. 7, 2014, 11:27 p.m.)
Review request for Sqoop.
Changes
-------
Thanks Abe for your review. Fixed unit test failure. Ran all unit tests (except for one failure in unrelated module org.apache.sqoop.tool.TestMainframeImportTool, all tests pass)
Bugs: SQOOP-1471
https://issues.apache.org/jira/browse/SQOOP-1471
Repository: sqoop-trunk
Description
-------
Use the Hadoop Credential Provider facility to use password aliases instead of password so that password need not be embedded in clear text in scipts and password files.
Enhanced both the password on the command line with a password-alias opton and also the ability to store an alias instead of clear text in the password file option.
Used reflection to call the APIs instead of directly accessing them so that we don't have hard dependency on Hadoop 2.6.x
Added documentation updates
Made sure no new checkstyle violations are there
Diffs (updated)
-----
src/docs/user/connecting.txt 6a28254
src/java/org/apache/sqoop/SqoopOptions.java d16ccb3
src/java/org/apache/sqoop/tool/BaseSqoopTool.java 498ad79
src/java/org/apache/sqoop/util/password/CredentialProviderHelper.java PRE-CREATION
src/java/org/apache/sqoop/util/password/CredentialProviderPasswordLoader.java PRE-CREATION
src/java/org/apache/sqoop/util/password/FilePasswordLoader.java 4a288bf
src/test/org/apache/sqoop/credentials/TestPassingSecurePassword.java bbf82f4
Diff: https://reviews.apache.org/r/25090/diff/
Testing
-------
Tested with Hadoop versions 2.4 and 1.x to make sure we fail gracefully if the facility is not available. Tested with 2.6.0 snapshot build that was built by myself and also against the SNAPSHOT builds posted to validate the functionality.
Added two new tests to test the functionality
Thanks,
Venkat Ranganathan
Re: Review Request 25090: SQOOP-1471: Use Hadoop CredentialProvider
API to encyrpt passwords at rest
Posted by Venkat Ranganathan <n....@live.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25090/
-----------------------------------------------------------
(Updated Sept. 25, 2014, 11:43 p.m.)
Review request for Sqoop.
Changes
-------
Thanks for your review Abe. I have incorporated most of the changes.
Bugs: SQOOP-1471
https://issues.apache.org/jira/browse/SQOOP-1471
Repository: sqoop-trunk
Description
-------
Use the Hadoop Credential Provider facility to use password aliases instead of password so that password need not be embedded in clear text in scipts and password files.
Enhanced both the password on the command line with a password-alias opton and also the ability to store an alias instead of clear text in the password file option.
Used reflection to call the APIs instead of directly accessing them so that we don't have hard dependency on Hadoop 2.6.x
Added documentation updates
Made sure no new checkstyle violations are there
Diffs (updated)
-----
src/docs/user/connecting.txt 6a28254
src/java/org/apache/sqoop/SqoopOptions.java d16ccb3
src/java/org/apache/sqoop/tool/BaseSqoopTool.java 498ad79
src/java/org/apache/sqoop/util/password/CredentialProviderHelper.java PRE-CREATION
src/java/org/apache/sqoop/util/password/CredentialProviderPasswordLoader.java PRE-CREATION
src/java/org/apache/sqoop/util/password/FilePasswordLoader.java 4a288bf
src/test/org/apache/sqoop/credentials/TestPassingSecurePassword.java bbf82f4
Diff: https://reviews.apache.org/r/25090/diff/
Testing
-------
Tested with Hadoop versions 2.4 and 1.x to make sure we fail gracefully if the facility is not available. Tested with 2.6.0 snapshot build that was built by myself and also against the SNAPSHOT builds posted to validate the functionality.
Added two new tests to test the functionality
Thanks,
Venkat Ranganathan