You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/09/07 06:07:19 UTC

[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #364: [FLINK-28272] Handle TLS Certificate Renewal in Webhook

morhidi commented on PR #364:
URL: https://github.com/apache/flink-kubernetes-operator/pull/364#issuecomment-1238946417

   > Thanks, @gaborgsomogyi this is much needed.
   > 
   > The code LGTM, I would suggest to add a note to the documentation stating that this functionality exists. 😏 I do not see a clear cut best place for it, it might make sense to add an `Admission Control` subsection to the [architecture](https://nightlies.apache.org/flink/flink-kubernetes-operator-docs-main/docs/concepts/architecture/) page with a paragraph on the webhook functionality anyway and also include that the certificate is dynamically watched. What do you think @morhidi, @gaborgsomogyi?
   
   Nice Job @gaborgsomogyi! Verified it locally, works as expected. If you prefer you can open a separate Jira and add some proper documentation for webhook.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org