You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by "florentos17 (via GitHub)" <gi...@apache.org> on 2024/10/31 15:35:13 UTC
[PR] JAMES-4083 remove logback jackson usages from james [james-project]
florentos17 opened a new pull request, #2482:
URL: https://github.com/apache/james-project/pull/2482
cf the [jira ticket](https://issues.apache.org/jira/browse/JAMES-4083)
i mounted the jar files as suggested, but i could not manage to point to them in every pom file. using ${project.basedir} in the parent pom does not work since it points to each pom's individual base directory... should i specify the path in each pom ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] JAMES-4083 remove logback jackson usages from james [james-project]
Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa commented on PR #2482:
URL: https://github.com/apache/james-project/pull/2482#issuecomment-2493877714
And update the lockat files to remove mentions of Json encoders.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] JAMES-4083 remove logback jackson usages from james [james-project]
Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa commented on PR #2482:
URL: https://github.com/apache/james-project/pull/2482#issuecomment-2498919128
This indeed is more fundamental.
Crowdsec extension as it exists relies on structured logging.
CF https://github.com/apache/james-project/blob/fa5f1c8484901fad629a13cb209c515717e7489a/third-party/crowdsec/sample-configuration/parsers/syslog-logs.yaml#L40
My proposal would be to:
- Add logback-json back as a provided dependency of `third-party/crowdsec`
- And document how to mount in runtime the `logback-json` file onto the classpath.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] JAMES-4083 remove logback jackson usages from james [james-project]
Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa commented on code in PR #2482:
URL: https://github.com/apache/james-project/pull/2482#discussion_r1858219960
##########
third-party/crowdsec/README.md:
##########
@@ -17,6 +17,12 @@ This module is for developing and delivering extensions to James for the [Crowds
guice.extension.module=org.apache.james.crowdsec.module.CrowdsecModule
```
+- Mount the configuration file onto the classpath
Review Comment:
How to do this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] JAMES-4083 remove logback jackson usages from james [james-project]
Posted by "florentos17 (via GitHub)" <gi...@apache.org>.
florentos17 commented on PR #2482:
URL: https://github.com/apache/james-project/pull/2482#issuecomment-2490616490
so the tests failing are all of those from the class `james-project/third-party/crowdsec/src/test/java/org/apache/james/crowdsec/CrowdsecIntegrationTest.java`
i run those locally and they passed without a problem...!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] JAMES-4083 remove logback jackson usages from james [james-project]
Posted by "florentos17 (via GitHub)" <gi...@apache.org>.
florentos17 commented on PR #2482:
URL: https://github.com/apache/james-project/pull/2482#issuecomment-2503291039
> Need to remove (or update) structred logging in docs/modules/servers/partials/operate/logging.adoc
>
> (we need that in twake mail too)
i could not find any doc about structured logging in twake mail ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] JAMES-4083 remove logback jackson usages from james [james-project]
Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa commented on PR #2482:
URL: https://github.com/apache/james-project/pull/2482#issuecomment-2482189121
```
[WARNING] 'dependencyManagement.dependencies.dependency.systemPath' for ch.qos.logback.contrib:logback-jackson:jar should not point at files within the project directory, ${project.basedir}/root/libs/logback-jackson-0.1.5.jar will be unresolvable by dependent projects @ line 2082, column 29
[WARNING] 'dependencyManagement.dependencies.dependency.systemPath' for ch.qos.logback.contrib:logback-json-classic:jar should not point at files within the project directory, ${project.basedir}/root/libs/logback-jackson-classic-0.1.5.jar will be unresolvable by dependent projects @ line 2089, column 29
[WARNING] 'dependencyManagement.dependencies.dependency.systemPath' for ch.qos.logback.contrib:logback-json-classic:jar refers to a non-existing file /home/jenkins/workspace/james_ApacheJames_PR-2482/root/libs/logback-jackson-classic-0.1.5.jar @ line 2089, column 29
```
@florentos17 this PR is opened for over 2 weeks and failures are clearly related.
Please take some time on it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] JAMES-4083 remove logback jackson usages from james [james-project]
Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa commented on code in PR #2482:
URL: https://github.com/apache/james-project/pull/2482#discussion_r1846660365
##########
pom.xml:
##########
@@ -2078,11 +2078,15 @@
<groupId>ch.qos.logback.contrib</groupId>
<artifactId>logback-jackson</artifactId>
<version>0.1.5</version>
+ <scope>system</scope>
+ <systemPath>${project.basedir}/root/libs/logback-jackson-0.1.5.jar</systemPath>
Review Comment:
Remove to not mean add the linagora specific lib as a magic jar depedency.
BTW binary is not reviewable source code and do not meet ASF standards.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] JAMES-4083 remove logback jackson usages from james [james-project]
Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa commented on PR #2482:
URL: https://github.com/apache/james-project/pull/2482#issuecomment-2503454265
(already done)
https://github.com/linagora/tmail-backend/pull/1333
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] JAMES-4083 remove logback jackson usages from james [james-project]
Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa commented on PR #2482:
URL: https://github.com/apache/james-project/pull/2482#issuecomment-2490901105
rebase?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] JAMES-4083 remove logback jackson usages from james [james-project]
Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa merged PR #2482:
URL: https://github.com/apache/james-project/pull/2482
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] JAMES-4083 remove logback jackson usages from james [james-project]
Posted by "Arsnael (via GitHub)" <gi...@apache.org>.
Arsnael commented on PR #2482:
URL: https://github.com/apache/james-project/pull/2482#issuecomment-2502616950
@florentos17 can you hel squash the fixups here please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org