You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@metron.apache.org by GitBox <gi...@apache.org> on 2019/07/23 13:49:21 UTC

[GitHub] [metron] nickwallen commented on a change in pull request #1458: METRON-2177 Upgrade Profiler for HBase 2.0.2

nickwallen commented on a change in pull request #1458: METRON-2177 Upgrade Profiler for HBase 2.0.2
URL: https://github.com/apache/metron/pull/1458#discussion_r306310081
 
 

 ##########
 File path: metron-analytics/metron-profiler-client/src/main/java/org/apache/metron/profiler/client/HBaseProfilerClient.java
 ##########
 @@ -44,27 +44,30 @@
   /**
    * Used to access the profile data stored in HBase.
    */
-  private HTableInterface table;
+  private HBaseClient hbaseClient;
 
 Review comment:
   The `HBaseProfilerClient` was updated to use our `HBaseClient` abstraction to interact with HBase.  This also allows us to use the `FakeHBaseClient` when testing this class.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services