You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmitro Lisnichenko <dl...@hortonworks.com> on 2015/02/24 20:21:44 UTC
Review Request 31371: Blank current stack version on the host added
via addHostWizard
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31371/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Nate Cole, and Tom Beerbower.
Bugs: AMBARI-9777
https://issues.apache.org/jira/browse/AMBARI-9777
Repository: ambari
Description
-------
If cluster has both CURRENT and OUT_OF_SYNC host version, and we add a new host, only OUT_OF_SYNC host version is created (creating CURRENT host version is skipped)
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/StackVersionResponse.java 005b8a1
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackVersionResourceProvider.java ca66819
ambari-server/src/main/java/org/apache/ambari/server/stack/ComponentModule.java c86073f
ambari-server/src/main/java/org/apache/ambari/server/stack/ConfigurationDirectory.java 7f21aaa
ambari-server/src/main/java/org/apache/ambari/server/stack/ConfigurationInfo.java d00b135
ambari-server/src/main/java/org/apache/ambari/server/stack/ConfigurationModule.java 90e7ed3
ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceDirectory.java 9b32a97
ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java 8b94101
ambari-server/src/main/java/org/apache/ambari/server/stack/StackDefinitionModule.java b35afb2
ambari-server/src/main/java/org/apache/ambari/server/stack/StackDirectory.java d38cee9
ambari-server/src/main/java/org/apache/ambari/server/stack/StackManager.java 33f1447
ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java 4181293
ambari-server/src/main/java/org/apache/ambari/server/stack/Validable.java e8b5f24
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java b1ee121
ambari-server/src/main/java/org/apache/ambari/server/state/StackInfo.java 4b6898a
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java b2ba43b
ambari-server/src/main/java/org/apache/ambari/server/state/stack/ConfigurationXml.java ca33601
ambari-server/src/main/java/org/apache/ambari/server/state/stack/RepositoryXml.java eff063b
ambari-server/src/main/java/org/apache/ambari/server/state/stack/ServiceMetainfoXml.java 56dac8a
ambari-server/src/main/java/org/apache/ambari/server/state/stack/StackMetainfoXml.java 55b1b9b
ambari-server/src/main/resources/properties.json cdb2bd6
ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 0d944ab
ambari-views/examples/weather-view/pom.xml 6845620
Diff: https://reviews.apache.org/r/31371/diff/
Testing
-------
manual tests
Unit test coverage is pending
Thanks,
Dmitro Lisnichenko
Re: Review Request 31371: Blank current stack version on the host
added via addHostWizard
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31371/#review73873
-----------------------------------------------------------
Sorry, wrong patch
- Dmitro Lisnichenko
On Feb. 24, 2015, 7:25 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31371/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2015, 7:25 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Nate Cole, and Tom Beerbower.
>
>
> Bugs: AMBARI-9777
> https://issues.apache.org/jira/browse/AMBARI-9777
>
>
> Repository: ambari
>
>
> Description
> -------
>
> If cluster has both CURRENT and OUT_OF_SYNC host version, and we add a new host, only OUT_OF_SYNC host version is created (creating CURRENT host version is skipped)
>
> Also patch fixes mvn warning
>
> [WARNING] While downloading org.apache.commons:commons-io:1.3.2
> This artifact has been relocated to commons-io:commons-io:1.3.2.
> https://issues.sonatype.org/browse/MVNCENTRAL-244
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackVersionResponse.java 005b8a1
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackVersionResourceProvider.java ca66819
> ambari-server/src/main/java/org/apache/ambari/server/stack/ComponentModule.java c86073f
> ambari-server/src/main/java/org/apache/ambari/server/stack/ConfigurationDirectory.java 7f21aaa
> ambari-server/src/main/java/org/apache/ambari/server/stack/ConfigurationInfo.java d00b135
> ambari-server/src/main/java/org/apache/ambari/server/stack/ConfigurationModule.java 90e7ed3
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceDirectory.java 9b32a97
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java 8b94101
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackDefinitionModule.java b35afb2
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackDirectory.java d38cee9
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackManager.java 33f1447
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java 4181293
> ambari-server/src/main/java/org/apache/ambari/server/stack/Validable.java e8b5f24
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java b1ee121
> ambari-server/src/main/java/org/apache/ambari/server/state/StackInfo.java 4b6898a
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java b2ba43b
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/ConfigurationXml.java ca33601
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/RepositoryXml.java eff063b
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/ServiceMetainfoXml.java 56dac8a
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/StackMetainfoXml.java 55b1b9b
> ambari-server/src/main/resources/properties.json cdb2bd6
> ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 0d944ab
> ambari-views/examples/weather-view/pom.xml 6845620
>
> Diff: https://reviews.apache.org/r/31371/diff/
>
>
> Testing
> -------
>
> manual tests
> Unit test coverage is pending
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 31371: Blank current stack version on the host
added via addHostWizard
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31371/#review73921
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On Feb. 24, 2015, 9:32 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31371/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2015, 9:32 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Nate Cole, and Tom Beerbower.
>
>
> Bugs: AMBARI-9777
> https://issues.apache.org/jira/browse/AMBARI-9777
>
>
> Repository: ambari
>
>
> Description
> -------
>
> If cluster has both CURRENT and OUT_OF_SYNC host version, and we add a new host, only OUT_OF_SYNC host version is created (creating CURRENT host version is skipped)
>
> Also patch fixes mvn warning
>
> [WARNING] While downloading org.apache.commons:commons-io:1.3.2
> This artifact has been relocated to commons-io:commons-io:1.3.2.
> https://issues.sonatype.org/browse/MVNCENTRAL-244
>
>
> Diffs
> -----
>
> ambari-server/pom.xml c60dd0d
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java b2ba43b
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java 7d5f734
> ambari-views/examples/weather-view/pom.xml 6845620
>
> Diff: https://reviews.apache.org/r/31371/diff/
>
>
> Testing
> -------
>
> manual tests
> Unit test coverage is pending
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 31371: Blank current stack version on the host
added via addHostWizard
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31371/
-----------------------------------------------------------
(Updated Feb. 25, 2015, 8:03 p.m.)
Review request for Ambari, Alejandro Fernandez, Nate Cole, and Tom Beerbower.
Changes
-------
Minor fixes & added unit test coverage
Bugs: AMBARI-9777
https://issues.apache.org/jira/browse/AMBARI-9777
Repository: ambari
Description
-------
If cluster has both CURRENT and OUT_OF_SYNC host version, and we add a new host, only OUT_OF_SYNC host version is created (creating CURRENT host version is skipped)
Also patch fixes mvn warning
[WARNING] While downloading org.apache.commons:commons-io:1.3.2
This artifact has been relocated to commons-io:commons-io:1.3.2.
https://issues.sonatype.org/browse/MVNCENTRAL-244
Diffs (updated)
-----
ambari-server/pom.xml e9d9fac
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java b2ba43b
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java 7d5f734
ambari-views/examples/weather-view/pom.xml 6845620
Diff: https://reviews.apache.org/r/31371/diff/
Testing (updated)
-------
Unrelated unit test failure
Tests in error:
org.apache.ambari.server.security.authorization.AmbariLdapAuthenticationProviderForDNWithSpaceTest: /tmp/server-work-Test/log/revision (No such file or directory)
Tests run: 2742, Failures: 0, Errors: 1, Skipped: 15
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ....................................... SUCCESS [5.171s]
[INFO] Apache Ambari Project POM ......................... SUCCESS [0.063s]
[INFO] Ambari Web ........................................ SUCCESS [46.602s]
[INFO] Ambari Views ...................................... SUCCESS [3.266s]
[INFO] Ambari Admin View ................................. SUCCESS [11.840s]
[INFO] Ambari Server ..................................... FAILURE [38:34.887s]
[INFO] Ambari Agent ...................................... SKIPPED
[INFO] Ambari Client ..................................... SKIPPED
[INFO] Ambari Python Client .............................. SKIPPED
[INFO] Ambari Groovy Client .............................. SKIPPED
[INFO] Ambari Shell ...................................... SKIPPED
[INFO] Ambari Python Shell ............................... SKIPPED
[INFO] Ambari Groovy Shell ............................... SKIPPED
[INFO] ------------------------------------------------------------------------
Thanks,
Dmitro Lisnichenko
Re: Review Request 31371: Blank current stack version on the host
added via addHostWizard
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31371/
-----------------------------------------------------------
(Updated Feb. 24, 2015, 9:32 p.m.)
Review request for Ambari, Alejandro Fernandez, Nate Cole, and Tom Beerbower.
Changes
-------
removed duplicate commons-io
Bugs: AMBARI-9777
https://issues.apache.org/jira/browse/AMBARI-9777
Repository: ambari
Description
-------
If cluster has both CURRENT and OUT_OF_SYNC host version, and we add a new host, only OUT_OF_SYNC host version is created (creating CURRENT host version is skipped)
Also patch fixes mvn warning
[WARNING] While downloading org.apache.commons:commons-io:1.3.2
This artifact has been relocated to commons-io:commons-io:1.3.2.
https://issues.sonatype.org/browse/MVNCENTRAL-244
Diffs (updated)
-----
ambari-server/pom.xml c60dd0d
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java b2ba43b
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java 7d5f734
ambari-views/examples/weather-view/pom.xml 6845620
Diff: https://reviews.apache.org/r/31371/diff/
Testing
-------
manual tests
Unit test coverage is pending
Thanks,
Dmitro Lisnichenko
Re: Review Request 31371: Blank current stack version on the host
added via addHostWizard
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31371/
-----------------------------------------------------------
(Updated Feb. 24, 2015, 9:25 p.m.)
Review request for Ambari, Alejandro Fernandez, Nate Cole, and Tom Beerbower.
Changes
-------
one more commons-io warning fix
Bugs: AMBARI-9777
https://issues.apache.org/jira/browse/AMBARI-9777
Repository: ambari
Description
-------
If cluster has both CURRENT and OUT_OF_SYNC host version, and we add a new host, only OUT_OF_SYNC host version is created (creating CURRENT host version is skipped)
Also patch fixes mvn warning
[WARNING] While downloading org.apache.commons:commons-io:1.3.2
This artifact has been relocated to commons-io:commons-io:1.3.2.
https://issues.sonatype.org/browse/MVNCENTRAL-244
Diffs (updated)
-----
ambari-server/pom.xml c60dd0d
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java b2ba43b
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java 7d5f734
ambari-views/examples/weather-view/pom.xml 6845620
Diff: https://reviews.apache.org/r/31371/diff/
Testing
-------
manual tests
Unit test coverage is pending
Thanks,
Dmitro Lisnichenko
Re: Review Request 31371: Blank current stack version on the host
added via addHostWizard
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31371/
-----------------------------------------------------------
(Updated Feb. 24, 2015, 9:16 p.m.)
Review request for Ambari, Alejandro Fernandez, Nate Cole, and Tom Beerbower.
Changes
-------
Simplified patch as Alejandro suggested.
Manual check passed, E2E test on live cluster and unit test coverage is still pending
Bugs: AMBARI-9777
https://issues.apache.org/jira/browse/AMBARI-9777
Repository: ambari
Description
-------
If cluster has both CURRENT and OUT_OF_SYNC host version, and we add a new host, only OUT_OF_SYNC host version is created (creating CURRENT host version is skipped)
Also patch fixes mvn warning
[WARNING] While downloading org.apache.commons:commons-io:1.3.2
This artifact has been relocated to commons-io:commons-io:1.3.2.
https://issues.sonatype.org/browse/MVNCENTRAL-244
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java b2ba43b
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java 7d5f734
ambari-views/examples/weather-view/pom.xml 6845620
Diff: https://reviews.apache.org/r/31371/diff/
Testing
-------
manual tests
Unit test coverage is pending
Thanks,
Dmitro Lisnichenko
Re: Review Request 31371: Blank current stack version on the host
added via addHostWizard
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31371/
-----------------------------------------------------------
(Updated Feb. 24, 2015, 7:27 p.m.)
Review request for Ambari, Alejandro Fernandez, Nate Cole, and Tom Beerbower.
Bugs: AMBARI-9777
https://issues.apache.org/jira/browse/AMBARI-9777
Repository: ambari
Description
-------
If cluster has both CURRENT and OUT_OF_SYNC host version, and we add a new host, only OUT_OF_SYNC host version is created (creating CURRENT host version is skipped)
Also patch fixes mvn warning
[WARNING] While downloading org.apache.commons:commons-io:1.3.2
This artifact has been relocated to commons-io:commons-io:1.3.2.
https://issues.sonatype.org/browse/MVNCENTRAL-244
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java b2ba43b
ambari-views/examples/weather-view/pom.xml 6845620
Diff: https://reviews.apache.org/r/31371/diff/
Testing
-------
manual tests
Unit test coverage is pending
Thanks,
Dmitro Lisnichenko
Re: Review Request 31371: Blank current stack version on the host
added via addHostWizard
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31371/
-----------------------------------------------------------
(Updated Feb. 24, 2015, 7:25 p.m.)
Review request for Ambari, Alejandro Fernandez, Nate Cole, and Tom Beerbower.
Bugs: AMBARI-9777
https://issues.apache.org/jira/browse/AMBARI-9777
Repository: ambari
Description (updated)
-------
If cluster has both CURRENT and OUT_OF_SYNC host version, and we add a new host, only OUT_OF_SYNC host version is created (creating CURRENT host version is skipped)
Also patch fixes mvn warning
[WARNING] While downloading org.apache.commons:commons-io:1.3.2
This artifact has been relocated to commons-io:commons-io:1.3.2.
https://issues.sonatype.org/browse/MVNCENTRAL-244
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/StackVersionResponse.java 005b8a1
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackVersionResourceProvider.java ca66819
ambari-server/src/main/java/org/apache/ambari/server/stack/ComponentModule.java c86073f
ambari-server/src/main/java/org/apache/ambari/server/stack/ConfigurationDirectory.java 7f21aaa
ambari-server/src/main/java/org/apache/ambari/server/stack/ConfigurationInfo.java d00b135
ambari-server/src/main/java/org/apache/ambari/server/stack/ConfigurationModule.java 90e7ed3
ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceDirectory.java 9b32a97
ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java 8b94101
ambari-server/src/main/java/org/apache/ambari/server/stack/StackDefinitionModule.java b35afb2
ambari-server/src/main/java/org/apache/ambari/server/stack/StackDirectory.java d38cee9
ambari-server/src/main/java/org/apache/ambari/server/stack/StackManager.java 33f1447
ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java 4181293
ambari-server/src/main/java/org/apache/ambari/server/stack/Validable.java e8b5f24
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java b1ee121
ambari-server/src/main/java/org/apache/ambari/server/state/StackInfo.java 4b6898a
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java b2ba43b
ambari-server/src/main/java/org/apache/ambari/server/state/stack/ConfigurationXml.java ca33601
ambari-server/src/main/java/org/apache/ambari/server/state/stack/RepositoryXml.java eff063b
ambari-server/src/main/java/org/apache/ambari/server/state/stack/ServiceMetainfoXml.java 56dac8a
ambari-server/src/main/java/org/apache/ambari/server/state/stack/StackMetainfoXml.java 55b1b9b
ambari-server/src/main/resources/properties.json cdb2bd6
ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 0d944ab
ambari-views/examples/weather-view/pom.xml 6845620
Diff: https://reviews.apache.org/r/31371/diff/
Testing
-------
manual tests
Unit test coverage is pending
Thanks,
Dmitro Lisnichenko