[GitHub] [activemq-artemis] michaelpearce-gain commented on a change in pull request #2689: NO-JIRA Test Improvements

[GitBox <gi...@apache.org>]

michaelpearce-gain commented on a change in pull request #2689: NO-JIRA Test Improvements
URL: https://github.com/apache/activemq-artemis/pull/2689#discussion_r289272997
 
 

 ##########
 File path: artemis-server/src/test/java/org/apache/activemq/artemis/tests/util/ActiveMQTestBase.java
 ##########
 @@ -174,6 +175,9 @@
    @Rule
    public CleanupSystemPropertiesRule propertiesRule = new CleanupSystemPropertiesRule();
 
+   @Rule
+   public PortCheckRule portCheckRule = new PortCheckRule(61616, 61617, 61618);
 
 Review comment:
   Do we need tests actually bound to sepecific ports, failing if not free? would it not be better to simply find some free ports and use those? Ive seen this in other projects, its quite an elegant way of ensuring you dont get port clash issues that fail builds un-neededly. (and allows concurrent builds in a shared env)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services