[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #10565: c++ compatibility: rename reserved C++ identifiers 'public' and 'this'

["xiaoxiang781216 (via GitHub)" <gi...@apache.org>]

xiaoxiang781216 commented on code in PR #10565:
URL: https://github.com/apache/nuttx/pull/10565#discussion_r1323311650


##########
libs/libc/stream/lib_stdsostream.c:
##########
@@ -104,26 +106,28 @@ static int stdsostream_puts(FAR struct lib_sostream_s *this,
  ****************************************************************************/
 
 #ifndef CONFIG_STDIO_DISABLE_BUFFERING
-static int stdsostream_flush(FAR struct lib_sostream_s *this)
+static int stdsostream_flush(FAR struct lib_sostream_s *self)
 {
-  FAR struct lib_stdsostream_s *sthis = (FAR struct lib_stdsostream_s *)this;
+  FAR struct lib_stdsostream_s *ostream =
+                                        (FAR struct lib_stdsostream_s *)self;
 
-  DEBUGASSERT(sthis != NULL && sthis->stream != NULL);
-  return lib_fflush(sthis->stream, true);
+  DEBUGASSERT(ostream != NULL && ostream->stream != NULL);
+  return lib_fflush(ostream->stream, true);
 }
 #endif
 
 /****************************************************************************
  * Name: stdsostream_seek
  ****************************************************************************/
 
-static off_t stdsostream_seek(FAR struct lib_sostream_s *this, off_t offset,
+static off_t stdsostream_seek(FAR struct lib_sostream_s *self, off_t offset,
                               int whence)
 {
-  FAR struct lib_stdsostream_s *sthis = (FAR struct lib_stdsostream_s *)this;
+  FAR struct lib_stdsostream_s *ostream =

Review Comment:
   let's unify all ostream/istream/stdoutstream/stdistream to stream?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org