You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by GitBox <gi...@apache.org> on 2020/11/25 20:47:14 UTC

[GitHub] [james-project] mbaechler opened a new pull request #265: Add jenkins file

mbaechler opened a new pull request #265:
URL: https://github.com/apache/james-project/pull/265


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


[GitHub] [james-project] mbaechler closed pull request #265: Add jenkins file

Posted by GitBox <gi...@apache.org>.
mbaechler closed pull request #265:
URL: https://github.com/apache/james-project/pull/265


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


[GitHub] [james-project] jeantil edited a comment on pull request #265: Add jenkins file

Posted by GitBox <gi...@apache.org>.
jeantil edited a comment on pull request #265:
URL: https://github.com/apache/james-project/pull/265#issuecomment-734394418


   I wonder if this is another flaky test, at least the run went a bit further this time 
   build>5 stopped at  Apache James :: Mailbox :: Cassandra ............... FAILURE [09:02 min]
   build>6 stopped at  Apache James :: Mailbox :: Event :: RabbitMQ implementation FAILURE [03:28 min]
   ```
   [INFO] Apache James :: Mailbox :: Cassandra ............... SUCCESS [08:09 min]
   [INFO] Apache James :: Mailbox :: Tika .................... SUCCESS [ 23.728 s]
   [INFO] Apache James :: Mailbox :: ElasticSearch ........... SUCCESS [03:50 min]
   [INFO] Apache James :: Mailbox :: Event :: JSON ........... SUCCESS [  7.754 s]
   [INFO] Apache James :: Mailbox :: Event :: In Cassandra implementation SUCCESS [ 59.285 s]
   [INFO] Apache James :: Mailbox :: Event :: RabbitMQ implementation FAILURE [03:28 min
   ```
   so there is progress !
   
   test failure can be viewed at https://builds.apache.org/blue/organizations/jenkins/james%2FApacheJames/detail/PR-265/6/tests
   
   Now to test the issueCommentTrigger :
   
   test this please
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


[GitHub] [james-project] jeantil commented on pull request #265: Add jenkins file

Posted by GitBox <gi...@apache.org>.
jeantil commented on pull request #265:
URL: https://github.com/apache/james-project/pull/265#issuecomment-734422096


   ```
   issueCommentTrigger
   > Currently this trigger will only allow collaborators of the repository in question to trigger builds.
   ```
   I wonder who is a collaborator of the repository then since the trigger didn't work for either of us.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


[GitHub] [james-project] jeantil commented on pull request #265: Add jenkins file

Posted by GitBox <gi...@apache.org>.
jeantil commented on pull request #265:
URL: https://github.com/apache/james-project/pull/265#issuecomment-734394418


   I wonder if this is another flaky test, at least the run went a bit further this time 
   build>5 stopped at  Apache James :: Mailbox :: Cassandra ............... FAILURE [09:02 min]
   build>6 stopped at  Apache James :: Mailbox :: Event :: RabbitMQ implementation FAILURE [03:28 min]
   ```
   [INFO] Apache James :: Mailbox :: Cassandra ............... SUCCESS [08:09 min]
   [INFO] Apache James :: Mailbox :: Tika .................... SUCCESS [ 23.728 s]
   [INFO] Apache James :: Mailbox :: ElasticSearch ........... SUCCESS [03:50 min]
   [INFO] Apache James :: Mailbox :: Event :: JSON ........... SUCCESS [  7.754 s]
   [INFO] Apache James :: Mailbox :: Event :: In Cassandra implementation SUCCESS [ 59.285 s]
   [INFO] Apache James :: Mailbox :: Event :: RabbitMQ implementation FAILURE [03:28 min
   ```
   so there is progress !
   
   Now to test the issueCommentTrigger :
   
   test this please
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


[GitHub] [james-project] mbaechler commented on pull request #265: Add jenkins file

Posted by GitBox <gi...@apache.org>.
mbaechler commented on pull request #265:
URL: https://github.com/apache/james-project/pull/265#issuecomment-736307826


   replaced by https://github.com/apache/james-project/pull/268


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


[GitHub] [james-project] mbaechler commented on a change in pull request #265: Add jenkins file

Posted by GitBox <gi...@apache.org>.
mbaechler commented on a change in pull request #265:
URL: https://github.com/apache/james-project/pull/265#discussion_r530864624



##########
File path: Jenkinsfile
##########
@@ -79,15 +80,15 @@ pipeline {
         stage('Build') {
             steps {
                 echo 'Building'
-                sh 'mvn -U -B -e clean install -DskipTests'
+                sh 'mvn -U -B -e clean install -DskipTests -T1C'
             }
         }
 
         stage('Tests') {
             steps {
                 echo 'Running tests'
                 // all tests is very very long (10 hours on Apache Jenkins)
-                sh 'mvn -B -e test'
+                sh 'mvn -B -e test -T1C'

Review comment:
       Agree. As isolation is poor we may try to leverage Jenkins plugins to split tests between different runners to keep good isolation level.
   Let's first look at the result of this try (:




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


[GitHub] [james-project] chibenwa commented on a change in pull request #265: Add jenkins file

Posted by GitBox <gi...@apache.org>.
chibenwa commented on a change in pull request #265:
URL: https://github.com/apache/james-project/pull/265#discussion_r530863424



##########
File path: Jenkinsfile
##########
@@ -79,15 +80,15 @@ pipeline {
         stage('Build') {
             steps {
                 echo 'Building'
-                sh 'mvn -U -B -e clean install -DskipTests'
+                sh 'mvn -U -B -e clean install -DskipTests -T1C'
             }
         }
 
         stage('Tests') {
             steps {
                 echo 'Running tests'
                 // all tests is very very long (10 hours on Apache Jenkins)
-                sh 'mvn -B -e test'
+                sh 'mvn -B -e test -T1C'

Review comment:
       That's probably ambitious for test phase.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


[GitHub] [james-project] mbaechler commented on pull request #265: Add jenkins file

Posted by GitBox <gi...@apache.org>.
mbaechler commented on pull request #265:
URL: https://github.com/apache/james-project/pull/265#issuecomment-734419010


   test this please


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


[GitHub] [james-project] chibenwa commented on pull request #265: Add jenkins file

Posted by GitBox <gi...@apache.org>.
chibenwa commented on pull request #265:
URL: https://github.com/apache/james-project/pull/265#issuecomment-734192191


   Fingers crossed !


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


[GitHub] [james-project] chibenwa commented on a change in pull request #265: Add jenkins file

Posted by GitBox <gi...@apache.org>.
chibenwa commented on a change in pull request #265:
URL: https://github.com/apache/james-project/pull/265#discussion_r530885135



##########
File path: Jenkinsfile
##########
@@ -79,15 +80,15 @@ pipeline {
         stage('Build') {
             steps {
                 echo 'Building'
-                sh 'mvn -U -B -e clean install -DskipTests'
+                sh 'mvn -U -B -e clean install -DskipTests -T1C'
             }
         }
 
         stage('Tests') {
             steps {
                 echo 'Running tests'
                 // all tests is very very long (10 hours on Apache Jenkins)
-                sh 'mvn -B -e test'
+                sh 'mvn -B -e test -T1C'

Review comment:
       Also we might blow up the test runner as parallel runs are achieved at the maven module level.
   
   Of course, I'd be happy to not rely on surefire forks and rely on maven concurrency instead.
   
   Thanks for your work on that with @jeantil BTW.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org