[GitHub] [tvm] junrushao1994 commented on a diff in pull request #12101: [TVMScript] Add object path tracing to StructuralEqual

[GitBox <gi...@apache.org>]

junrushao1994 commented on code in PR #12101:
URL: https://github.com/apache/tvm/pull/12101#discussion_r922706231


##########
include/tvm/node/reflection.h:
##########
@@ -404,5 +404,11 @@ inline bool ReflectionVTable::GetReprBytes(const Object* self, std::string* repr
   }
 }
 
+/*!
+ * \brief Given an object and an address of its attribute, return the key of the attribute.
+ * \return nullptr if no attribute with the given address exists.
+ */
+const char* GetAttrKeyByAddress(const Object* object, const void* attr_address);

Review Comment:
   nit: it's adding a bit of overhead, but let's use `std::string` or `tvm::runtime::String` when possible
   
   ```suggestion
   String GetAttrKeyByAddress(const Object* object, const void* attr_address);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org