You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "jpeach (via GitHub)" <gi...@apache.org> on 2023/06/29 09:51:44 UTC
[GitHub] [trafficserver] jpeach opened a new pull request, #9931: Use string copy for the SNI server name.
jpeach opened a new pull request, #9931:
URL: https://github.com/apache/trafficserver/pull/9931
Since the server name is a string, we don't need to manually copy, we can just copy it into a std::string.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] cmcfarlen commented on pull request #9931: Use string copy for the SNI server name.
Posted by "cmcfarlen (via GitHub)" <gi...@apache.org>.
cmcfarlen commented on PR #9931:
URL: https://github.com/apache/trafficserver/pull/9931#issuecomment-1613513112
> I thought it is a workaround to ensure the string is available when ATS makes a log entry.
> @ywkaras thoughts?
The lifetime should be the same, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] maskit commented on pull request #9931: Use string copy for the SNI server name.
Posted by "maskit (via GitHub)" <gi...@apache.org>.
maskit commented on PR #9931:
URL: https://github.com/apache/trafficserver/pull/9931#issuecomment-1613872205
I found the related discussion about this variable. Seems like there **was** a lifetime issue and the type **was** shared_ptr on the first proposal. Maybe we don't have a reason not to use std:string now.
https://github.com/apache/trafficserver/pull/6108#pullrequestreview-310186898
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] jpeach merged pull request #9931: Use string copy for the SNI server name.
Posted by "jpeach (via GitHub)" <gi...@apache.org>.
jpeach merged PR #9931:
URL: https://github.com/apache/trafficserver/pull/9931
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] maskit commented on pull request #9931: Use string copy for the SNI server name.
Posted by "maskit (via GitHub)" <gi...@apache.org>.
maskit commented on PR #9931:
URL: https://github.com/apache/trafficserver/pull/9931#issuecomment-1613522640
Ah, I read `unique_ptr` as `shared_ptr`... Now I don't get what it is for.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] maskit commented on pull request #9931: Use string copy for the SNI server name.
Posted by "maskit (via GitHub)" <gi...@apache.org>.
maskit commented on PR #9931:
URL: https://github.com/apache/trafficserver/pull/9931#issuecomment-1613429622
I thought it is a workaround to ensure the string is available when ATS makes a log entry.
@ywkaras thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt commented on pull request #9931: Use string copy for the SNI server name.
Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt commented on PR #9931:
URL: https://github.com/apache/trafficserver/pull/9931#issuecomment-1613149421
[approve ci]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org