[jira] [Comment Edited] (SUREFIRE-1844) Trademarks / privacy policy footer displays broken

["Tibor Digana (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SUREFIRE-1844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17234421#comment-17234421 ] 

Tibor Digana edited comment on SUREFIRE-1844 at 11/18/20, 9:57 AM:
-------------------------------------------------------------------

[~michaelboyles] yes it will be included in the next release for sure.
Currently i am finishing the tests for SUREFIRE-1847. This would enable us to complete the road map with XML reporter which is possible only through SUREFIRE-1847. After SUREFIRE-1847 we would need to add an ID:long (in {{SimpleReportEntry}} class) which would identify the particular run. It would be similar to JUnit5's UniqueID but the problem is that this is String and this string would slow down the performance. Therefore there must be ID:long. All would simplify the code in {{StatelessXmlReporter.java}} and the same fix would enable JUnit5's Dynamic tests and Cucumber scripts (they are not classes which is currently our problem).

If somebody has a spare time, you can guys open parallel PR on GitHub since it is independent of SUREFIRE-1847, and include the mandatory parameter {{ID:long}} to the {{SimpleReportEntry}} class. There should be added somemap between JUnit4's {{Description}} object and {{long}}, some kind of with TestNG and JUnit5 provider.


was (Author: tibor17):
[~michaelboyles] yes it will be included in the next release for sure.
Currently i am finishing the tests for SUREFIRE-1847. This would enable us to complete the road map with XML reporter because there we would need to have an ID:long which would identify the particular run. It would be similar to JUnit5's UniqueID but the problem is that this is String and this string would slow down the performance. Therefore there must be ID:long. All would simplify the code in {{StatelessXmlReporter.java}} and the same fix would enable JUnit5's Dynamic tests and Cucumber scripts (they are not classes which is currently our problem).

> Trademarks / privacy policy footer displays broken
> --------------------------------------------------
>
>                 Key: SUREFIRE-1844
>                 URL: https://issues.apache.org/jira/browse/SUREFIRE-1844
>             Project: Maven Surefire
>          Issue Type: Bug
>          Components: documentation
>            Reporter: Philippe Cloutier
>            Assignee: Enrico Olivelli
>            Priority: Trivial
>             Fix For: 3.0.0-M6
>
>         Attachments: image-2020-09-22-17-29-40-357.png
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> The footer which is at the end of Surefire's documentation pages, such as [this one|https://maven.apache.org/surefire/maven-surefire-plugin/index.html], have a broken display (at least in Firefox 81 and Google Chrome 85). The horizontal alignment is incorrect, causing the sentence to start outside the visible area and its end to overlap with the "Privacy policy" link, as can be seen in the screenshot below:
>  !image-2020-09-22-17-29-40-357.png|thumbnail! 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)