You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Vikas Mayur (JIRA)" <ji...@apache.org> on 2007/12/01 14:47:43 UTC
[jira] Created: (OFBIZ-1468) JUNIT test case for party
communication
JUNIT test case for party communication
----------------------------------------
Key: OFBIZ-1468
URL: https://issues.apache.org/jira/browse/OFBIZ-1468
Project: OFBiz
Issue Type: Sub-task
Reporter: Vikas Mayur
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1468) JUNIT test case for party
communication
Posted by "Marco Risaliti (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12557011#action_12557011 ]
Marco Risaliti commented on OFBIZ-1468:
---------------------------------------
Hi santosh,
I have tested your last patch but I have seen that the service updateWorkEffort does not know the in parameter quickAssignPartyId that can be used only for the service createWorkEffort.
Please upload a new working patch and then I will test it again.
Thanks
Marco
P.S.: Thanks Jacques for your suggestion, I have not seen it.
> JUNIT test case for party communication
> ----------------------------------------
>
> Key: OFBIZ-1468
> URL: https://issues.apache.org/jira/browse/OFBIZ-1468
> Project: OFBiz
> Issue Type: Sub-task
> Components: workeffort
> Affects Versions: SVN trunk
> Reporter: Vikas Mayur
> Assignee: Marco Risaliti
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: party_communication.patch, PartyCommunication.patch, PartyCommunication.patch, PartyCommunication.patch
>
>
> Followed the process from link http://docs.ofbiz.org/display/OFBENDUSER/Party+%28Customer%29+Communication
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1468) JUNIT test case for party
communication
Posted by "Marco Risaliti (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marco Risaliti updated OFBIZ-1468:
----------------------------------
Component/s: workeffort
Fix Version/s: SVN trunk
Assignee: Marco Risaliti
Priority: Minor (was: Major)
Affects Version/s: SVN trunk
May I can test and then commit ?
> JUNIT test case for party communication
> ----------------------------------------
>
> Key: OFBIZ-1468
> URL: https://issues.apache.org/jira/browse/OFBIZ-1468
> Project: OFBiz
> Issue Type: Sub-task
> Components: workeffort
> Affects Versions: SVN trunk
> Reporter: Vikas Mayur
> Assignee: Marco Risaliti
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: party_communication.patch
>
>
> Followed the process from link http://docs.ofbiz.org/display/OFBENDUSER/Party+%28Customer%29+Communication
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1468) JUNIT test case for party
communication
Posted by "Vikas Mayur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vikas Mayur updated OFBIZ-1468:
-------------------------------
Description: Followed the process from link http://docs.ofbiz.org/display/OFBENDUSER/Party+%28Customer%29+Communication
> JUNIT test case for party communication
> ----------------------------------------
>
> Key: OFBIZ-1468
> URL: https://issues.apache.org/jira/browse/OFBIZ-1468
> Project: OFBiz
> Issue Type: Sub-task
> Reporter: Vikas Mayur
> Attachments: party_communication.patch
>
>
> Followed the process from link http://docs.ofbiz.org/display/OFBENDUSER/Party+%28Customer%29+Communication
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1468) JUNIT test case for party
communication
Posted by "David E. Jones (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12551644 ]
David E. Jones commented on OFBIZ-1468:
---------------------------------------
Because we're setting a precedent here I'd rather not be too hasty about it. In other words yes, my recommendation is that this not be committed until it is re-written as a simple-method.
Chances are Santosh could do this, and I know Vikas can help as needed, though of course if anyone else wants to give it a go that's welcome (and there are lots of other test cases people can play with writing if this one is taken before they get to it).
> JUNIT test case for party communication
> ----------------------------------------
>
> Key: OFBIZ-1468
> URL: https://issues.apache.org/jira/browse/OFBIZ-1468
> Project: OFBiz
> Issue Type: Sub-task
> Components: workeffort
> Affects Versions: SVN trunk
> Reporter: Vikas Mayur
> Assignee: Marco Risaliti
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: party_communication.patch
>
>
> Followed the process from link http://docs.ofbiz.org/display/OFBENDUSER/Party+%28Customer%29+Communication
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1468) JUNIT test case for party
communication
Posted by "santosh malviya (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
santosh malviya updated OFBIZ-1468:
-----------------------------------
Attachment: PartyCommunication.patch
Hi Marco,
I changed the name of patch because it was made in Java earliar, sorry for inconvenience. I have uploaded the modified patch and it is ready for testing.
> JUNIT test case for party communication
> ----------------------------------------
>
> Key: OFBIZ-1468
> URL: https://issues.apache.org/jira/browse/OFBIZ-1468
> Project: OFBiz
> Issue Type: Sub-task
> Components: workeffort
> Affects Versions: SVN trunk
> Reporter: Vikas Mayur
> Assignee: Marco Risaliti
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: party_communication.patch, PartyCommunication.patch, PartyCommunication.patch, PartyCommunication.patch, PartyCommunication.patch
>
>
> Followed the process from link http://docs.ofbiz.org/display/OFBENDUSER/Party+%28Customer%29+Communication
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1468) JUNIT test case for party
communication
Posted by "Vikas Mayur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vikas Mayur updated OFBIZ-1468:
-------------------------------
Attachment: party_communication.patch
Patch from Santosh Malviya
> JUNIT test case for party communication
> ----------------------------------------
>
> Key: OFBIZ-1468
> URL: https://issues.apache.org/jira/browse/OFBIZ-1468
> Project: OFBiz
> Issue Type: Sub-task
> Reporter: Vikas Mayur
> Attachments: party_communication.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1468) JUNIT test case for party
communication
Posted by "Vikas Mayur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12553906 ]
Vikas Mayur commented on OFBIZ-1468:
------------------------------------
I will ask Santosh to upload a new patch using simple method.
> JUNIT test case for party communication
> ----------------------------------------
>
> Key: OFBIZ-1468
> URL: https://issues.apache.org/jira/browse/OFBIZ-1468
> Project: OFBiz
> Issue Type: Sub-task
> Components: workeffort
> Affects Versions: SVN trunk
> Reporter: Vikas Mayur
> Assignee: Marco Risaliti
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: party_communication.patch
>
>
> Followed the process from link http://docs.ofbiz.org/display/OFBENDUSER/Party+%28Customer%29+Communication
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (OFBIZ-1468) JUNIT test case for
party communication
Posted by "Santosh Malviya (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12557140#action_12557140 ]
santosh_malviya edited comment on OFBIZ-1468 at 1/8/08 10:07 PM:
-----------------------------------------------------------------
Hi Marco,
I changed the name of patch because it was made in Java earliar, sorry for inconvenience. I have uploaded the modified patch "PartyCommunication.patch" and it is ready for testing.
was (Author: santosh_malviya):
Hi Marco,
I changed the name of patch because it was made in Java earliar, sorry for inconvenience. I have uploaded the modified patch and it is ready for testing.
> JUNIT test case for party communication
> ----------------------------------------
>
> Key: OFBIZ-1468
> URL: https://issues.apache.org/jira/browse/OFBIZ-1468
> Project: OFBiz
> Issue Type: Sub-task
> Components: workeffort
> Affects Versions: SVN trunk
> Reporter: Vikas Mayur
> Assignee: Marco Risaliti
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: party_communication.patch, PartyCommunication.patch, PartyCommunication.patch, PartyCommunication.patch, PartyCommunication.patch
>
>
> Followed the process from link http://docs.ofbiz.org/display/OFBENDUSER/Party+%28Customer%29+Communication
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1468) JUNIT test case for party
communication
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12556968#action_12556968 ]
Jacques Le Roux commented on OFBIZ-1468:
----------------------------------------
Hi Marco,
It seems that party_communication.patch is the old one (note the lowercase "p"). I recommend to keep exactly the same name (here should have been party_communication.patch, but it's obvious in this case. If you put your mouse under the name you will see a popup with the date (or am I missing something since this is a real quick comment ?). It's easier for eveyone when you keep the exact same name, Jira takes care of it by graying the old files...
Thanks
> JUNIT test case for party communication
> ----------------------------------------
>
> Key: OFBIZ-1468
> URL: https://issues.apache.org/jira/browse/OFBIZ-1468
> Project: OFBiz
> Issue Type: Sub-task
> Components: workeffort
> Affects Versions: SVN trunk
> Reporter: Vikas Mayur
> Assignee: Marco Risaliti
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: party_communication.patch, PartyCommunication.patch, PartyCommunication.patch, PartyCommunication.patch
>
>
> Followed the process from link http://docs.ofbiz.org/display/OFBENDUSER/Party+%28Customer%29+Communication
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-1468) JUNIT test case for party
communication
Posted by "Marco Risaliti (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marco Risaliti closed OFBIZ-1468.
---------------------------------
Resolution: Fixed
Thanks Vikas,
your modified patch is in trunk rev. 612994.
There was some contachMechId that was not present into the default OFBiz demo data.
> JUNIT test case for party communication
> ----------------------------------------
>
> Key: OFBIZ-1468
> URL: https://issues.apache.org/jira/browse/OFBIZ-1468
> Project: OFBiz
> Issue Type: Sub-task
> Components: workeffort
> Affects Versions: SVN trunk
> Reporter: Vikas Mayur
> Assignee: Marco Risaliti
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: party_communication.patch, PartyCommunication.patch, PartyCommunication.patch, PartyCommunication.patch, PartyCommunication.patch
>
>
> Followed the process from link http://docs.ofbiz.org/display/OFBENDUSER/Party+%28Customer%29+Communication
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1468) JUNIT test case for party
communication
Posted by "Marco Risaliti (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12556905#action_12556905 ]
Marco Risaliti commented on OFBIZ-1468:
---------------------------------------
Hi santosh,
could you please rename the last patch with a different name like PartyCommunication_last.patch otherwise I didn't know which patch I have to review.
And could you please confirm if it's ready to be review so I will test it ?
Thanks
Marco
> JUNIT test case for party communication
> ----------------------------------------
>
> Key: OFBIZ-1468
> URL: https://issues.apache.org/jira/browse/OFBIZ-1468
> Project: OFBiz
> Issue Type: Sub-task
> Components: workeffort
> Affects Versions: SVN trunk
> Reporter: Vikas Mayur
> Assignee: Marco Risaliti
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: party_communication.patch, PartyCommunication.patch, PartyCommunication.patch, PartyCommunication.patch
>
>
> Followed the process from link http://docs.ofbiz.org/display/OFBENDUSER/Party+%28Customer%29+Communication
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1468) JUNIT test case for party
communication
Posted by "Marco Risaliti (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marco Risaliti updated OFBIZ-1468:
----------------------------------
Hi David,
I have not understood if your was general considerations on how to write JUnit test cases or you refer to this particular patch that has to be rewritten using minilang instead of a java class.
So in case it can be commit as java class I can proceed after my tests.
Sorry for my bad english.
Thanks
Marco
> JUNIT test case for party communication
> ----------------------------------------
>
> Key: OFBIZ-1468
> URL: https://issues.apache.org/jira/browse/OFBIZ-1468
> Project: OFBiz
> Issue Type: Sub-task
> Components: workeffort
> Affects Versions: SVN trunk
> Reporter: Vikas Mayur
> Assignee: Marco Risaliti
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: party_communication.patch
>
>
> Followed the process from link http://docs.ofbiz.org/display/OFBENDUSER/Party+%28Customer%29+Communication
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1468) JUNIT test case for party
communication
Posted by "santosh malviya (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
santosh malviya updated OFBIZ-1468:
-----------------------------------
Attachment: PartyCommunication.patch
> JUNIT test case for party communication
> ----------------------------------------
>
> Key: OFBIZ-1468
> URL: https://issues.apache.org/jira/browse/OFBIZ-1468
> Project: OFBiz
> Issue Type: Sub-task
> Components: workeffort
> Affects Versions: SVN trunk
> Reporter: Vikas Mayur
> Assignee: Marco Risaliti
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: party_communication.patch, PartyCommunication.patch, PartyCommunication.patch, PartyCommunication.patch
>
>
> Followed the process from link http://docs.ofbiz.org/display/OFBENDUSER/Party+%28Customer%29+Communication
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1468) JUNIT test case for party
communication
Posted by "Vikas Mayur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12560348#action_12560348 ]
Vikas Mayur commented on OFBIZ-1468:
------------------------------------
Marco, BTW I have only helped Santosh Malviya for OFBIZ-1468 where ever he needs and reviewed his work. After that Its only his effort to convert java to minilang + testing the patch. So majority of credit goes to Santosh Malviya :)
> JUNIT test case for party communication
> ----------------------------------------
>
> Key: OFBIZ-1468
> URL: https://issues.apache.org/jira/browse/OFBIZ-1468
> Project: OFBiz
> Issue Type: Sub-task
> Components: workeffort
> Affects Versions: SVN trunk
> Reporter: Vikas Mayur
> Assignee: Marco Risaliti
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: party_communication.patch, PartyCommunication.patch, PartyCommunication.patch, PartyCommunication.patch, PartyCommunication.patch
>
>
> Followed the process from link http://docs.ofbiz.org/display/OFBENDUSER/Party+%28Customer%29+Communication
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1468) JUNIT test case for party
communication
Posted by "Santosh Malviya (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Santosh Malviya updated OFBIZ-1468:
-----------------------------------
Attachment: PartyCommunication.patch
Java services have been converted into simple methods.
> JUNIT test case for party communication
> ----------------------------------------
>
> Key: OFBIZ-1468
> URL: https://issues.apache.org/jira/browse/OFBIZ-1468
> Project: OFBiz
> Issue Type: Sub-task
> Components: workeffort
> Affects Versions: SVN trunk
> Reporter: Vikas Mayur
> Assignee: Marco Risaliti
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: party_communication.patch, PartyCommunication.patch
>
>
> Followed the process from link http://docs.ofbiz.org/display/OFBENDUSER/Party+%28Customer%29+Communication
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1468) JUNIT test case for party
communication
Posted by "santosh malviya (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
santosh malviya updated OFBIZ-1468:
-----------------------------------
Attachment: PartyCommunication.patch
Modified patch according to comments.
> JUNIT test case for party communication
> ----------------------------------------
>
> Key: OFBIZ-1468
> URL: https://issues.apache.org/jira/browse/OFBIZ-1468
> Project: OFBiz
> Issue Type: Sub-task
> Components: workeffort
> Affects Versions: SVN trunk
> Reporter: Vikas Mayur
> Assignee: Marco Risaliti
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: party_communication.patch, PartyCommunication.patch, PartyCommunication.patch
>
>
> Followed the process from link http://docs.ofbiz.org/display/OFBENDUSER/Party+%28Customer%29+Communication
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1468) JUNIT test case for party
communication
Posted by "David E. Jones (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12551243 ]
David E. Jones commented on OFBIZ-1468:
---------------------------------------
Some general tips:
1. As a generality we want as much as possible of this written in simple-methods; that may be difficult for the sales and purchase order ones because of the cart interactions, but for this and others that basically just do service calls and such they should definitely be in simple-methods; note that with the test tools you can call a simple-method directly and it doesn't have to be wrapped in a service
2. to test results a nice tool is to use an XML data file like the ones we use for imports, but use for assertions instead; there are various examples of this in OFBiz, some good ones in the framework/service component (more specifically in the service/testdef/data directory)
In general these look good though and will be very helpful to do regression testing and sanity checks as we go forward.
> JUNIT test case for party communication
> ----------------------------------------
>
> Key: OFBIZ-1468
> URL: https://issues.apache.org/jira/browse/OFBIZ-1468
> Project: OFBiz
> Issue Type: Sub-task
> Components: workeffort
> Affects Versions: SVN trunk
> Reporter: Vikas Mayur
> Assignee: Marco Risaliti
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: party_communication.patch
>
>
> Followed the process from link http://docs.ofbiz.org/display/OFBENDUSER/Party+%28Customer%29+Communication
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.