You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Brian Houser (Jira)" <ji...@apache.org> on 2021/04/07 06:23:00 UTC
[jira] [Commented] (CASSANDRA-16350) Improve compaction param
"provide_overlapping_tombstones" handling
[ https://issues.apache.org/jira/browse/CASSANDRA-16350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17316000#comment-17316000 ]
Brian Houser commented on CASSANDRA-16350:
------------------------------------------
Ok fixed and added tests. Going to attach a patch after handling some paperwork on my end.
> Improve compaction param "provide_overlapping_tombstones" handling
> ------------------------------------------------------------------
>
> Key: CASSANDRA-16350
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16350
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Compaction
> Reporter: Marcus Eriksson
> Assignee: Brian Houser
> Priority: Normal
>
> We currently have no cqlsh autocompletion for {{provide_overlapping_tombstones}}. We should also improve the validation for the parameter given as it is currently quite unhelpful:
> {code}
> cqlsh:x> create table z (id int primary key, x int) with compaction = {'class': 'SizeTieredCompactionStrategy', 'provide_overlapping_tombstones':'xyz'};
> NoHostAvailable:
> {code}
> and an exception in the logs;
> {code}
> ERROR [Native-Transport-Requests-1] 2020-12-14 13:25:46,575 QueryMessage.java:121 - Unexpected error during query
> java.lang.IllegalArgumentException: No enum constant org.apache.cassandra.schema.CompactionParams.TombstoneOption.XYZ
> at java.lang.Enum.valueOf(Enum.java:238)
> at org.apache.cassandra.schema.CompactionParams$TombstoneOption.valueOf(CompactionParams.java:59)
> at org.apache.cassandra.schema.CompactionParams.create(CompactionParams.java:98)
> at org.apache.cassandra.schema.CompactionParams.fromMap(CompactionParams.java:255)
> at org.apache.cassandra.cql3.statements.schema.TableAttributes.build(TableAttributes.java:98)
> at org.apache.cassandra.cql3.statements.schema.TableAttributes.validate(TableAttributes.java:58)
> at org.apache.cassandra.cql3.statements.schema.CreateTableStatement.builder(CreateTableStatement.java:145)
> at org.apache.cassandra.cql3.statements.schema.CreateTableStatement.apply(CreateTableStatement.java:104)
> at org.apache.cassandra.schema.Schema.transform(Schema.java:587)
> at org.apache.cassandra.schema.MigrationManager.lambda$announce$2(MigrationManager.java:221)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
> at java.lang.Thread.run(Thread.java:748)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org