You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Sh Ma (JIRA)" <de...@myfaces.apache.org> on 2005/11/25 23:55:56 UTC

[jira] Created: (MYFACES-877) Tiles Support functionality fails to support parameterization of Tiles

Tiles Support functionality fails to support parameterization of Tiles
----------------------------------------------------------------------

         Key: MYFACES-877
         URL: http://issues.apache.org/jira/browse/MYFACES-877
     Project: MyFaces
        Type: Bug
  Components: Tomahawk  
    Versions: 1.1.1    
 Environment: Tested on Windows XP Pro SP2, Tomcat 5.5.7, Java 1.5.0_04-b05; modified the Tiles Example
    Reporter: Sh Ma


I've included an example of this bug in the attached file.  This is just a slight modification of the Tiles example application.  I add a new page (it's the last link of the navigation bar (Parameterizing Tiles)) that demonstrates this possible bug.

When one tries to parameterize a styleClass attribute, e.g. in the tiles-definition file:
    
<definition name="/page5.tiles" extends="layout.example" >
     <put name="valueBoundStyleClass" value="hardCodedStyleClass" />
     <put name="body" value="/page5.jsp" />
</definition>

and a tag that attempts to import the valueBoundStyleClass attribute for the styleClass attribute:

<h:outputText value="This element's styleClass attribute attempts to import an attribute.  The text font-size should be x-large and the text should should be bold." styleClass="#{valueBoundStyleClass}" />

The appropriate CSS style is not rendered.  Interestingly, this h:outputText tag does not create the <span class="..."> ... </span> HTML output...  For me, this has not only happened in the h:outputText tag, but also for styleClass attributes in h:dataTable, h:selectOneMenu, etc.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (MYFACES-877) Tiles Support functionality fails to support parameterization of Tiles

Posted by "Kalle Korhonen (JIRA)" <de...@myfaces.apache.org>.
    [ http://issues.apache.org/jira/browse/MYFACES-877?page=comments#action_12358544 ] 

Kalle Korhonen commented on MYFACES-877:
----------------------------------------

... and by specification, h:outputText isn't supposed to render a span tag around the text if no styleclass is specified.

> Tiles Support functionality fails to support parameterization of Tiles
> ----------------------------------------------------------------------
>
>          Key: MYFACES-877
>          URL: http://issues.apache.org/jira/browse/MYFACES-877
>      Project: MyFaces
>         Type: Bug
>   Components: Tomahawk
>     Versions: 1.1.1
>  Environment: Tested on Windows XP Pro SP2, Tomcat 5.5.7, Java 1.5.0_04-b05; modified the Tiles Example
>     Reporter: Sh Ma
>  Attachments: tiles.war
>
> I've included an example of this bug in the attached file.  This is just a slight modification of the Tiles example application.  I add a new page (it's the last link of the navigation bar (Parameterizing Tiles)) that demonstrates this possible bug.
> When one tries to parameterize a styleClass attribute, e.g. in the tiles-definition file:
>     
> <definition name="/page5.tiles" extends="layout.example" >
>      <put name="valueBoundStyleClass" value="hardCodedStyleClass" />
>      <put name="body" value="/page5.jsp" />
> </definition>
> and a tag that attempts to import the valueBoundStyleClass attribute for the styleClass attribute:
> <h:outputText value="This element's styleClass attribute attempts to import an attribute.  The text font-size should be x-large and the text should should be bold." styleClass="#{valueBoundStyleClass}" />
> The appropriate CSS style is not rendered.  Interestingly, this h:outputText tag does not create the <span class="..."> ... </span> HTML output...  For me, this has not only happened in the h:outputText tag, but also for styleClass attributes in h:dataTable, h:selectOneMenu, etc.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (MYFACES-877) Tiles Support functionality fails to support parameterization of Tiles

Posted by "Sh Ma (JIRA)" <de...@myfaces.apache.org>.
     [ http://issues.apache.org/jira/browse/MYFACES-877?page=all ]

Sh Ma updated MYFACES-877:
--------------------------

    Attachment: tiles.war

> Tiles Support functionality fails to support parameterization of Tiles
> ----------------------------------------------------------------------
>
>          Key: MYFACES-877
>          URL: http://issues.apache.org/jira/browse/MYFACES-877
>      Project: MyFaces
>         Type: Bug
>   Components: Tomahawk
>     Versions: 1.1.1
>  Environment: Tested on Windows XP Pro SP2, Tomcat 5.5.7, Java 1.5.0_04-b05; modified the Tiles Example
>     Reporter: Sh Ma
>  Attachments: tiles.war
>
> I've included an example of this bug in the attached file.  This is just a slight modification of the Tiles example application.  I add a new page (it's the last link of the navigation bar (Parameterizing Tiles)) that demonstrates this possible bug.
> When one tries to parameterize a styleClass attribute, e.g. in the tiles-definition file:
>     
> <definition name="/page5.tiles" extends="layout.example" >
>      <put name="valueBoundStyleClass" value="hardCodedStyleClass" />
>      <put name="body" value="/page5.jsp" />
> </definition>
> and a tag that attempts to import the valueBoundStyleClass attribute for the styleClass attribute:
> <h:outputText value="This element's styleClass attribute attempts to import an attribute.  The text font-size should be x-large and the text should should be bold." styleClass="#{valueBoundStyleClass}" />
> The appropriate CSS style is not rendered.  Interestingly, this h:outputText tag does not create the <span class="..."> ... </span> HTML output...  For me, this has not only happened in the h:outputText tag, but also for styleClass attributes in h:dataTable, h:selectOneMenu, etc.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (MYFACES-877) Tiles Support functionality fails to support parameterization of Tiles

Posted by "Kalle Korhonen (JIRA)" <de...@myfaces.apache.org>.
    [ http://issues.apache.org/jira/browse/MYFACES-877?page=comments#action_12358543 ] 

Kalle Korhonen commented on MYFACES-877:
----------------------------------------

Not a bug, JSF EL notation does not import the Tiles attribute. Use <tiles:importAttribute scope="request" name="valueBoundStyleClass"/> tag to import it into a JSP scope of your choice. Suggesting to mark this bug as invalid.


> Tiles Support functionality fails to support parameterization of Tiles
> ----------------------------------------------------------------------
>
>          Key: MYFACES-877
>          URL: http://issues.apache.org/jira/browse/MYFACES-877
>      Project: MyFaces
>         Type: Bug
>   Components: Tomahawk
>     Versions: 1.1.1
>  Environment: Tested on Windows XP Pro SP2, Tomcat 5.5.7, Java 1.5.0_04-b05; modified the Tiles Example
>     Reporter: Sh Ma
>  Attachments: tiles.war
>
> I've included an example of this bug in the attached file.  This is just a slight modification of the Tiles example application.  I add a new page (it's the last link of the navigation bar (Parameterizing Tiles)) that demonstrates this possible bug.
> When one tries to parameterize a styleClass attribute, e.g. in the tiles-definition file:
>     
> <definition name="/page5.tiles" extends="layout.example" >
>      <put name="valueBoundStyleClass" value="hardCodedStyleClass" />
>      <put name="body" value="/page5.jsp" />
> </definition>
> and a tag that attempts to import the valueBoundStyleClass attribute for the styleClass attribute:
> <h:outputText value="This element's styleClass attribute attempts to import an attribute.  The text font-size should be x-large and the text should should be bold." styleClass="#{valueBoundStyleClass}" />
> The appropriate CSS style is not rendered.  Interestingly, this h:outputText tag does not create the <span class="..."> ... </span> HTML output...  For me, this has not only happened in the h:outputText tag, but also for styleClass attributes in h:dataTable, h:selectOneMenu, etc.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (MYFACES-877) Tiles Support functionality fails to support parameterization of Tiles

Posted by "Sh Ma (JIRA)" <de...@myfaces.apache.org>.
    [ http://issues.apache.org/jira/browse/MYFACES-877?page=comments#action_12358551 ] 

Sh Ma commented on MYFACES-877:
-------------------------------

Hi Kalle,

When I used Tiles with JSF - without using the Tiles support in Tomahawk - the Tiles attributes are correctly imported...  So the importation of Tiles attributes (in EL notation) failed only after I used Tiles support in Tomahawk.  So it seems there may be a problem with Tiles support in Tomahawk.

In terms of h:outputText - since the Tiles attribute was not imported, then the styleClass attribute had no value, so I agree with your assessment that span should not be rendered if there is no corresponding styleClass attribute value.

> Tiles Support functionality fails to support parameterization of Tiles
> ----------------------------------------------------------------------
>
>          Key: MYFACES-877
>          URL: http://issues.apache.org/jira/browse/MYFACES-877
>      Project: MyFaces
>         Type: Bug
>   Components: Tomahawk
>     Versions: 1.1.1
>  Environment: Tested on Windows XP Pro SP2, Tomcat 5.5.7, Java 1.5.0_04-b05; modified the Tiles Example
>     Reporter: Sh Ma
>  Attachments: tiles.war
>
> I've included an example of this bug in the attached file.  This is just a slight modification of the Tiles example application.  I add a new page (it's the last link of the navigation bar (Parameterizing Tiles)) that demonstrates this possible bug.
> When one tries to parameterize a styleClass attribute, e.g. in the tiles-definition file:
>     
> <definition name="/page5.tiles" extends="layout.example" >
>      <put name="valueBoundStyleClass" value="hardCodedStyleClass" />
>      <put name="body" value="/page5.jsp" />
> </definition>
> and a tag that attempts to import the valueBoundStyleClass attribute for the styleClass attribute:
> <h:outputText value="This element's styleClass attribute attempts to import an attribute.  The text font-size should be x-large and the text should should be bold." styleClass="#{valueBoundStyleClass}" />
> The appropriate CSS style is not rendered.  Interestingly, this h:outputText tag does not create the <span class="..."> ... </span> HTML output...  For me, this has not only happened in the h:outputText tag, but also for styleClass attributes in h:dataTable, h:selectOneMenu, etc.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira