You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2008/09/10 23:38:44 UTC
[jira] Commented: (HADOOP-4071)
FSNameSystem.isReplicationInProgress should add an underReplicated block to
the neededReplication queue using method "add" not "update"
[ https://issues.apache.org/jira/browse/HADOOP-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12629983#action_12629983 ]
Hadoop QA commented on HADOOP-4071:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12389541/decommission.patch
against trunk revision 693705.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3235/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3235/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3235/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3235/console
This message is automatically generated.
> FSNameSystem.isReplicationInProgress should add an underReplicated block to the neededReplication queue using method "add" not "update"
> ---------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-4071
> URL: https://issues.apache.org/jira/browse/HADOOP-4071
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Hairong Kuang
> Assignee: Hairong Kuang
> Fix For: 0.19.0
>
> Attachments: decommission.patch
>
>
> We have a datanode that did not get decommission done for days. It turned out that there was an under replicated block that was never placed in the neededReplication queue and therefore did not get replicated. The following debug line showed the problem:
> " DEBUG org.apache.hadoop.dfs.StateChange: UnderReplicationBlocks.update blk_-7437651423871278837_0 curReplicas 8
> curExpectedReplicas 10 oldReplicas 9 oldExpectedReplicas 10 curPri 2 oldPri 2"
> The block was not in the neededReplication queue, but the update method concluded that the block was under replicated and the priority level did not change, so it did not add the block to the needReplication queue.
> The solution is that in stead of using the update method, the name node should use the add method to add the block to the neededReplication queue. The add method guarantees success if the block is indeed under replicated.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.