You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2017/05/08 21:57:57 UTC
Review Request 59068: Updated release/versioning docs for "-dev"
version scheme.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59068/
-----------------------------------------------------------
Review request for mesos.
Bugs: MESOS-7473
https://issues.apache.org/jira/browse/MESOS-7473
Repository: mesos
Description
-------
Mesos now uses the "-dev" prerelease label to identify code in the
master branch in the period before the next release branch has been
cut.
For example, after creating the 1.3.x release branch, we previously
updated the version number in the master branch to be "1.4.0". The new
policy is to instead use the version number "1.4.0-dev" in the master
branch. When the release branch for 1.4.x is created, the version number
will then be updated to remove the "-dev" prerelease label.
This commit also makes a few minor procedural changes to the release
process -- for example, we now create the release branch first and then
tag a commit in that branch, rather than first tagging a release and
then creating the branch from the tag.
Diffs
-----
docs/release-guide.md fa607287456dff5e078fe97690ef3728a6419e8a
docs/versioning.md 178026ccca3569ee295291381f4b43ed17fcd4fe
Diff: https://reviews.apache.org/r/59068/diff/1/
Testing
-------
Thanks,
Neil Conway
Re: Review Request 59068: Updated release/versioning docs for "-dev"
version scheme.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59068/
-----------------------------------------------------------
(Updated May 9, 2017, 3:40 p.m.)
Review request for mesos and Vinod Kone.
Changes
-------
Use `-dev` suffix for release branches.
Bugs: MESOS-7473
https://issues.apache.org/jira/browse/MESOS-7473
Repository: mesos
Description
-------
Mesos now uses the "-dev" prerelease label to identify code in the
master branch in the period before the next release branch has been
cut.
For example, after creating the 1.3.x release branch, we previously
updated the version number in the master branch to be "1.4.0". The new
policy is to instead use the version number "1.4.0-dev" in the master
branch. When the release branch for 1.4.x is created, the version number
will then be updated to remove the "-dev" prerelease label.
This commit also makes a few minor procedural changes to the release
process -- for example, we now create the release branch first and then
tag a commit in that branch, rather than first tagging a release and
then creating the branch from the tag.
Diffs (updated)
-----
docs/release-guide.md fa607287456dff5e078fe97690ef3728a6419e8a
docs/versioning.md 178026ccca3569ee295291381f4b43ed17fcd4fe
Diff: https://reviews.apache.org/r/59068/diff/2/
Changes: https://reviews.apache.org/r/59068/diff/1-2/
Testing
-------
Visual inspection, previewed with github gist.
Thanks,
Neil Conway
Re: Review Request 59068: Updated release/versioning docs for "-dev"
version scheme.
Posted by Neil Conway <ne...@gmail.com>.
> On May 8, 2017, 11:19 p.m., Vinod Kone wrote:
> > docs/release-guide.md
> > Lines 150 (patched)
> > <https://reviews.apache.org/r/59068/diff/1/?file=1710930#file1710930line150>
> >
> > Shouldn't the release branch also have "-dev" suffix to indicate development of the next patch version to be consistent?
> >
> > Maybe after a release has been voted/tagged, we need to update the version in the release branch to next patch version with "-dev"? Not sure if this breaks our release scripts though.
> Shouldn't the release branch also have "-dev" suffix to indicate development of the next patch version to be consistent?
Sure, using "-dev" for release branches as well would be more consistent, I'll make that change.
- Neil
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59068/#review174236
-----------------------------------------------------------
On May 8, 2017, 10:01 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59068/
> -----------------------------------------------------------
>
> (Updated May 8, 2017, 10:01 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-7473
> https://issues.apache.org/jira/browse/MESOS-7473
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Mesos now uses the "-dev" prerelease label to identify code in the
> master branch in the period before the next release branch has been
> cut.
>
> For example, after creating the 1.3.x release branch, we previously
> updated the version number in the master branch to be "1.4.0". The new
> policy is to instead use the version number "1.4.0-dev" in the master
> branch. When the release branch for 1.4.x is created, the version number
> will then be updated to remove the "-dev" prerelease label.
>
> This commit also makes a few minor procedural changes to the release
> process -- for example, we now create the release branch first and then
> tag a commit in that branch, rather than first tagging a release and
> then creating the branch from the tag.
>
>
> Diffs
> -----
>
> docs/release-guide.md fa607287456dff5e078fe97690ef3728a6419e8a
> docs/versioning.md 178026ccca3569ee295291381f4b43ed17fcd4fe
>
>
> Diff: https://reviews.apache.org/r/59068/diff/1/
>
>
> Testing
> -------
>
> Visual inspection, previewed with github gist.
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 59068: Updated release/versioning docs for "-dev"
version scheme.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59068/#review174236
-----------------------------------------------------------
docs/release-guide.md
Lines 150 (patched)
<https://reviews.apache.org/r/59068/#comment247347>
Shouldn't the release branch also have "-dev" suffix to indicate development of the next patch version to be consistent?
Maybe after a release has been voted/tagged, we need to update the version in the release branch to next patch version with "-dev"? Not sure if this breaks our release scripts though.
- Vinod Kone
On May 8, 2017, 10:01 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59068/
> -----------------------------------------------------------
>
> (Updated May 8, 2017, 10:01 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-7473
> https://issues.apache.org/jira/browse/MESOS-7473
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Mesos now uses the "-dev" prerelease label to identify code in the
> master branch in the period before the next release branch has been
> cut.
>
> For example, after creating the 1.3.x release branch, we previously
> updated the version number in the master branch to be "1.4.0". The new
> policy is to instead use the version number "1.4.0-dev" in the master
> branch. When the release branch for 1.4.x is created, the version number
> will then be updated to remove the "-dev" prerelease label.
>
> This commit also makes a few minor procedural changes to the release
> process -- for example, we now create the release branch first and then
> tag a commit in that branch, rather than first tagging a release and
> then creating the branch from the tag.
>
>
> Diffs
> -----
>
> docs/release-guide.md fa607287456dff5e078fe97690ef3728a6419e8a
> docs/versioning.md 178026ccca3569ee295291381f4b43ed17fcd4fe
>
>
> Diff: https://reviews.apache.org/r/59068/diff/1/
>
>
> Testing
> -------
>
> Visual inspection, previewed with github gist.
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 59068: Updated release/versioning docs for "-dev"
version scheme.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59068/
-----------------------------------------------------------
(Updated May 8, 2017, 10:01 p.m.)
Review request for mesos and Vinod Kone.
Bugs: MESOS-7473
https://issues.apache.org/jira/browse/MESOS-7473
Repository: mesos
Description
-------
Mesos now uses the "-dev" prerelease label to identify code in the
master branch in the period before the next release branch has been
cut.
For example, after creating the 1.3.x release branch, we previously
updated the version number in the master branch to be "1.4.0". The new
policy is to instead use the version number "1.4.0-dev" in the master
branch. When the release branch for 1.4.x is created, the version number
will then be updated to remove the "-dev" prerelease label.
This commit also makes a few minor procedural changes to the release
process -- for example, we now create the release branch first and then
tag a commit in that branch, rather than first tagging a release and
then creating the branch from the tag.
Diffs
-----
docs/release-guide.md fa607287456dff5e078fe97690ef3728a6419e8a
docs/versioning.md 178026ccca3569ee295291381f4b43ed17fcd4fe
Diff: https://reviews.apache.org/r/59068/diff/1/
Testing (updated)
-------
Visual inspection, previewed with github gist.
Thanks,
Neil Conway