You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Mike Tutkowski <mi...@solidfire.com> on 2014/04/25 20:34:13 UTC

[ACS4.4] Cherry pick 6dfa742eb8d6b775317829636bfa28f0ec297242

Hi Daan,

Please cherry pick 6dfa742eb8d6b775317829636bfa28f0ec297242 to 4.4.

It contains logic to help calculate the allocated space of a managed
storage pool more accurately.

Thanks!

-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkowski@solidfire.com
o: 303.746.7302
Advancing the way the world uses the
cloud<http://solidfire.com/solution/overview/?video=play>
*(tm)*

Re: [ACS4.4] Cherry pick 6dfa742eb8d6b775317829636bfa28f0ec297242

Posted by Daan Hoogland <da...@gmail.com>.
ah, that makes a lot of sense

On Fri, Apr 25, 2014 at 10:41 PM, Mike Tutkowski
<mi...@solidfire.com> wrote:
> Perhaps I did not phrase that correctly.
>
> It is a slight change in logic to enable managed storage to circumvent the
> rest of the logic in that method where snapshots and templates get included
> in the allocated amount (not necessary for managed storage).
>
>
> On Fri, Apr 25, 2014 at 2:28 PM, Daan Hoogland <da...@gmail.com>wrote:
>
>> On Fri, Apr 25, 2014 at 8:34 PM, Mike Tutkowski
>> <mi...@solidfire.com> wrote:
>> > 6dfa742eb8d6b775317829636bfa28f0ec297242
>>
>>
>> Mike,
>>
>> how is
>> -            totalAllocatedSize = getUsedBytes(pool);
>> +            return getUsedBytes(pool);
>> logic added?
>>
>> I did not see any harm in pulling it in. btw.
>> --
>> Daan
>>
>
>
>
> --
> *Mike Tutkowski*
> *Senior CloudStack Developer, SolidFire Inc.*
> e: mike.tutkowski@solidfire.com
> o: 303.746.7302
> Advancing the way the world uses the
> cloud<http://solidfire.com/solution/overview/?video=play>
> *(tm)*



-- 
Daan

Re: [ACS4.4] Cherry pick 6dfa742eb8d6b775317829636bfa28f0ec297242

Posted by Mike Tutkowski <mi...@solidfire.com>.
Perhaps I did not phrase that correctly.

It is a slight change in logic to enable managed storage to circumvent the
rest of the logic in that method where snapshots and templates get included
in the allocated amount (not necessary for managed storage).


On Fri, Apr 25, 2014 at 2:28 PM, Daan Hoogland <da...@gmail.com>wrote:

> On Fri, Apr 25, 2014 at 8:34 PM, Mike Tutkowski
> <mi...@solidfire.com> wrote:
> > 6dfa742eb8d6b775317829636bfa28f0ec297242
>
>
> Mike,
>
> how is
> -            totalAllocatedSize = getUsedBytes(pool);
> +            return getUsedBytes(pool);
> logic added?
>
> I did not see any harm in pulling it in. btw.
> --
> Daan
>



-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkowski@solidfire.com
o: 303.746.7302
Advancing the way the world uses the
cloud<http://solidfire.com/solution/overview/?video=play>
*(tm)*

Re: [ACS4.4] Cherry pick 6dfa742eb8d6b775317829636bfa28f0ec297242

Posted by Daan Hoogland <da...@gmail.com>.
On Fri, Apr 25, 2014 at 8:34 PM, Mike Tutkowski
<mi...@solidfire.com> wrote:
> 6dfa742eb8d6b775317829636bfa28f0ec297242


Mike,

how is
-            totalAllocatedSize = getUsedBytes(pool);
+            return getUsedBytes(pool);
logic added?

I did not see any harm in pulling it in. btw.
-- 
Daan