You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/06/04 19:56:28 UTC

[GitHub] [tvm] tqchen edited a comment on pull request #8196: [Vulkan][Refactor] Move ownership of per-CPU-thread objects to VulkanDeviceAPI

tqchen edited a comment on pull request #8196:
URL: https://github.com/apache/tvm/pull/8196#issuecomment-854966800


   Thanks @Lunderberg , it would still be useful to think about the overhead. While thread local is a different way of organizing things, the direct TLS lookup have a lower overhead than a lock based cache lookup. Assuming we only have the singleton case it might still be desirable to use TLS when possible(i understand that might restrict us to singleton usecases)
   
   Another minor thing is we usually keep the non-public facing apis in src/ so they are not visible to the downstream deps. This would help reduce the possible future API compact problem


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org