Re: [PR] [SPARK-51931][SQL] Add maxBytesPerOutputBatch to limit the number of bytes of Arrow output batch [spark]

["dongjoon-hyun (via GitHub)" <gi...@apache.org>]

dongjoon-hyun commented on code in PR #50735:
URL: https://github.com/apache/spark/pull/50735#discussion_r2062757047


##########
python/pyspark/sql/tests/arrow/test_arrow_map.py:
##########
@@ -246,14 +246,22 @@ def setUpClass(cls):
         cls.spark.conf.set("spark.sql.execution.arrow.maxBytesPerBatch", "10")
 
 
-class MapInArrowWithOutputArrowBatchSlicingTests(MapInArrowTests):
+class MapInArrowWithOutputArrowBatchSlicingRecordsTests(MapInArrowTests):
     @classmethod
     def setUpClass(cls):
         MapInArrowTests.setUpClass()
         cls.spark.conf.set("spark.sql.execution.arrow.maxRecordsPerBatch", "10")
         cls.spark.conf.set("spark.sql.execution.arrow.maxRecordsPerOutputBatch", "3")
 
 
+class MapInArrowWithOutputArrowBatchSlicingBytesTests(MapInArrowTests):
+    @classmethod
+    def setUpClass(cls):
+        MapInArrowTests.setUpClass()
+        cls.spark.conf.set("spark.sql.execution.arrow.maxRecordsPerBatch", "10")

Review Comment:
   Just a question. Do we still need this `maxRecordsPerBatch=10` for `Bytes` test?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org