[GitHub] [iceberg] rdblue commented on a change in pull request #2608: Core : Repair manifests

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #2608:
URL: https://github.com/apache/iceberg/pull/2608#discussion_r635649237



##########
File path: core/src/main/java/org/apache/iceberg/actions/BaseRewriteManifestsActionResult.java
##########
@@ -19,22 +19,27 @@
 
 package org.apache.iceberg.actions;
 
+import java.util.Set;
 import org.apache.iceberg.ManifestFile;
+import org.apache.iceberg.relocated.com.google.common.base.Preconditions;
 import org.apache.iceberg.relocated.com.google.common.collect.ImmutableList;
 
 public class BaseRewriteManifestsActionResult implements RewriteManifests.Result {
 
   private final Iterable<ManifestFile> rewrittenManifests;
   private final Iterable<ManifestFile> addedManifests;
+  private final Iterable<?> repairedManifests;
 
   public BaseRewriteManifestsActionResult(Iterable<ManifestFile> rewrittenManifests,
-                                          Iterable<ManifestFile> addedManifests) {
+                                          Iterable<ManifestFile> addedManifests,
+                                          Iterable<BaseRepairedManifestFile> repairedManifests) {

Review comment:
       You probably didn't intend to use the implementation class in this API, right?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org