You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Suma Shivaprasad <su...@gmail.com> on 2016/08/04 23:07:57 UTC

Review Request 50823: ATLAS-1096 HiveMetStoreBridge to use getEntity instead of DSL

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50823/
-----------------------------------------------------------

Review request for atlas.


Bugs: ATLAS-1096
    https://issues.apache.org/jira/browse/ATLAS-1096


Repository: atlas


Description
-------

Changed all searchDSL calls to getEntity by qualifiedName and typeName which will use indexes. 
Also fixed a minor issue with table qualifiedName in case of importTable


Diffs
-----

  addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java 8d24a67 
  addons/hive-bridge/src/test/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridgeTest.java f8aa93a 

Diff: https://reviews.apache.org/r/50823/diff/


Testing
-------


Thanks,

Suma Shivaprasad


Re: Review Request 50823: ATLAS-1096 HiveMetStoreBridge to use getEntity instead of DSL

Posted by Shwetha GS <ss...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50823/#review144873
-----------------------------------------------------------


Fix it, then Ship it!




will address these comments and commit


addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java (line 154)
<https://reviews.apache.org/r/50823/#comment211003>

    shouldn't ignore all exceptions, ignore only if 'not found' status



addons/hive-bridge/src/test/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridgeTest.java (line 100)
<https://reviews.apache.org/r/50823/#comment211008>

    Add an IT in HiveMetastoreBridgeIT which tests de-duping


- Shwetha GS


On Aug. 5, 2016, 4:29 a.m., Suma Shivaprasad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50823/
> -----------------------------------------------------------
> 
> (Updated Aug. 5, 2016, 4:29 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-1096
>     https://issues.apache.org/jira/browse/ATLAS-1096
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Changed all searchDSL calls to getEntity by qualifiedName and typeName which will use indexes. 
> Also fixed a minor issue with table qualifiedName in case of importTable
> 
> 
> Diffs
> -----
> 
>   addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java 8d24a67 
>   addons/hive-bridge/src/test/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridgeTest.java f8aa93a 
> 
> Diff: https://reviews.apache.org/r/50823/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Suma Shivaprasad
> 
>


Re: Review Request 50823: ATLAS-1096 HiveMetStoreBridge to use getEntity instead of DSL

Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50823/
-----------------------------------------------------------

(Updated Aug. 5, 2016, 4:29 a.m.)


Review request for atlas.


Changes
-------

Fixed potential NPE


Bugs: ATLAS-1096
    https://issues.apache.org/jira/browse/ATLAS-1096


Repository: atlas


Description
-------

Changed all searchDSL calls to getEntity by qualifiedName and typeName which will use indexes. 
Also fixed a minor issue with table qualifiedName in case of importTable


Diffs (updated)
-----

  addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java 8d24a67 
  addons/hive-bridge/src/test/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridgeTest.java f8aa93a 

Diff: https://reviews.apache.org/r/50823/diff/


Testing
-------


Thanks,

Suma Shivaprasad