[GitHub] liubao68 commented on a change in pull request #693: [SCB-548] support gracefully shutdown

[GitBox <gi...@apache.org>]

liubao68 commented on a change in pull request #693: [SCB-548] support gracefully shutdown
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/693#discussion_r187222394
 
 

 ##########
 File path: core/src/main/java/org/apache/servicecomb/core/handler/ShutdownHookHandler.java
 ##########
 @@ -56,6 +57,8 @@ public long getActiveCount() {
   @Override
   public void handle(Invocation invocation, AsyncResponse asyncResp) throws Exception {
     if (shuttingDown) {
+      System.out.println("shutting down in progress");
 
 Review comment:
   Do not use System.out.println to print logs. And we have already throw an exception with this message, and I think this log is not necessary.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services