You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/07/26 10:24:55 UTC
[GitHub] [flink] zentol opened a new pull request #16595: [FLINK-23496][ci] Use MVN_GLOBAL_OPTIONS during maven snapshot deployment
zentol opened a new pull request #16595:
URL: https://github.com/apache/flink/pull/16595
- splits MVN_GLOBAL_OPTIONS so that usages can use the majority of the options without the `--settings`, in case they also set it
- modify the nightly maven snapshot deployment to make use of this new property
This improves logging (by removing the download progress messages) and deduplicates optimizations (maven.wagon.http.pool).
This isn't the ideal solution, which would be to just call `run_mvn`, but I think this is a slightly safer option.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #16595: [FLINK-23496][ci] Use MVN_GLOBAL_OPTIONS during maven snapshot deployment
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #16595:
URL: https://github.com/apache/flink/pull/16595#discussion_r676971781
##########
File path: tools/ci/maven-utils.sh
##########
@@ -107,3 +105,6 @@ MVN_GLOBAL_OPTIONS+="--no-snapshot-updates "
MVN_GLOBAL_OPTIONS+="-B "
# globally control the build profile details
MVN_GLOBAL_OPTIONS+="$PROFILE "
Review comment:
well this is embarrassing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #16595: [FLINK-23496][ci] Use MVN_GLOBAL_OPTIONS during maven snapshot deployment
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #16595:
URL: https://github.com/apache/flink/pull/16595#discussion_r676972924
##########
File path: tools/azure-pipelines/build-nightly-dist.yml
##########
@@ -109,7 +109,7 @@ jobs:
</settings>
EOF
- export CUSTOM_OPTIONS="-Dgpg.skip -Drat.skip -Dcheckstyle.skip -Dmaven.wagon.http.pool=false --settings $(pwd)/deploy-settings.xml"
+ export CUSTOM_OPTIONS="${MVN_GLOBAL_OPTIONS_WITHOUT_MIRROR} -Dgpg.skip -Drat.skip -Dcheckstyle.skip --settings $(pwd)/deploy-settings.xml"
Review comment:
hmm..... -B makes no difference, -nsu is good because it can highlight mistakes in the dependency setup. $PROFILE could be problematic because it contains the scala switch :/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16595: [FLINK-23496][ci] Use MVN_GLOBAL_OPTIONS during maven snapshot deployment
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16595:
URL: https://github.com/apache/flink/pull/16595#issuecomment-886596423
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0eb8a6b55d3ab0bae9977108b76b180704afd31a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0eb8a6b55d3ab0bae9977108b76b180704afd31a",
"triggerType" : "PUSH"
}, {
"hash" : "8b7700d66fb0d5372fe3204c5cf03c3ec054f3f9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21008",
"triggerID" : "8b7700d66fb0d5372fe3204c5cf03c3ec054f3f9",
"triggerType" : "PUSH"
}, {
"hash" : "9d6473a26379e1e554c9ae59f8c64462e0bd9273",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9d6473a26379e1e554c9ae59f8c64462e0bd9273",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0eb8a6b55d3ab0bae9977108b76b180704afd31a UNKNOWN
* 8b7700d66fb0d5372fe3204c5cf03c3ec054f3f9 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21008)
* 9d6473a26379e1e554c9ae59f8c64462e0bd9273 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #16595: [FLINK-23496][ci] Use MVN_GLOBAL_OPTIONS during maven snapshot deployment
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #16595:
URL: https://github.com/apache/flink/pull/16595#discussion_r677165191
##########
File path: tools/azure-pipelines/build-nightly-dist.yml
##########
@@ -109,7 +109,7 @@ jobs:
</settings>
EOF
- export CUSTOM_OPTIONS="-Dgpg.skip -Drat.skip -Dcheckstyle.skip -Dmaven.wagon.http.pool=false --settings $(pwd)/deploy-settings.xml"
+ export CUSTOM_OPTIONS="${MVN_GLOBAL_OPTIONS_WITHOUT_MIRROR} -Dgpg.skip -Drat.skip -Dcheckstyle.skip --settings $(pwd)/deploy-settings.xml"
Review comment:
$PROFILE should be fine as it does not contain anything at the moment, and could be useful at some point for parameterization.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16595: [FLINK-23496][ci] Use MVN_GLOBAL_OPTIONS during maven snapshot deployment
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16595:
URL: https://github.com/apache/flink/pull/16595#issuecomment-886596423
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0eb8a6b55d3ab0bae9977108b76b180704afd31a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0eb8a6b55d3ab0bae9977108b76b180704afd31a",
"triggerType" : "PUSH"
}, {
"hash" : "8b7700d66fb0d5372fe3204c5cf03c3ec054f3f9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21008",
"triggerID" : "8b7700d66fb0d5372fe3204c5cf03c3ec054f3f9",
"triggerType" : "PUSH"
}, {
"hash" : "9d6473a26379e1e554c9ae59f8c64462e0bd9273",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21023",
"triggerID" : "9d6473a26379e1e554c9ae59f8c64462e0bd9273",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0eb8a6b55d3ab0bae9977108b76b180704afd31a UNKNOWN
* 9d6473a26379e1e554c9ae59f8c64462e0bd9273 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21023)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16595: [FLINK-23496][ci] Use MVN_GLOBAL_OPTIONS during maven snapshot deployment
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16595:
URL: https://github.com/apache/flink/pull/16595#issuecomment-886577389
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 9d6473a26379e1e554c9ae59f8c64462e0bd9273 (Sat Aug 28 12:23:18 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16595: [FLINK-23496][ci] Use MVN_GLOBAL_OPTIONS during maven snapshot deployment
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16595:
URL: https://github.com/apache/flink/pull/16595#issuecomment-886596423
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0eb8a6b55d3ab0bae9977108b76b180704afd31a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0eb8a6b55d3ab0bae9977108b76b180704afd31a",
"triggerType" : "PUSH"
}, {
"hash" : "8b7700d66fb0d5372fe3204c5cf03c3ec054f3f9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21008",
"triggerID" : "8b7700d66fb0d5372fe3204c5cf03c3ec054f3f9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0eb8a6b55d3ab0bae9977108b76b180704afd31a UNKNOWN
* 8b7700d66fb0d5372fe3204c5cf03c3ec054f3f9 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21008)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #16595: [FLINK-23496][ci] Use MVN_GLOBAL_OPTIONS during maven snapshot deployment
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16595:
URL: https://github.com/apache/flink/pull/16595#issuecomment-886596423
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0eb8a6b55d3ab0bae9977108b76b180704afd31a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0eb8a6b55d3ab0bae9977108b76b180704afd31a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0eb8a6b55d3ab0bae9977108b76b180704afd31a UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16595: [FLINK-23496][ci] Use MVN_GLOBAL_OPTIONS during maven snapshot deployment
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16595:
URL: https://github.com/apache/flink/pull/16595#issuecomment-886596423
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0eb8a6b55d3ab0bae9977108b76b180704afd31a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0eb8a6b55d3ab0bae9977108b76b180704afd31a",
"triggerType" : "PUSH"
}, {
"hash" : "8b7700d66fb0d5372fe3204c5cf03c3ec054f3f9",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8b7700d66fb0d5372fe3204c5cf03c3ec054f3f9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0eb8a6b55d3ab0bae9977108b76b180704afd31a UNKNOWN
* 8b7700d66fb0d5372fe3204c5cf03c3ec054f3f9 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] nicoweidner commented on a change in pull request #16595: [FLINK-23496][ci] Use MVN_GLOBAL_OPTIONS during maven snapshot deployment
Posted by GitBox <gi...@apache.org>.
nicoweidner commented on a change in pull request #16595:
URL: https://github.com/apache/flink/pull/16595#discussion_r676763465
##########
File path: tools/azure-pipelines/build-nightly-dist.yml
##########
@@ -109,7 +109,7 @@ jobs:
</settings>
EOF
- export CUSTOM_OPTIONS="-Dgpg.skip -Drat.skip -Dcheckstyle.skip -Dmaven.wagon.http.pool=false --settings $(pwd)/deploy-settings.xml"
+ export CUSTOM_OPTIONS="${MVN_GLOBAL_OPTIONS_WITHOUT_MIRROR} -Dgpg.skip -Drat.skip -Dcheckstyle.skip --settings $(pwd)/deploy-settings.xml"
Review comment:
Is it intended that we propagate some options that were not there before? Logging was mentioned in the description, but `--no-snapshot updates -B $PROFILE` is now also applied in https://github.com/apache/flink/blob/master/tools/releasing/deploy_staging_jars.sh#L46-L50
##########
File path: tools/ci/maven-utils.sh
##########
@@ -107,3 +105,6 @@ MVN_GLOBAL_OPTIONS+="--no-snapshot-updates "
MVN_GLOBAL_OPTIONS+="-B "
# globally control the build profile details
MVN_GLOBAL_OPTIONS+="$PROFILE "
Review comment:
all the options except the `--settings` one should be added to `MVN_GLOBAL_OPTIONS_WITHOUT_MIRROR`, shouldn't they?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #16595: [FLINK-23496][ci] Use MVN_GLOBAL_OPTIONS during maven snapshot deployment
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16595:
URL: https://github.com/apache/flink/pull/16595#issuecomment-886577389
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 0eb8a6b55d3ab0bae9977108b76b180704afd31a (Mon Jul 26 10:27:25 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol merged pull request #16595: [FLINK-23496][ci] Use MVN_GLOBAL_OPTIONS during maven snapshot deployment
Posted by GitBox <gi...@apache.org>.
zentol merged pull request #16595:
URL: https://github.com/apache/flink/pull/16595
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16595: [FLINK-23496][ci] Use MVN_GLOBAL_OPTIONS during maven snapshot deployment
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16595:
URL: https://github.com/apache/flink/pull/16595#issuecomment-886596423
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0eb8a6b55d3ab0bae9977108b76b180704afd31a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0eb8a6b55d3ab0bae9977108b76b180704afd31a",
"triggerType" : "PUSH"
}, {
"hash" : "8b7700d66fb0d5372fe3204c5cf03c3ec054f3f9",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21008",
"triggerID" : "8b7700d66fb0d5372fe3204c5cf03c3ec054f3f9",
"triggerType" : "PUSH"
}, {
"hash" : "9d6473a26379e1e554c9ae59f8c64462e0bd9273",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21023",
"triggerID" : "9d6473a26379e1e554c9ae59f8c64462e0bd9273",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0eb8a6b55d3ab0bae9977108b76b180704afd31a UNKNOWN
* 8b7700d66fb0d5372fe3204c5cf03c3ec054f3f9 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21008)
* 9d6473a26379e1e554c9ae59f8c64462e0bd9273 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21023)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org