You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@arrow.apache.org by "Dewey Dunnington (Jira)" <ji...@apache.org> on 2022/01/31 15:03:00 UTC

[jira] [Commented] (ARROW-15278) [R] Reorganise tests for dates and datetimes to test them together

    [ https://issues.apache.org/jira/browse/ARROW-15278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17484731#comment-17484731 ] 

Dewey Dunnington commented on ARROW-15278:
------------------------------------------

Where these tests live:

Date: https://github.com/apache/arrow/blob/03219e21b42f17294fba3b3d2b22a9117fe0f080/r/tests/testthat/test-dplyr-funcs-datetime.R#L487-L636

Datetime/timestamp: https://github.com/apache/arrow/blob/03219e21b42f17294fba3b3d2b22a9117fe0f080/r/tests/testthat/test-dplyr-funcs-datetime.R#L313-L483

> [R] Reorganise tests for dates and datetimes to test them together
> ------------------------------------------------------------------
>
>                 Key: ARROW-15278
>                 URL: https://issues.apache.org/jira/browse/ARROW-15278
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: R
>            Reporter: Nicola Crane
>            Assignee: Nicola Crane
>            Priority: Minor
>
> The tests in {{arrow/r/tests/test-dplyr-funcs-datetime.R}} have dates and datetimes tested separately.  Given that both I (the person who originally wrote them like that!), and subsequent contributors have ended up accidentally forgetting to test one of these classes, it would make more sense for the tests to just test both at once.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)