You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/01/22 07:23:17 UTC

[GitHub] [apisix-dashboard] imjoey opened a new pull request #1359: fix: Skip the data directly in Storage level

imjoey opened a new pull request #1359:
URL: https://github.com/apache/apisix-dashboard/pull/1359


   Signed-off-by: imjoey <ma...@apache.org>
   
   Please answer these questions before submitting a pull request
   
   - Why submit this pull request?
   - [x] Bugfix
   - [ ] New feature provided
   - [ ] Improve performance
   - [ ] Backport patches
   
   - Related issues
   
   Fixes #1357 .
   
   ___
   ### Bugfix
   - Description
   
   As described in #1357 , we decide to move the skip logic to Storage from Store. This PR is going to achieve that.
   
   - How to fix?
   
   Remove `Skipped` field from `Event` object and Storage will eliminate the invalid data before sending to Store anymore.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] imjoey commented on pull request #1359: fix: Skip the data directly in Storage level

Posted by GitBox <gi...@apache.org>.
imjoey commented on pull request #1359:
URL: https://github.com/apache/apisix-dashboard/pull/1359#issuecomment-765215648


   ping @ShiningRush  @tokers @nic-chen for reviewing. Thanks.
   
   BTW, regarding to the test cases, I had to admitted that at present I've no idea about how to check if the data in etcd is skipped. Any ideas? Much appreciated.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] nic-chen merged pull request #1359: fix: Skip the data directly in Storage level

Posted by GitBox <gi...@apache.org>.
nic-chen merged pull request #1359:
URL: https://github.com/apache/apisix-dashboard/pull/1359


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org