You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/05/30 09:46:33 UTC
[GitHub] [incubator-doris] HappenLee opened a new pull request, #9858: [Bug][Fix] One Rowset have same key output in unique table
HappenLee opened a new pull request, #9858:
URL: https://github.com/apache/incubator-doris/pull/9858
# Proposed changes
Issue Number: close #9857
## Problem Summary:
Describe the overview of changes.
## Checklist(Required)
1. Does it affect the original behavior: (Yes)
2. Has unit tests been added: (Yes)
3. Has document been added or modified: (No Need)
4. Does it need to update dependencies: (No)
5. Are there any changes that cannot be rolled back: (Yes)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yangzhg merged pull request #9858: [Bug][Fix] One Rowset have same key output in unique table
Posted by GitBox <gi...@apache.org>.
yangzhg merged PR #9858:
URL: https://github.com/apache/incubator-doris/pull/9858
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9858: [Bug][Fix] One Rowset have same key output in unique table
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9858:
URL: https://github.com/apache/incubator-doris/pull/9858#issuecomment-1141034503
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9858: [Bug][Fix] One Rowset have same key output in unique table
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9858:
URL: https://github.com/apache/incubator-doris/pull/9858#issuecomment-1141034470
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] zhannngchen commented on a diff in pull request #9858: [Bug][Fix] One Rowset have same key output in unique table
Posted by GitBox <gi...@apache.org>.
zhannngchen commented on code in PR #9858:
URL: https://github.com/apache/doris/pull/9858#discussion_r922951190
##########
be/src/olap/tuple_reader.cpp:
##########
@@ -186,15 +186,24 @@ Status TupleReader::_unique_key_next_row(RowCursor* row_cursor, MemPool* mem_poo
// in UNIQUE_KEY highest version is the final result, there is no need to
// merge the lower versions
direct_copy_row(row_cursor, *_next_key);
- // skip the lower version rows;
- auto res = _collect_iter.next(&_next_key, &_next_delete_flag);
- if (LIKELY(res.precise_code() != OLAP_ERR_DATA_EOF)) {
- if (UNLIKELY(!res.ok())) {
- LOG(WARNING) << "next failed: " << res;
- return res;
+ while (_next_key) {
+ // skip the lower version rows;
+ auto res = _collect_iter.next(&_next_key, &_next_delete_flag);
+ if (LIKELY(res.precise_code() != OLAP_ERR_DATA_EOF)) {
+ if (UNLIKELY(!res.ok())) {
+ LOG(WARNING) << "next failed: " << res;
+ return res;
+ }
+
+ if (!equal_row(_key_cids, *row_cursor, *_next_key)) {
Review Comment:
@HappenLee Why do we need to merge keys here?
1. If there are duplicate keys in one rowset, the MergeIterator will merge them.
2. If there are duplicate keys between rowsets, the CollectIterator will merge them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org