[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #1107: system/libuv: Support specify stack size for worker thread

[GitBox <gi...@apache.org>]

xiaoxiang781216 commented on a change in pull request #1107:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1107#discussion_r837244980



##########
File path: system/libuv/0001-libuv-port-for-nuttx.patch
##########
@@ -169,7 +169,24 @@ index 869ae95f..8fabeba5 100644
  }
  
  
-@@ -212,7 +217,7 @@ static void init_threads(void) {
+@@ -188,6 +193,16 @@ static void init_threads(void) {
+   const char* val;
+   uv_sem_t sem;
+ 
++  const uv_thread_options_t params = {
++#ifdef DEF_THREADPOOL_STACKSIZE

Review comment:
       We need ensure the same code still can built on other platform and with the result. And we plan to upstream the change to libuv community, so it's important to make the change as general as possible.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org