[jira] [Commented] (COUCHDB-3307) Limit calls to maybe_add_sys_db_callbacks to once per db open

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/COUCHDB-3307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15879246#comment-15879246 ] 

ASF GitHub Bot commented on COUCHDB-3307:
-----------------------------------------

GitHub user brkolla opened a pull request:

    https://github.com/apache/couchdb-couch/pull/230

    Add sys db callbacks only once per db open

    Currently we are adding the sys db callbacks for every request instead once
    while opening the db. This fix will ensure that we will only add the sys
    db calls backs once while opening the db.
    
    COUCHDB-3307

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cloudant/couchdb-couch add_sysdb_callback_once_per_db

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/couchdb-couch/pull/230.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #230
    
----
commit e046427283961be73e2077ac990f3f0428cb8d2d
Author: brkolla <bk...@cloudant.com>
Date:   2017-02-19T21:33:39Z

    Add sys db callbacks only once per db open
    
    Currently we are adding the sys db callbacks for every request instead once
    while opening the db. This fix will ensure that we will only add the sys
    db calls backs once while opening the db.
    
    COUCHDB-3307

----


> Limit calls to maybe_add_sys_db_callbacks to once per db open
> -------------------------------------------------------------
>
>                 Key: COUCHDB-3307
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-3307
>             Project: CouchDB
>          Issue Type: Bug
>          Components: Database Core
>            Reporter: Bala Kolla
>
> As part of performance regression testing we found out that there is a code change in 
>             {{couch_server:open/2,
>             Options = maybe_add_sys_db_callbacks(DbName, Options0)}}
> As a result of this change we are basically calling {{maybe_add_sys_db_callbacks}} for each request instead of once per db open.
> We have fixed and executed a GET performance benchmark and found the following improvements.
> * Throughput: Up to ~5% improvement.
> * 20% improvement in p90 and p99 latencies



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)