You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/03/29 18:03:23 UTC

[GitHub] [activemq] Charlie-chenchrl opened a new pull request #642: fix BrokerServiceTest by replacing powermock

Charlie-chenchrl opened a new pull request #642:
URL: https://github.com/apache/activemq/pull/642


   ### Changes
   - BrokerServiceTest in `activemq-unit-tests` is failing because powermock 1.7.4 doesn't work with newly updated Mockito 3.8.0. [Error Message](https://github.com/Charlie-chenchrl/activemq/runs/2216193106?check_suite_focus=true#step:9:1533)
   - BrokerServiceTest used powermock to mock static functions, since Mockito start to support static mocks from 3.4.0 and this is the only place we use powermock, we can replace powermock with Mockito
   
   ### Test
   - run `mvn clean test -Dtest=BrokerServiceTest`, test result in local CI: https://github.com/Charlie-chenchrl/activemq/runs/2216276748?check_suite_focus=true#step:7:195 (line 195)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq] jbonofre merged pull request #642: fix BrokerServiceTest by replacing powermock

Posted by GitBox <gi...@apache.org>.
jbonofre merged pull request #642:
URL: https://github.com/apache/activemq/pull/642


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq] jbonofre commented on pull request #642: fix BrokerServiceTest by replacing powermock

Posted by GitBox <gi...@apache.org>.
jbonofre commented on pull request #642:
URL: https://github.com/apache/activemq/pull/642#issuecomment-810333245


   I'm testing the fix locally as `full.test` profile is not use on Jenkins by default.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org