You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Di Li <di...@ca.ibm.com> on 2017/05/12 17:11:35 UTC

Review Request 59232: AMBARI-20984 Be able to include stack repos in blueprint

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59232/
-----------------------------------------------------------

Review request for Ambari, Robert Nettleton and Tim Thorpe.


Bugs: AMBARI-20984
    https://issues.apache.org/jira/browse/AMBARI-20984


Repository: ambari


Description
-------

Currently, if a user wants to use custom HDP repos during a blueprint deployment, he has to update the repo URLs before hand via a REST API. The JIRA here proposes a way to include stack repos in the blueprint as optional fields so that when the fields exist, Ambari server will use the repos to deploy a cluster. This eliminates the need for user to run a separate rest api call before the actual blueprint deployment.
Attachments


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java c655c62 
  ambari-server/src/main/java/org/apache/ambari/server/topology/Blueprint.java 139a1ee 
  ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintImpl.java 826e4e5 
  ambari-server/src/main/java/org/apache/ambari/server/topology/RepositorySetting.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/topology/Setting.java 555192c 
  ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java f5cf498 
  ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterDeployWithStartOnlyTest.java c8d4d55 
  ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterInstallWithoutStartOnComponentLevelTest.java 4c9815c 
  ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterInstallWithoutStartTest.java 1bdeb1b 
  ambari-server/src/test/java/org/apache/ambari/server/topology/SettingTest.java 0007acf 
  ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java 0378753 


Diff: https://reviews.apache.org/r/59232/diff/1/


Testing
-------

unit tests. patch a trunk cluster with the change and use  blueprint to install a cluster.

The section to add to the bp for the repos is

  "settings" : [
    {
	  "repository_settings" : [
		{
		  "override_strategy":"ALWAYS_APPLY",
		  "operating_system":"redhat7",
		  "repo_id":"HDP-2.6", 
		  "repo_name":"HDP", 
		  "base_url":"http://s3.amazonaws.com/dev.hortonworks.com/HDP/centos7/2.x/BUILDS/2.6.0.3-8"
		},
		{
		  "override_strategy":"EXISTING",
		  "operating_system":"redhat6",
		  "repo_id": "HDP-UTILS-1.1.0.21",
		  "repo_name": "HDP-UTILS",
		  "base_url": "http://public-repo-1.hortonworks.com/HDP-UTILS-1.1.0.21/repos/centos7"
		}
	  ]
    }
  ],


Thanks,

Di Li


Re: Review Request 59232: AMBARI-20984 Be able to include stack repos in blueprint

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59232/#review174820
-----------------------------------------------------------




ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
Lines 942 (patched)
<https://reviews.apache.org/r/59232/#comment248040>

    Why would metaInfoDAO be null?



ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
Lines 945 (patched)
<https://reviews.apache.org/r/59232/#comment248041>

    Looks like these should be in an else. What if both baseUrl and mirrorsList are present.



ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintImpl.java
Lines 622 (patched)
<https://reviews.apache.org/r/59232/#comment248042>

    Add javadoc to all the new functions



ambari-server/src/main/java/org/apache/ambari/server/topology/RepositorySetting.java
Lines 21 (patched)
<https://reviews.apache.org/r/59232/#comment248044>

    Add Java Doc



ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java
Lines 357 (patched)
<https://reviews.apache.org/r/59232/#comment248043>

    Make these log messages more descriptive


- Alejandro Fernandez


On May 12, 2017, 5:13 p.m., Di Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59232/
> -----------------------------------------------------------
> 
> (Updated May 12, 2017, 5:13 p.m.)
> 
> 
> Review request for Ambari, Robert Nettleton and Tim Thorpe.
> 
> 
> Bugs: AMBARI-20984
>     https://issues.apache.org/jira/browse/AMBARI-20984
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Currently, if a user wants to use custom HDP repos during a blueprint deployment, he has to update the repo URLs before hand via a REST API. The JIRA here proposes a way to include stack repos in the blueprint as optional fields so that when the fields exist, Ambari server will use the repos to deploy a cluster. This eliminates the need for user to run a separate rest api call before the actual blueprint deployment.
> Attachments
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java c655c62 
>   ambari-server/src/main/java/org/apache/ambari/server/topology/Blueprint.java 139a1ee 
>   ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintImpl.java 826e4e5 
>   ambari-server/src/main/java/org/apache/ambari/server/topology/RepositorySetting.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/topology/Setting.java 555192c 
>   ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java f5cf498 
>   ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterDeployWithStartOnlyTest.java c8d4d55 
>   ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterInstallWithoutStartOnComponentLevelTest.java 4c9815c 
>   ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterInstallWithoutStartTest.java 1bdeb1b 
>   ambari-server/src/test/java/org/apache/ambari/server/topology/SettingTest.java 0007acf 
>   ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java 0378753 
> 
> 
> Diff: https://reviews.apache.org/r/59232/diff/1/
> 
> 
> Testing
> -------
> 
> unit tests. patch a trunk cluster with the change and use  blueprint to install a cluster.
> 
> The section to add to the bp for the repos is like the following.
> 
> override_strategy - ALWAYS_APPLY will override the existing repo info stored in the metainfo table in the Ambari db. APPLY_WHEN_MISSING will only insert repo info to the metainfo table if there is no such entries in the table yet.
> 
>   "settings" : [
>     {
> 	  "repository_settings" : [
> 		{
> 		  "override_strategy":"ALWAYS_APPLY",
> 		  "operating_system":"redhat7",
> 		  "repo_id":"HDP-2.6", 
> 		  "base_url":"http://s3.amazonaws.com/dev.hortonworks.com/HDP/centos7/2.x/BUILDS/2.6.0.3-8"
> 		},
> 		{
> 		  "override_strategy":"APPLY_WHEN_MISSING",
> 		  "operating_system":"redhat7",
> 		  "repo_id": "HDP-UTILS-1.1.0.21",
> 		  "base_url": "http://public-repo-1.hortonworks.com/HDP-UTILS-1.1.0.21/repos/centos7"
> 		}
> 	  ]
>     }
>   ],
> 
> 
> Thanks,
> 
> Di Li
> 
>


Re: Review Request 59232: AMBARI-20984 Be able to include stack repos in blueprint

Posted by Tim Thorpe <tt...@ca.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59232/#review174844
-----------------------------------------------------------


Ship it!




Ship It!

- Tim Thorpe


On May 12, 2017, 7:43 p.m., Di Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59232/
> -----------------------------------------------------------
> 
> (Updated May 12, 2017, 7:43 p.m.)
> 
> 
> Review request for Ambari, Robert Nettleton and Tim Thorpe.
> 
> 
> Bugs: AMBARI-20984
>     https://issues.apache.org/jira/browse/AMBARI-20984
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Currently, if a user wants to use custom HDP repos during a blueprint deployment, he has to update the repo URLs before hand via a REST API. The JIRA here proposes a way to include stack repos in the blueprint as optional fields so that when the fields exist, Ambari server will use the repos to deploy a cluster. This eliminates the need for user to run a separate rest api call before the actual blueprint deployment.
> Attachments
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java c655c62 
>   ambari-server/src/main/java/org/apache/ambari/server/topology/Blueprint.java 139a1ee 
>   ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintImpl.java 826e4e5 
>   ambari-server/src/main/java/org/apache/ambari/server/topology/RepositorySetting.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/topology/Setting.java 555192c 
>   ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java f5cf498 
>   ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterDeployWithStartOnlyTest.java c8d4d55 
>   ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterInstallWithoutStartOnComponentLevelTest.java 4c9815c 
>   ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterInstallWithoutStartTest.java 1bdeb1b 
>   ambari-server/src/test/java/org/apache/ambari/server/topology/SettingTest.java 0007acf 
>   ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java 0378753 
> 
> 
> Diff: https://reviews.apache.org/r/59232/diff/3/
> 
> 
> Testing
> -------
> 
> unit tests. patch a trunk cluster with the change and use  blueprint to install a cluster.
> 
> The section to add to the bp for the repos is like the following.
> 
> override_strategy - ALWAYS_APPLY will override the existing repo info stored in the metainfo table in the Ambari db. APPLY_WHEN_MISSING will only insert repo info to the metainfo table if there is no such entries in the table yet.
> 
>   "settings" : [
>     {
> 	  "repository_settings" : [
> 		{
> 		  "override_strategy":"ALWAYS_APPLY",
> 		  "operating_system":"redhat7",
> 		  "repo_id":"HDP-2.6", 
> 		  "base_url":"http://s3.amazonaws.com/dev.hortonworks.com/HDP/centos7/2.x/BUILDS/2.6.0.3-8"
> 		},
> 		{
> 		  "override_strategy":"APPLY_WHEN_MISSING",
> 		  "operating_system":"redhat7",
> 		  "repo_id": "HDP-UTILS-1.1.0.21",
> 		  "base_url": "http://public-repo-1.hortonworks.com/HDP-UTILS-1.1.0.21/repos/centos7"
> 		}
> 	  ]
>     }
>   ],
> 
> 
> Thanks,
> 
> Di Li
> 
>


Re: Review Request 59232: AMBARI-20984 Be able to include stack repos in blueprint

Posted by Di Li <di...@ca.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59232/
-----------------------------------------------------------

(Updated May 12, 2017, 7:43 p.m.)


Review request for Ambari, Robert Nettleton and Tim Thorpe.


Bugs: AMBARI-20984
    https://issues.apache.org/jira/browse/AMBARI-20984


Repository: ambari


Description
-------

Currently, if a user wants to use custom HDP repos during a blueprint deployment, he has to update the repo URLs before hand via a REST API. The JIRA here proposes a way to include stack repos in the blueprint as optional fields so that when the fields exist, Ambari server will use the repos to deploy a cluster. This eliminates the need for user to run a separate rest api call before the actual blueprint deployment.
Attachments


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java c655c62 
  ambari-server/src/main/java/org/apache/ambari/server/topology/Blueprint.java 139a1ee 
  ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintImpl.java 826e4e5 
  ambari-server/src/main/java/org/apache/ambari/server/topology/RepositorySetting.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/topology/Setting.java 555192c 
  ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java f5cf498 
  ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterDeployWithStartOnlyTest.java c8d4d55 
  ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterInstallWithoutStartOnComponentLevelTest.java 4c9815c 
  ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterInstallWithoutStartTest.java 1bdeb1b 
  ambari-server/src/test/java/org/apache/ambari/server/topology/SettingTest.java 0007acf 
  ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java 0378753 


Diff: https://reviews.apache.org/r/59232/diff/3/

Changes: https://reviews.apache.org/r/59232/diff/2-3/


Testing
-------

unit tests. patch a trunk cluster with the change and use  blueprint to install a cluster.

The section to add to the bp for the repos is like the following.

override_strategy - ALWAYS_APPLY will override the existing repo info stored in the metainfo table in the Ambari db. APPLY_WHEN_MISSING will only insert repo info to the metainfo table if there is no such entries in the table yet.

  "settings" : [
    {
	  "repository_settings" : [
		{
		  "override_strategy":"ALWAYS_APPLY",
		  "operating_system":"redhat7",
		  "repo_id":"HDP-2.6", 
		  "base_url":"http://s3.amazonaws.com/dev.hortonworks.com/HDP/centos7/2.x/BUILDS/2.6.0.3-8"
		},
		{
		  "override_strategy":"APPLY_WHEN_MISSING",
		  "operating_system":"redhat7",
		  "repo_id": "HDP-UTILS-1.1.0.21",
		  "base_url": "http://public-repo-1.hortonworks.com/HDP-UTILS-1.1.0.21/repos/centos7"
		}
	  ]
    }
  ],


Thanks,

Di Li


Re: Review Request 59232: AMBARI-20984 Be able to include stack repos in blueprint

Posted by Tim Thorpe <tt...@ca.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59232/#review174840
-----------------------------------------------------------




ambari-server/src/main/java/org/apache/ambari/server/topology/RepositorySetting.java
Lines 28 (patched)
<https://reviews.apache.org/r/59232/#comment248056>

    should be OPERATING_SYSTEM not OPERATION_SYSYSTEM



ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java
Lines 363 (patched)
<https://reviews.apache.org/r/59232/#comment248057>

    "New repository setting" instead of "New RepoistorySetting".


- Tim Thorpe


On May 12, 2017, 6:47 p.m., Di Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59232/
> -----------------------------------------------------------
> 
> (Updated May 12, 2017, 6:47 p.m.)
> 
> 
> Review request for Ambari, Robert Nettleton and Tim Thorpe.
> 
> 
> Bugs: AMBARI-20984
>     https://issues.apache.org/jira/browse/AMBARI-20984
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Currently, if a user wants to use custom HDP repos during a blueprint deployment, he has to update the repo URLs before hand via a REST API. The JIRA here proposes a way to include stack repos in the blueprint as optional fields so that when the fields exist, Ambari server will use the repos to deploy a cluster. This eliminates the need for user to run a separate rest api call before the actual blueprint deployment.
> Attachments
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java c655c62 
>   ambari-server/src/main/java/org/apache/ambari/server/topology/Blueprint.java 139a1ee 
>   ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintImpl.java 826e4e5 
>   ambari-server/src/main/java/org/apache/ambari/server/topology/RepositorySetting.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/topology/Setting.java 555192c 
>   ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java f5cf498 
>   ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterDeployWithStartOnlyTest.java c8d4d55 
>   ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterInstallWithoutStartOnComponentLevelTest.java 4c9815c 
>   ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterInstallWithoutStartTest.java 1bdeb1b 
>   ambari-server/src/test/java/org/apache/ambari/server/topology/SettingTest.java 0007acf 
>   ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java 0378753 
> 
> 
> Diff: https://reviews.apache.org/r/59232/diff/2/
> 
> 
> Testing
> -------
> 
> unit tests. patch a trunk cluster with the change and use  blueprint to install a cluster.
> 
> The section to add to the bp for the repos is like the following.
> 
> override_strategy - ALWAYS_APPLY will override the existing repo info stored in the metainfo table in the Ambari db. APPLY_WHEN_MISSING will only insert repo info to the metainfo table if there is no such entries in the table yet.
> 
>   "settings" : [
>     {
> 	  "repository_settings" : [
> 		{
> 		  "override_strategy":"ALWAYS_APPLY",
> 		  "operating_system":"redhat7",
> 		  "repo_id":"HDP-2.6", 
> 		  "base_url":"http://s3.amazonaws.com/dev.hortonworks.com/HDP/centos7/2.x/BUILDS/2.6.0.3-8"
> 		},
> 		{
> 		  "override_strategy":"APPLY_WHEN_MISSING",
> 		  "operating_system":"redhat7",
> 		  "repo_id": "HDP-UTILS-1.1.0.21",
> 		  "base_url": "http://public-repo-1.hortonworks.com/HDP-UTILS-1.1.0.21/repos/centos7"
> 		}
> 	  ]
>     }
>   ],
> 
> 
> Thanks,
> 
> Di Li
> 
>


Re: Review Request 59232: AMBARI-20984 Be able to include stack repos in blueprint

Posted by Di Li <di...@ca.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59232/
-----------------------------------------------------------

(Updated May 12, 2017, 6:47 p.m.)


Review request for Ambari, Robert Nettleton and Tim Thorpe.


Bugs: AMBARI-20984
    https://issues.apache.org/jira/browse/AMBARI-20984


Repository: ambari


Description
-------

Currently, if a user wants to use custom HDP repos during a blueprint deployment, he has to update the repo URLs before hand via a REST API. The JIRA here proposes a way to include stack repos in the blueprint as optional fields so that when the fields exist, Ambari server will use the repos to deploy a cluster. This eliminates the need for user to run a separate rest api call before the actual blueprint deployment.
Attachments


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java c655c62 
  ambari-server/src/main/java/org/apache/ambari/server/topology/Blueprint.java 139a1ee 
  ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintImpl.java 826e4e5 
  ambari-server/src/main/java/org/apache/ambari/server/topology/RepositorySetting.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/topology/Setting.java 555192c 
  ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java f5cf498 
  ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterDeployWithStartOnlyTest.java c8d4d55 
  ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterInstallWithoutStartOnComponentLevelTest.java 4c9815c 
  ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterInstallWithoutStartTest.java 1bdeb1b 
  ambari-server/src/test/java/org/apache/ambari/server/topology/SettingTest.java 0007acf 
  ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java 0378753 


Diff: https://reviews.apache.org/r/59232/diff/2/

Changes: https://reviews.apache.org/r/59232/diff/1-2/


Testing
-------

unit tests. patch a trunk cluster with the change and use  blueprint to install a cluster.

The section to add to the bp for the repos is like the following.

override_strategy - ALWAYS_APPLY will override the existing repo info stored in the metainfo table in the Ambari db. APPLY_WHEN_MISSING will only insert repo info to the metainfo table if there is no such entries in the table yet.

  "settings" : [
    {
	  "repository_settings" : [
		{
		  "override_strategy":"ALWAYS_APPLY",
		  "operating_system":"redhat7",
		  "repo_id":"HDP-2.6", 
		  "base_url":"http://s3.amazonaws.com/dev.hortonworks.com/HDP/centos7/2.x/BUILDS/2.6.0.3-8"
		},
		{
		  "override_strategy":"APPLY_WHEN_MISSING",
		  "operating_system":"redhat7",
		  "repo_id": "HDP-UTILS-1.1.0.21",
		  "base_url": "http://public-repo-1.hortonworks.com/HDP-UTILS-1.1.0.21/repos/centos7"
		}
	  ]
    }
  ],


Thanks,

Di Li


Re: Review Request 59232: AMBARI-20984 Be able to include stack repos in blueprint

Posted by Di Li <di...@ca.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59232/
-----------------------------------------------------------

(Updated May 12, 2017, 5:13 p.m.)


Review request for Ambari, Robert Nettleton and Tim Thorpe.


Bugs: AMBARI-20984
    https://issues.apache.org/jira/browse/AMBARI-20984


Repository: ambari


Description
-------

Currently, if a user wants to use custom HDP repos during a blueprint deployment, he has to update the repo URLs before hand via a REST API. The JIRA here proposes a way to include stack repos in the blueprint as optional fields so that when the fields exist, Ambari server will use the repos to deploy a cluster. This eliminates the need for user to run a separate rest api call before the actual blueprint deployment.
Attachments


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java c655c62 
  ambari-server/src/main/java/org/apache/ambari/server/topology/Blueprint.java 139a1ee 
  ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintImpl.java 826e4e5 
  ambari-server/src/main/java/org/apache/ambari/server/topology/RepositorySetting.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/topology/Setting.java 555192c 
  ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java f5cf498 
  ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterDeployWithStartOnlyTest.java c8d4d55 
  ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterInstallWithoutStartOnComponentLevelTest.java 4c9815c 
  ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterInstallWithoutStartTest.java 1bdeb1b 
  ambari-server/src/test/java/org/apache/ambari/server/topology/SettingTest.java 0007acf 
  ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java 0378753 


Diff: https://reviews.apache.org/r/59232/diff/1/


Testing (updated)
-------

unit tests. patch a trunk cluster with the change and use  blueprint to install a cluster.

The section to add to the bp for the repos is like the following.

override_strategy - ALWAYS_APPLY will override the existing repo info stored in the metainfo table in the Ambari db. APPLY_WHEN_MISSING will only insert repo info to the metainfo table if there is no such entries in the table yet.

  "settings" : [
    {
	  "repository_settings" : [
		{
		  "override_strategy":"ALWAYS_APPLY",
		  "operating_system":"redhat7",
		  "repo_id":"HDP-2.6", 
		  "base_url":"http://s3.amazonaws.com/dev.hortonworks.com/HDP/centos7/2.x/BUILDS/2.6.0.3-8"
		},
		{
		  "override_strategy":"APPLY_WHEN_MISSING",
		  "operating_system":"redhat7",
		  "repo_id": "HDP-UTILS-1.1.0.21",
		  "base_url": "http://public-repo-1.hortonworks.com/HDP-UTILS-1.1.0.21/repos/centos7"
		}
	  ]
    }
  ],


Thanks,

Di Li