[GitHub] [doris] englefly commented on a diff in pull request #18865: [refactor](Nereids): move out misunderstanding func from JoinUtils

["englefly (via GitHub)" <gi...@apache.org>]

englefly commented on code in PR #18865:
URL: https://github.com/apache/doris/pull/18865#discussion_r1173328480


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/physical/PhysicalHashJoin.java:
##########
@@ -98,6 +95,31 @@ public PhysicalHashJoin(
                 groupExpression, logicalProperties, physicalProperties, statistics, leftChild, rightChild);
     }
 
+    /**
+     * Get all used slots from hashJoinConjuncts of join.
+     * Return pair of left used slots and right used slots.
+     */
+    public Pair<List<ExprId>, List<ExprId>> getHashConjunctsExprIds() {

Review Comment:
   LogicalJoin also has hashJoinConjuncts. why only PhysicalHashJoin getHashConjunctsExprIds?
   In my understanding, this change disables LogicalJoin to getHashConjunctsExprIds.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org