You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by "Claus Ibsen (JIRA)" <ji...@apache.org> on 2011/04/21 14:14:05 UTC
[jira] [Created] (CAMEL-3888) Tighten up @deprecated in camel-core
to add more details what alternatives to use
Tighten up @deprecated in camel-core to add more details what alternatives to use
---------------------------------------------------------------------------------
Key: CAMEL-3888
URL: https://issues.apache.org/jira/browse/CAMEL-3888
Project: Camel
Issue Type: Improvement
Components: camel-core
Affects Versions: 2.7.0
Reporter: Claus Ibsen
Assignee: Claus Ibsen
Priority: Minor
Fix For: 2.8.0
We should ensure all deprecated classes/methods in camel-core is documented what alternatives to use. Also if possible give a hint when it could be removed.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (CAMEL-3888) Tighten up @deprecated in camel-core
to add more details what alternatives to use
Posted by "Hadrian Zbarcea (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-3888?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hadrian Zbarcea reopened CAMEL-3888:
------------------------------------
@Claus, if you read more carefully, the reason for reopening was that we need to document what to use instead of the deprecated feature. Has this been done? How would a user know what to do? Why did you mark the issue as resolved?
> Tighten up @deprecated in camel-core to add more details what alternatives to use
> ---------------------------------------------------------------------------------
>
> Key: CAMEL-3888
> URL: https://issues.apache.org/jira/browse/CAMEL-3888
> Project: Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 2.7.0
> Reporter: Claus Ibsen
> Assignee: Claus Ibsen
> Priority: Minor
> Fix For: 2.8.0
>
>
> We should ensure all deprecated classes/methods in camel-core is documented what alternatives to use. Also if possible give a hint when it could be removed.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CAMEL-3888) Tighten up @deprecated in
camel-core to add more details what alternatives to use
Posted by "Hadrian Zbarcea (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-3888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13022797#comment-13022797 ]
Hadrian Zbarcea commented on CAMEL-3888:
----------------------------------------
I believe most of the users are looking at the wiki/manual we need to document there. I'll take care of it.
> Tighten up @deprecated in camel-core to add more details what alternatives to use
> ---------------------------------------------------------------------------------
>
> Key: CAMEL-3888
> URL: https://issues.apache.org/jira/browse/CAMEL-3888
> Project: Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 2.7.0
> Reporter: Claus Ibsen
> Assignee: Hadrian Zbarcea
> Priority: Minor
> Fix For: 2.8.0
>
>
> We should ensure all deprecated classes/methods in camel-core is documented what alternatives to use. Also if possible give a hint when it could be removed.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CAMEL-3888) Tighten up @deprecated in
camel-core to add more details what alternatives to use
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-3888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13022779#comment-13022779 ]
Claus Ibsen commented on CAMEL-3888:
------------------------------------
Dan/Hadrian you are welcome to look at the added documentation to @deprecated javadoc. The easiest is probably to see this commit rev: http://svn.apache.org/viewvc?rev=1095673&view=rev
I spotted a minor mistake and corrected it in this: http://svn.apache.org/viewvc?rev=1095735&view=rev
I checked all the @Deprecated/@deprecated i could find in camel-core/src/main/java (eg in main, and *not* test).
You are of course welcome to improve the documentation if you find anything needed to be added.
> Tighten up @deprecated in camel-core to add more details what alternatives to use
> ---------------------------------------------------------------------------------
>
> Key: CAMEL-3888
> URL: https://issues.apache.org/jira/browse/CAMEL-3888
> Project: Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 2.7.0
> Reporter: Claus Ibsen
> Assignee: Claus Ibsen
> Priority: Minor
> Fix For: 2.8.0
>
>
> We should ensure all deprecated classes/methods in camel-core is documented what alternatives to use. Also if possible give a hint when it could be removed.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CAMEL-3888) Tighten up @deprecated in
camel-core to add more details what alternatives to use
Posted by "Hadrian Zbarcea (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-3888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13022767#comment-13022767 ]
Hadrian Zbarcea commented on CAMEL-3888:
----------------------------------------
@Claus, this issue was initially assigned to you. If you don't plan to add the necessary documentation, unassign or assign to somebody else. Just don't mark it resolved, because it is not.
> Tighten up @deprecated in camel-core to add more details what alternatives to use
> ---------------------------------------------------------------------------------
>
> Key: CAMEL-3888
> URL: https://issues.apache.org/jira/browse/CAMEL-3888
> Project: Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 2.7.0
> Reporter: Claus Ibsen
> Assignee: Claus Ibsen
> Priority: Minor
> Fix For: 2.8.0
>
>
> We should ensure all deprecated classes/methods in camel-core is documented what alternatives to use. Also if possible give a hint when it could be removed.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CAMEL-3888) Tighten up @deprecated in camel-core
to add more details what alternatives to use
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-3888?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claus Ibsen resolved CAMEL-3888.
--------------------------------
Resolution: Fixed
> Tighten up @deprecated in camel-core to add more details what alternatives to use
> ---------------------------------------------------------------------------------
>
> Key: CAMEL-3888
> URL: https://issues.apache.org/jira/browse/CAMEL-3888
> Project: Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 2.7.0
> Reporter: Claus Ibsen
> Assignee: Claus Ibsen
> Priority: Minor
> Fix For: 2.8.0
>
>
> We should ensure all deprecated classes/methods in camel-core is documented what alternatives to use. Also if possible give a hint when it could be removed.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CAMEL-3888) Tighten up @deprecated in camel-core
to add more details what alternatives to use
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-3888?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claus Ibsen resolved CAMEL-3888.
--------------------------------
Resolution: Fixed
> Tighten up @deprecated in camel-core to add more details what alternatives to use
> ---------------------------------------------------------------------------------
>
> Key: CAMEL-3888
> URL: https://issues.apache.org/jira/browse/CAMEL-3888
> Project: Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 2.7.0
> Reporter: Claus Ibsen
> Assignee: Claus Ibsen
> Priority: Minor
> Fix For: 2.8.0
>
>
> We should ensure all deprecated classes/methods in camel-core is documented what alternatives to use. Also if possible give a hint when it could be removed.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CAMEL-3888) Tighten up @deprecated in
camel-core to add more details what alternatives to use
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-3888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13047859#comment-13047859 ]
Claus Ibsen commented on CAMEL-3888:
------------------------------------
Information about @deprecation in the API is standard documented in the java doc. And this is where users would expect the information and go look.
We have never had any special wiki page or the likes where @deprecated API is being further detailed.
IMHO this ticket can be resolved.
> Tighten up @deprecated in camel-core to add more details what alternatives to use
> ---------------------------------------------------------------------------------
>
> Key: CAMEL-3888
> URL: https://issues.apache.org/jira/browse/CAMEL-3888
> Project: Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 2.7.0
> Reporter: Claus Ibsen
> Assignee: Hadrian Zbarcea
> Priority: Minor
> Fix For: 2.8.0
>
>
> We should ensure all deprecated classes/methods in camel-core is documented what alternatives to use. Also if possible give a hint when it could be removed.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (CAMEL-3888) Tighten up @deprecated in camel-core
to add more details what alternatives to use
Posted by "Daniel Kulp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-3888?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Kulp reopened CAMEL-3888:
--------------------------------
This is definitely not resolved. There are a lot of tests that are using DefaultErrorHandlerBuilder.handled which is marked deprecated. So far, I haven't found any documentation about an alternative to use. THere are a bunch (22) of tests that use it and I haven't been able to figure out any type of alternative for it. Thus, IMO, if there isn't an alternative and is important enough to be required by a bunch of tests, I have to wonder why it's deprecated. But no details on that either.
Similar situation for TryDefinition.handled. Deprecated, no alternative. For TryDefinition, I could see a "rethrow()" or similar method added to define that behavior (which would match the Java users expectation), but that certainly isn't there right now.
> Tighten up @deprecated in camel-core to add more details what alternatives to use
> ---------------------------------------------------------------------------------
>
> Key: CAMEL-3888
> URL: https://issues.apache.org/jira/browse/CAMEL-3888
> Project: Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 2.7.0
> Reporter: Claus Ibsen
> Assignee: Claus Ibsen
> Priority: Minor
> Fix For: 2.8.0
>
>
> We should ensure all deprecated classes/methods in camel-core is documented what alternatives to use. Also if possible give a hint when it could be removed.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CAMEL-3888) Tighten up @deprecated in camel-core
to add more details what alternatives to use
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-3888?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claus Ibsen resolved CAMEL-3888.
--------------------------------
Resolution: Fixed
deprecated API is standard documented in the javadoc as any other project
> Tighten up @deprecated in camel-core to add more details what alternatives to use
> ---------------------------------------------------------------------------------
>
> Key: CAMEL-3888
> URL: https://issues.apache.org/jira/browse/CAMEL-3888
> Project: Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 2.7.0
> Reporter: Claus Ibsen
> Assignee: Hadrian Zbarcea
> Priority: Minor
> Fix For: 2.8.0
>
>
> We should ensure all deprecated classes/methods in camel-core is documented what alternatives to use. Also if possible give a hint when it could be removed.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CAMEL-3888) Tighten up @deprecated in
camel-core to add more details what alternatives to use
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-3888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13022768#comment-13022768 ]
Claus Ibsen commented on CAMEL-3888:
------------------------------------
Yes a suggestion for alternative has been added in the @deprecated javadoc.
> Tighten up @deprecated in camel-core to add more details what alternatives to use
> ---------------------------------------------------------------------------------
>
> Key: CAMEL-3888
> URL: https://issues.apache.org/jira/browse/CAMEL-3888
> Project: Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 2.7.0
> Reporter: Claus Ibsen
> Assignee: Claus Ibsen
> Priority: Minor
> Fix For: 2.8.0
>
>
> We should ensure all deprecated classes/methods in camel-core is documented what alternatives to use. Also if possible give a hint when it could be removed.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (CAMEL-3888) Tighten up @deprecated in camel-core
to add more details what alternatives to use
Posted by "Hadrian Zbarcea (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-3888?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hadrian Zbarcea reassigned CAMEL-3888:
--------------------------------------
Assignee: Hadrian Zbarcea (was: Claus Ibsen)
> Tighten up @deprecated in camel-core to add more details what alternatives to use
> ---------------------------------------------------------------------------------
>
> Key: CAMEL-3888
> URL: https://issues.apache.org/jira/browse/CAMEL-3888
> Project: Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 2.7.0
> Reporter: Claus Ibsen
> Assignee: Hadrian Zbarcea
> Priority: Minor
> Fix For: 2.8.0
>
>
> We should ensure all deprecated classes/methods in camel-core is documented what alternatives to use. Also if possible give a hint when it could be removed.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CAMEL-3888) Tighten up @deprecated in
camel-core to add more details what alternatives to use
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-3888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13022760#comment-13022760 ]
Claus Ibsen commented on CAMEL-3888:
------------------------------------
Dan as said before just because a method is deprecated do *not* mean we should not unit test it. And hence why you would see unit test that uses the deprecated methods.
The handled(true|false) on try .. catch, error handler, was a mistake and there are *no* alternative on those. Instead you should use for example onException (exception clause). Or in case of a doCatch you can rethrow the exception if you want that.
> Tighten up @deprecated in camel-core to add more details what alternatives to use
> ---------------------------------------------------------------------------------
>
> Key: CAMEL-3888
> URL: https://issues.apache.org/jira/browse/CAMEL-3888
> Project: Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 2.7.0
> Reporter: Claus Ibsen
> Assignee: Claus Ibsen
> Priority: Minor
> Fix For: 2.8.0
>
>
> We should ensure all deprecated classes/methods in camel-core is documented what alternatives to use. Also if possible give a hint when it could be removed.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira