You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2021/03/08 06:34:31 UTC
[GitHub] [hive] pkumarsinha commented on a change in pull request #2029: HIVE-24818 : REPL LOAD (Bootstrap ) of views with partitions fails
pkumarsinha commented on a change in pull request #2029:
URL: https://github.com/apache/hive/pull/2029#discussion_r589189783
##########
File path: itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/TestReplicationScenarios.java
##########
@@ -2851,6 +2854,8 @@ public void testViewsReplication() throws IOException {
verifyRun("SELECT * from " + replDbName + ".virtual_view", empty, driverMirror);
//verifyRun("SELECT a from " + replDbName + ".mat_view", ptn_data_1, driverMirror);
+ verifySetup("SELECT * from " + replDbName + ".virtual_view_with_partition", empty, driver);
Review comment:
Shouldn't the same issue be there in incremental case also? If so, I think we should add a test for incremental also and modify the bug synopsis by removing 'bootstrap' word in it.
##########
File path: itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/TestReplicationScenarios.java
##########
@@ -2851,6 +2854,8 @@ public void testViewsReplication() throws IOException {
verifyRun("SELECT * from " + replDbName + ".virtual_view", empty, driverMirror);
//verifyRun("SELECT a from " + replDbName + ".mat_view", ptn_data_1, driverMirror);
+ verifySetup("SELECT * from " + replDbName + ".virtual_view_with_partition", empty, driver);
Review comment:
Also, can we have one non-empty table also covered?
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplLoadTask.java
##########
@@ -438,7 +438,7 @@ private TaskTracker addLoadFunctionTasks(Context loadContext, BootstrapEventsIte
// texts using new DB name. Currently it refers to the source database name.
}
- CreateViewDesc desc = new CreateViewDesc(dbDotView, table.getAllCols(), null, table.getParameters(),
+ CreateViewDesc desc = new CreateViewDesc(dbDotView, table.getCols(), null, table.getParameters(),
Review comment:
The first variant of method - createViewTask: Line:427 seems to be unused. Should we remove it altogether?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org