You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Quanlong Huang (Code Review)" <ge...@cloudera.org> on 2023/11/06 02:03:01 UTC
[Impala-ASF-CR] IMPALA-12535: Fix misleading metric keys for the threadz page
Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20658
Change subject: IMPALA-12535: Fix misleading metric keys for the threadz page
......................................................................
IMPALA-12535: Fix misleading metric keys for the threadz page
The debug URL "/thread-group?all&json" returns metric keys as user_ns,
kernel_ns, and iowait_ns. However, the unit is second instead of
nanosecond. This fixes the misleading metric keys.
Change-Id: I15a8cf0a318bc7122d1f5df29f18d8e467249ef7
---
M be/src/util/thread.cc
M www/thread-group.tmpl
2 files changed, 12 insertions(+), 12 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/58/20658/1
--
To view, visit http://gerrit.cloudera.org:8080/20658
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I15a8cf0a318bc7122d1f5df29f18d8e467249ef7
Gerrit-Change-Number: 20658
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-12535: Fix misleading metric keys for the threadz page
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20658 )
Change subject: IMPALA-12535: Fix misleading metric keys for the threadz page
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/20658
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15a8cf0a318bc7122d1f5df29f18d8e467249ef7
Gerrit-Change-Number: 20658
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Fri, 17 Nov 2023 04:23:12 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12535: Fix misleading metric keys for the threadz page
Posted by "Yida Wu (Code Review)" <ge...@cloudera.org>.
Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/20658 )
Change subject: IMPALA-12535: Fix misleading metric keys for the threadz page
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/20658
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15a8cf0a318bc7122d1f5df29f18d8e467249ef7
Gerrit-Change-Number: 20658
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Mon, 06 Nov 2023 02:15:39 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12535: Fix misleading metric keys for the threadz page
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Hello Daniel Becker, Yida Wu, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20658
to look at the new patch set (#2).
Change subject: IMPALA-12535: Fix misleading metric keys for the threadz page
......................................................................
IMPALA-12535: Fix misleading metric keys for the threadz page
The debug URL "/thread-group?all&json" returns metric keys as user_ns,
kernel_ns, and iowait_ns. However, the unit is second instead of
nanosecond. This fixes the misleading metric keys.
Tests:
- Add test in test_io_mgr_threads to verify the metric keys.
Change-Id: I15a8cf0a318bc7122d1f5df29f18d8e467249ef7
---
M be/src/util/thread.cc
M tests/webserver/test_web_pages.py
M www/thread-group.tmpl
3 files changed, 19 insertions(+), 12 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/58/20658/2
--
To view, visit http://gerrit.cloudera.org:8080/20658
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I15a8cf0a318bc7122d1f5df29f18d8e467249ef7
Gerrit-Change-Number: 20658
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
[Impala-ASF-CR] IMPALA-12535: Fix misleading metric keys for the threadz page
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/20658 )
Change subject: IMPALA-12535: Fix misleading metric keys for the threadz page
......................................................................
Patch Set 1: Code-Review+1
Do we test these keys somewhere?
--
To view, visit http://gerrit.cloudera.org:8080/20658
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15a8cf0a318bc7122d1f5df29f18d8e467249ef7
Gerrit-Change-Number: 20658
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Mon, 06 Nov 2023 16:11:33 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12535: Fix misleading metric keys for the threadz page
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20658 )
Change subject: IMPALA-12535: Fix misleading metric keys for the threadz page
......................................................................
IMPALA-12535: Fix misleading metric keys for the threadz page
The debug URL "/thread-group?all&json" returns metric keys as user_ns,
kernel_ns, and iowait_ns. However, the unit is second instead of
nanosecond. This fixes the misleading metric keys.
Tests:
- Add test in test_io_mgr_threads to verify the metric keys.
Change-Id: I15a8cf0a318bc7122d1f5df29f18d8e467249ef7
Reviewed-on: http://gerrit.cloudera.org:8080/20658
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/util/thread.cc
M tests/webserver/test_web_pages.py
M www/thread-group.tmpl
3 files changed, 19 insertions(+), 12 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/20658
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I15a8cf0a318bc7122d1f5df29f18d8e467249ef7
Gerrit-Change-Number: 20658
Gerrit-PatchSet: 4
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
[Impala-ASF-CR] IMPALA-12535: Fix misleading metric keys for the threadz page
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20658 )
Change subject: IMPALA-12535: Fix misleading metric keys for the threadz page
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/14329/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/20658
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15a8cf0a318bc7122d1f5df29f18d8e467249ef7
Gerrit-Change-Number: 20658
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Mon, 06 Nov 2023 02:30:04 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12535: Fix misleading metric keys for the threadz page
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20658 )
Change subject: IMPALA-12535: Fix misleading metric keys for the threadz page
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/20658
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15a8cf0a318bc7122d1f5df29f18d8e467249ef7
Gerrit-Change-Number: 20658
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Thu, 16 Nov 2023 23:48:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12535: Fix misleading metric keys for the threadz page
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20658 )
Change subject: IMPALA-12535: Fix misleading metric keys for the threadz page
......................................................................
Patch Set 2:
> Do we test these keys somewhere?
No, I added a test in the new patch set.
--
To view, visit http://gerrit.cloudera.org:8080/20658
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15a8cf0a318bc7122d1f5df29f18d8e467249ef7
Gerrit-Change-Number: 20658
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Wed, 08 Nov 2023 02:53:41 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12535: Fix misleading metric keys for the threadz page
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20658 )
Change subject: IMPALA-12535: Fix misleading metric keys for the threadz page
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/14367/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/20658
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15a8cf0a318bc7122d1f5df29f18d8e467249ef7
Gerrit-Change-Number: 20658
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Wed, 08 Nov 2023 03:21:13 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12535: Fix misleading metric keys for the threadz page
Posted by "Yida Wu (Code Review)" <ge...@cloudera.org>.
Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/20658 )
Change subject: IMPALA-12535: Fix misleading metric keys for the threadz page
......................................................................
Patch Set 2: Code-Review+1
LGTM!
--
To view, visit http://gerrit.cloudera.org:8080/20658
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15a8cf0a318bc7122d1f5df29f18d8e467249ef7
Gerrit-Change-Number: 20658
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Sat, 11 Nov 2023 06:41:55 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12535: Fix misleading metric keys for the threadz page
Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20658 )
Change subject: IMPALA-12535: Fix misleading metric keys for the threadz page
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/20658
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15a8cf0a318bc7122d1f5df29f18d8e467249ef7
Gerrit-Change-Number: 20658
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Tue, 14 Nov 2023 12:44:58 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12535: Fix misleading metric keys for the threadz page
Posted by "Yida Wu (Code Review)" <ge...@cloudera.org>.
Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/20658 )
Change subject: IMPALA-12535: Fix misleading metric keys for the threadz page
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/20658
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15a8cf0a318bc7122d1f5df29f18d8e467249ef7
Gerrit-Change-Number: 20658
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Thu, 16 Nov 2023 23:41:43 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12535: Fix misleading metric keys for the threadz page
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20658 )
Change subject: IMPALA-12535: Fix misleading metric keys for the threadz page
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9935/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/20658
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15a8cf0a318bc7122d1f5df29f18d8e467249ef7
Gerrit-Change-Number: 20658
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Thu, 16 Nov 2023 23:48:10 +0000
Gerrit-HasComments: No