You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2019/11/06 00:39:19 UTC
[GitHub] [pulsar-client-go] merlimat commented on a change in pull request
#61: [issue:60] Fix partition topic message router logic
merlimat commented on a change in pull request #61: [issue:60] Fix partition topic message router logic
URL: https://github.com/apache/pulsar-client-go/pull/61#discussion_r342731449
##########
File path: pulsar/impl_producer.go
##########
@@ -45,14 +48,18 @@ func newProducer(client *client, options *ProducerOptions) (*producer, error) {
return nil, newError(ResultInvalidTopicName, "Topic name is required for producer")
}
+ if options.BatchingMaxPublishDelay == 0 {
+ options.BatchingMaxPublishDelay = defaultBatchingMaxPublishDelay
Review comment:
Received options structs should be treated as immutable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services