You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by "vinx13 (via GitHub)" <gi...@apache.org> on 2023/06/02 00:28:00 UTC
[GitHub] [tvm] vinx13 opened a new pull request, #15010: [Unity] Fix importing tvm.contrib.cutlass
vinx13 opened a new pull request, #15010:
URL: https://github.com/apache/tvm/pull/15010
Fixed import error introduced in https://github.com/apache/tvm/pull/15001
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi commented on a diff in pull request #15010: [Unity] Fix importing tvm.contrib.cutlass
Posted by "masahi (via GitHub)" <gi...@apache.org>.
masahi commented on code in PR #15010:
URL: https://github.com/apache/tvm/pull/15010#discussion_r1213847312
##########
python/tvm/relax/backend/contrib/cutlass.py:
##########
@@ -160,7 +162,7 @@ def _check_matmul(context: PatternCheckContext) -> bool:
lhs_shape = lhs.struct_info.shape.values
rhs_shape = rhs.struct_info.shape.values
- return tvm.contrib.cutlass.build.is_shape_valid_for_cutlass_matmul(lhs_shape, rhs_shape)
+ return is_shape_valid_for_cutlass_matmul(lhs_shape, rhs_shape)
Review Comment:
Sorry I didn't notice that #15001 didn't revert the change in `contrib/cutlass.py` after the indirect dep of `cutlass/build.py` on `contrib/cutlass.py` has been removed.
Why do we need local import here? I thought it is fine for `contrib/cutlass.py` to depend on `cutlass/build.py`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi merged pull request #15010: [Unity] Fix importing tvm.contrib.cutlass
Posted by "masahi (via GitHub)" <gi...@apache.org>.
masahi merged PR #15010:
URL: https://github.com/apache/tvm/pull/15010
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] vinx13 commented on a diff in pull request #15010: [Unity] Fix importing tvm.contrib.cutlass
Posted by "vinx13 (via GitHub)" <gi...@apache.org>.
vinx13 commented on code in PR #15010:
URL: https://github.com/apache/tvm/pull/15010#discussion_r1213915690
##########
python/tvm/relax/backend/contrib/cutlass.py:
##########
@@ -160,7 +162,7 @@ def _check_matmul(context: PatternCheckContext) -> bool:
lhs_shape = lhs.struct_info.shape.values
rhs_shape = rhs.struct_info.shape.values
- return tvm.contrib.cutlass.build.is_shape_valid_for_cutlass_matmul(lhs_shape, rhs_shape)
+ return is_shape_valid_for_cutlass_matmul(lhs_shape, rhs_shape)
Review Comment:
yeah it's fine, I have updated the PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tvm-bot commented on pull request #15010: [Unity] Fix importing tvm.contrib.cutlass
Posted by "tvm-bot (via GitHub)" <gi...@apache.org>.
tvm-bot commented on PR #15010:
URL: https://github.com/apache/tvm/pull/15010#issuecomment-1572957093
<!---bot-comment-->
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
<!--bot-comment-ccs-start-->
* cc @quic-sanirudh <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
<sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi commented on a diff in pull request #15010: [Unity] Fix importing tvm.contrib.cutlass
Posted by "masahi (via GitHub)" <gi...@apache.org>.
masahi commented on code in PR #15010:
URL: https://github.com/apache/tvm/pull/15010#discussion_r1213847312
##########
python/tvm/relax/backend/contrib/cutlass.py:
##########
@@ -160,7 +162,7 @@ def _check_matmul(context: PatternCheckContext) -> bool:
lhs_shape = lhs.struct_info.shape.values
rhs_shape = rhs.struct_info.shape.values
- return tvm.contrib.cutlass.build.is_shape_valid_for_cutlass_matmul(lhs_shape, rhs_shape)
+ return is_shape_valid_for_cutlass_matmul(lhs_shape, rhs_shape)
Review Comment:
Sorry I didn't notice that #15001 didn't revert the change in `contrib/cutlass.py` after the dep of `cutlass/build.py` to `contrib/cutlass.py` has been removed.
Why do we need local import here? I thought it is fine for `contrib/cutlass.py` to depend on `cutlass/build.py`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org