You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/01/20 23:57:13 UTC
[GitHub] [tvm] slyubomirsky opened a new pull request #7318: [BYOC][WIP][potential bug?] Figuring out annotations for let expressions
slyubomirsky opened a new pull request #7318:
URL: https://github.com/apache/tvm/pull/7318
Per the discussion [here](https://discuss.tvm.apache.org/t/confusing-behavior-with-graph-partitioning/8879), it appears there is a bug with how the annotation pass handles let statements; in particular the let body seems to produce a `compiler_begin` tag without a corresponding `compiler_end` tag. In this PR, I have added a test case that demonstrates this. However, I do not know what the fix should be, if any.
@zhiics @comaniac, could you examine the behavior in this test case and determine if it is behaving as expected. If a fix is needed, I would be happy to implement it, but I do not know what the expected annotations should be.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] jroesch closed pull request #7318: [BYOC][WIP][potential bug?] Figuring out annotations for let expressions
Posted by GitBox <gi...@apache.org>.
jroesch closed pull request #7318:
URL: https://github.com/apache/tvm/pull/7318
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] manupa-arm commented on pull request #7318: [BYOC][WIP][potential bug?] Figuring out annotations for let expressions
Posted by GitBox <gi...@apache.org>.
manupa-arm commented on pull request #7318:
URL: https://github.com/apache/tvm/pull/7318#issuecomment-769693186
I think for starters, try blocking the insertion of compiler_begin to the let var -- I think body has the correct begins and ends. See if that helps.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] slyubomirsky commented on pull request #7318: [BYOC][WIP][potential bug?] Figuring out annotations for let expressions
Posted by GitBox <gi...@apache.org>.
slyubomirsky commented on pull request #7318:
URL: https://github.com/apache/tvm/pull/7318#issuecomment-769545493
@comaniac @zhiics I'm not sure I quite understand how let nodes are being handled in the code. I think the reason for the weird behavior in the given test case is that when you have `let %x = [body expression] in %x`, `InsertCompilerEndAndPropogateTarget()` just skips over the `%x` in the body statement, resulting in the current output. Would we want the final `%x` to have its own `compiler_begin` and `compiler_end`? Or would we want the body expression to begin a compiler region and the final `%x` to contain a `compiler_end`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] slyubomirsky commented on pull request #7318: [BYOC][WIP][potential bug?] Figuring out annotations for let expressions
Posted by GitBox <gi...@apache.org>.
slyubomirsky commented on pull request #7318:
URL: https://github.com/apache/tvm/pull/7318#issuecomment-769519345
Based on the discussion in the thread, it seems the final output of the let note should have a compiler_end annotation on it (the intended tagging behavior is described [here](https://discuss.tvm.apache.org/t/rfc-byoc-an-extended-graph-partitioning-flow/6028)), so I will update the test case to do that and see how I can fix the annotation pass to do the right thing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] jroesch commented on pull request #7318: [BYOC][WIP][potential bug?] Figuring out annotations for let expressions
Posted by GitBox <gi...@apache.org>.
jroesch commented on pull request #7318:
URL: https://github.com/apache/tvm/pull/7318#issuecomment-1016828497
This PR appears to be out of date, please feel free to reopen it if this is not the case.
As part of the new year we are attempting to triage the project's open pull requests to ensure that code which
is ready for review and/or merging receives adequate attention.
Thanks again for your contribution, and feel free to reach out to discuss these changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org