Re: Global configuration parameters

[Thorsten Scherler <th...@juntadeandalucia.es>]

On Thu, 2007-05-31 at 17:55 +0200, Markus Angst wrote:
> > On Wed, 2007-05-23 at 16:40 +0200, Markus Angst wrote:
> >>> On Tue, 2007-05-22 at 23:45 +0200, Markus Angst wrote:
> >>>> Joern Nettingsmeier wrote:
> >>>>> Markus Angst wrote:
> >>>>  >>
> >>>>>> My first attempt was to use lenya.properties.xml. Since this works only 
> >>>>>> globally and on a module level, I have to create a module to smuggle the 
> >>>>>> file into our publication. It works, but it feels like using a big tool 
> >>>>>> for a small task and I would need a new module for every publication 
> >>>>>> that needs its own lenya.properties.xml. I think it would be a nice 
> >>>>>> feature to have a lenya.properties.xml on a publication level (just drop 
> >>>>>> it into $PUB_HOME).
> >>>>> +1. neat idea. thorsten, iirc you came up with that feature in the first 
> >>>>> place, right? how difficult could this be?
> >>>> My Java knowledge is very limited, but I feel that tweaking 
> >>>> modules-core/properties/.../PropertiesModule.java would do.
> >>> Yeah, the only problem was that at the time I wrote the code when doing
> >>> initialize() I did not had any information about which pubs are builded.
> 
> > Feel free to save some more of my time submitting a patch.
> 
> I submitted a patch: http://issues.apache.org/bugzilla/show_bug.cgi?id=42558
> 
> It works for me but I don't know if my code changes are politically correct, so 
> please review. Any changes and comments welcome.
> 
> Thanks!
> Markus Angst

To you Markus, nice.

Will have a look soonish and apply it. 
Need to get some other projects finished atm first.

Thanks for your contribution. 

salu2
-- 
Thorsten Scherler                                 thorsten.at.apache.org
Open Source Java                      consulting, training and solutions


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org